From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Tue, 20 Aug 2013 10:51:53 +0000 Subject: Re: [PATCH 2/2] sh_eth: remove 'register_type' field from 'struct sh_eth_plat_data' Message-Id: <3069255.T0Cvttgz9W@avalon> List-Id: References: <201308180308.39941.sergei.shtylyov@cogentembedded.com> <201308180313.26607.sergei.shtylyov@cogentembedded.com> In-Reply-To: <201308180313.26607.sergei.shtylyov@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sergei Shtylyov Cc: netdev@vger.kernel.org, davem@davemloft.net, lethal@linux-sh.org, linux-sh@vger.kernel.org Hi Sergei, Thank you for the patch. On Sunday 18 August 2013 03:13:26 Sergei Shtylyov wrote: > Now that the 'register_type' field of the 'sh_eth' driver's platform data is > not used by the driver anymore, it's time to remove it and its > initializers from the SH platform code. Also move *enum* declaring values > for this field from to the local driver's header file > as they're only needed by the driver itself now... > > Signed-off-by: Sergei Shtylyov > > --- > arch/arm/mach-shmobile/board-armadillo800eva.c | 1 - > arch/arm/mach-shmobile/board-bockw.c | 1 - > arch/sh/boards/board-espt.c | 1 - > arch/sh/boards/board-sh7757lcr.c | 4 ---- > arch/sh/boards/mach-ecovec24/setup.c | 1 - > arch/sh/boards/mach-se/7724/setup.c | 1 - > arch/sh/boards/mach-sh7763rdp/setup.c | 1 - > arch/sh/kernel/cpu/sh2/setup-sh7619.c | 1 - > drivers/net/ethernet/renesas/sh_eth.h | 7 +++++++ > include/linux/sh_eth.h | 7 ------- > 10 files changed, 7 insertions(+), 18 deletions(-) [snip] > Index: net-next/drivers/net/ethernet/renesas/sh_eth.h > =================================> --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.h > +++ net-next/drivers/net/ethernet/renesas/sh_eth.h > @@ -157,6 +157,13 @@ enum { > SH_ETH_MAX_REGISTER_OFFSET, > }; > > +enum { > + SH_ETH_REG_GIGABIT, > + SH_ETH_REG_FAST_RCAR, > + SH_ETH_REG_FAST_SH4, > + SH_ETH_REG_FAST_SH3_SH2 > +}; > + Would it make sense to move this change and the one below to a separate patch to be merged through the net tree ? > /* Driver's parameters */ > #if defined(CONFIG_CPU_SH4) || defined(CONFIG_ARCH_SHMOBILE) > #define SH4_SKB_RX_ALIGN 32 > Index: net-next/include/linux/sh_eth.h > =================================> --- net-next.orig/include/linux/sh_eth.h > +++ net-next/include/linux/sh_eth.h > @@ -5,17 +5,10 @@ > #include > > enum {EDMAC_LITTLE_ENDIAN, EDMAC_BIG_ENDIAN}; > -enum { > - SH_ETH_REG_GIGABIT, > - SH_ETH_REG_FAST_RCAR, > - SH_ETH_REG_FAST_SH4, > - SH_ETH_REG_FAST_SH3_SH2 > -}; > > struct sh_eth_plat_data { > int phy; > int edmac_endian; Wouldn't it make sense to move the edmac_endian field to sh_eth_cpu_data as well ? > - int register_type; > phy_interface_t phy_interface; > void (*set_mdio_gate)(void *addr); -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 2/2] sh_eth: remove 'register_type' field from 'struct sh_eth_plat_data' Date: Tue, 20 Aug 2013 12:51:53 +0200 Message-ID: <3069255.T0Cvttgz9W@avalon> References: <201308180308.39941.sergei.shtylyov@cogentembedded.com> <201308180313.26607.sergei.shtylyov@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: netdev@vger.kernel.org, davem@davemloft.net, lethal@linux-sh.org, linux-sh@vger.kernel.org To: Sergei Shtylyov Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:45475 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378Ab3HTKum (ORCPT ); Tue, 20 Aug 2013 06:50:42 -0400 In-Reply-To: <201308180313.26607.sergei.shtylyov@cogentembedded.com> Sender: netdev-owner@vger.kernel.org List-ID: Hi Sergei, Thank you for the patch. On Sunday 18 August 2013 03:13:26 Sergei Shtylyov wrote: > Now that the 'register_type' field of the 'sh_eth' driver's platform data is > not used by the driver anymore, it's time to remove it and its > initializers from the SH platform code. Also move *enum* declaring values > for this field from to the local driver's header file > as they're only needed by the driver itself now... > > Signed-off-by: Sergei Shtylyov > > --- > arch/arm/mach-shmobile/board-armadillo800eva.c | 1 - > arch/arm/mach-shmobile/board-bockw.c | 1 - > arch/sh/boards/board-espt.c | 1 - > arch/sh/boards/board-sh7757lcr.c | 4 ---- > arch/sh/boards/mach-ecovec24/setup.c | 1 - > arch/sh/boards/mach-se/7724/setup.c | 1 - > arch/sh/boards/mach-sh7763rdp/setup.c | 1 - > arch/sh/kernel/cpu/sh2/setup-sh7619.c | 1 - > drivers/net/ethernet/renesas/sh_eth.h | 7 +++++++ > include/linux/sh_eth.h | 7 ------- > 10 files changed, 7 insertions(+), 18 deletions(-) [snip] > Index: net-next/drivers/net/ethernet/renesas/sh_eth.h > =================================================================== > --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.h > +++ net-next/drivers/net/ethernet/renesas/sh_eth.h > @@ -157,6 +157,13 @@ enum { > SH_ETH_MAX_REGISTER_OFFSET, > }; > > +enum { > + SH_ETH_REG_GIGABIT, > + SH_ETH_REG_FAST_RCAR, > + SH_ETH_REG_FAST_SH4, > + SH_ETH_REG_FAST_SH3_SH2 > +}; > + Would it make sense to move this change and the one below to a separate patch to be merged through the net tree ? > /* Driver's parameters */ > #if defined(CONFIG_CPU_SH4) || defined(CONFIG_ARCH_SHMOBILE) > #define SH4_SKB_RX_ALIGN 32 > Index: net-next/include/linux/sh_eth.h > =================================================================== > --- net-next.orig/include/linux/sh_eth.h > +++ net-next/include/linux/sh_eth.h > @@ -5,17 +5,10 @@ > #include > > enum {EDMAC_LITTLE_ENDIAN, EDMAC_BIG_ENDIAN}; > -enum { > - SH_ETH_REG_GIGABIT, > - SH_ETH_REG_FAST_RCAR, > - SH_ETH_REG_FAST_SH4, > - SH_ETH_REG_FAST_SH3_SH2 > -}; > > struct sh_eth_plat_data { > int phy; > int edmac_endian; Wouldn't it make sense to move the edmac_endian field to sh_eth_cpu_data as well ? > - int register_type; > phy_interface_t phy_interface; > void (*set_mdio_gate)(void *addr); -- Regards, Laurent Pinchart