All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: "Alexander Hölzl" <alexander.hoelzl@gmx.net>,
	robin@protonic.nl, socketcan@hartkopp.net, mkl@pengutronix.de,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	corbet@lwn.net
Cc: kernel@pengutronix.de, linux-can@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix error in J1939 documentation.
Date: Wed, 23 Oct 2024 17:28:59 +0200	[thread overview]
Message-ID: <306d6221-3cfa-4268-89f4-9331d69287e7@redhat.com> (raw)
In-Reply-To: <20241023145257.82709-1-alexander.hoelzl@gmx.net>

On 10/23/24 16:52, Alexander Hölzl wrote:
> The description of PDU1 format usage mistakenly referred to PDU2 format.
> 
> Signed-off-by: Alexander Hölzl <alexander.hoelzl@gmx.net>
> ---
>  Documentation/networking/j1939.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/networking/j1939.rst b/Documentation/networking/j1939.rst
> index e4bd7aa1f5aa..544bad175aae 100644
> --- a/Documentation/networking/j1939.rst
> +++ b/Documentation/networking/j1939.rst
> @@ -121,7 +121,7 @@ format, the Group Extension is set in the PS-field.
> 
>  On the other hand, when using PDU1 format, the PS-field contains a so-called
>  Destination Address, which is _not_ part of the PGN. When communicating a PGN
> -from user space to kernel (or vice versa) and PDU2 format is used, the PS-field
> +from user space to kernel (or vice versa) and PDU1 format is used, the PS-field
>  of the PGN shall be set to zero. The Destination Address shall be set
>  elsewhere.

You need to CC netdev or this patch will be lost,

Thanks,

Paolo


  parent reply	other threads:[~2024-10-23 15:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23 14:52 [PATCH] Fix error in J1939 documentation Alexander Hölzl
2024-10-23 15:17 ` Oleksij Rempel
2024-10-23 15:28 ` Paolo Abeni [this message]
2024-10-23 15:46   ` Vincent MAILHOL

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=306d6221-3cfa-4268-89f4-9331d69287e7@redhat.com \
    --to=pabeni@redhat.com \
    --cc=alexander.hoelzl@gmx.net \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=robin@protonic.nl \
    --cc=socketcan@hartkopp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.