From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Ouyang,
Changchun"
<changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] mbuf: clean old refcnt option
Date: Fri, 03 Apr 2015 15:57:39 +0200 [thread overview]
Message-ID: <3070066.e8G6AS7GDY@xps13> (raw)
In-Reply-To: <F52918179C57134FAEC9EA62FA2F962511AA57DA-E2R4CRU6q/6iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-04-03 05:10, Ouyang, Changchun:
> From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> > 2015-03-31 21:26, Olivier MATZ:
> > > On 03/31/2015 07:58 PM, Thomas Monjalon wrote:
> > > > CONFIG_RTE_MBUF_SCATTER_GATHER was renamed into
> > > > CONFIG_RTE_MBUF_REFCNT by commit 62814bc2e923 and removed by
> > commit 4769bc5a27cc.
> > > > Some traces remain because of delayed patches.
> > > >
> > > > It can also be removed from doxygen config.
> > > > It is now poisoned in rte_mbuf.h to warn any misuse.
> > > >
> > > > Fixes: d0dff9ba445e ("doc: sample application user guide")
> > > > Fixes: fc1f2750a3ec ("doc: programmers guide")
> > > > Fixes: 4769bc5a27cc ("mbuf: remove build option to disable refcnt")
> > > >
> > > > Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> >
> > > I have one doubt about the vhost part, as the previous doc was telling
> > > to disable refcnt option and now the behavior is equivalent to having
> > > the option always enabled. Also you are removing parts of doc that
> > > talk about CONFIG_RTE_LIBRTE_DISTRIBUTOR and
> > CONFIG_RTE_LIBRTE_IP_FRAG.
> > >
> > > It would be safer to also have an acknowledgment from a vhost expert.
> >
> > Huawei, Changchun, any opinion please?
>
> Ok to remove it from vhost user doc as the macro in code is removed.
> Thanks
> Changchun
Applied, thanks
prev parent reply other threads:[~2015-04-03 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 17:58 [PATCH] mbuf: clean old refcnt option Thomas Monjalon
[not found] ` <1427824702-5119-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-03-31 19:26 ` Olivier MATZ
[not found] ` <551AF4EF.5090104-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-04-01 19:58 ` Thomas Monjalon
2015-04-02 14:37 ` Butler, Siobhan A
2015-04-03 5:10 ` Ouyang, Changchun
[not found] ` <F52918179C57134FAEC9EA62FA2F962511AA57DA-E2R4CRU6q/6iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-04-03 13:57 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3070066.e8G6AS7GDY@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.