From: Milian Wolff <milian.wolff@kdab.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: acme@kernel.org, jolsa@kernel.org,
Jin Yao <yao.jin@linux.intel.com>,
Linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>,
David Ahern <dsahern@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
kernel-team@lge.com
Subject: Re: [PATCH v4 12/15] perf report: cache failed lookups of inlined frames
Date: Sun, 08 Oct 2017 22:28:26 +0200 [thread overview]
Message-ID: <3070389.UKGg5n47cQ@agathebauer> (raw)
In-Reply-To: <20171005034338.GC19141@danjae.aot.lge.com>
On Donnerstag, 5. Oktober 2017 05:43:38 CEST Namhyung Kim wrote:
> On Sun, Oct 01, 2017 at 04:30:57PM +0200, Milian Wolff wrote:
> > When no inlined frames could be found for a given address,
> > we did not store this information anywhere. That means we
> > potentially do the costly inliner lookup repeatedly for
> > cases where we know it can never succeed.
> >
> > This patch makes dso__parse_addr_inlines always return a
> > valid inline_node. It will be empty when no inliners are
> > found. This enables us to cache the empty list in the DSO,
> > thereby improving the performance when many addresses
> > fail to find the inliners.
> >
> > For my trivial example, the performance impact is already
> > quite significant:
> >
> > Before:
> >
> > ~~~~~
> >
> > Performance counter stats for 'perf report --stdio --inline -g srcline -s
srcline' (5 runs):
> > 594.804032 task-clock (msec) # 0.998 CPUs utilized
> > ( +- 0.07% )>
> > 53 context-switches # 0.089 K/sec
> > ( +- 4.09% )>
> > 0 cpu-migrations # 0.000 K/sec
> > ( +-100.00% )>
> > 5,687 page-faults # 0.010 M/sec
> > ( +- 0.02% )>
> > 2,300,918,213 cycles # 3.868 GHz
> > ( +- 0.09% ) 4,395,839,080 instructions
> > # 1.91 insn per cycle ( +- 0.00% )>
> > 939,177,205 branches # 1578.969 M/sec
> > ( +- 0.00% )>
> > 11,824,633 branch-misses # 1.26% of all
> > branches ( +- 0.10% )>
> > 0.596246531 seconds time elapsed
> > ( +- 0.07% )>
> > ~~~~~
> >
> > After:
> >
> > ~~~~~
> >
> > Performance counter stats for 'perf report --stdio --inline -g srcline -s
srcline' (5 runs):
> > 113.111405 task-clock (msec) # 0.990 CPUs utilized
> > ( +- 0.89% )>
> > 29 context-switches # 0.255 K/sec
> > ( +- 54.25% )>
> > 0 cpu-migrations # 0.000 K/sec
> >
> > 5,380 page-faults # 0.048 M/sec
> > ( +- 0.01% )>
> > 432,378,779 cycles # 3.823 GHz
> > ( +- 0.75% ) 670,057,633 instructions
> > # 1.55 insn per cycle ( +- 0.01% ) 141,001,247
> > branches # 1246.570 M/sec (
> > +- 0.01% )>
> > 2,346,845 branch-misses # 1.66% of all
> > branches ( +- 0.19% )>
> > 0.114222393 seconds time elapsed
> > ( +- 1.19% )>
> > ~~~~~
> >
> > Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> > Cc: David Ahern <dsahern@gmail.com>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Cc: Yao Jin <yao.jin@linux.intel.com>
> > Signed-off-by: Milian Wolff <milian.wolff@kdab.com>
> > ---
>
> [SNIP]
>
> > diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c
> > index 69241d805275..26d9954dc19e 100644
> > --- a/tools/perf/util/srcline.c
> > +++ b/tools/perf/util/srcline.c
> > @@ -353,17 +353,8 @@ static struct inline_node *addr2inlines(const char
> > *dso_name, u64 addr,>
> > INIT_LIST_HEAD(&node->val);
> > node->addr = addr;
> >
> > - if (!addr2line(dso_name, addr, NULL, NULL, dso, TRUE, node, sym))
> > - goto out_free_inline_node;
> > -
> > - if (list_empty(&node->val))
> > - goto out_free_inline_node;
> > -
> > - return node;
> > -
> > -out_free_inline_node:
> > - inline_node__delete(node);
> > - return NULL;
> > + addr2line(dso_name, addr, NULL, NULL, dso, TRUE, node, sym);
> > + return node;
>
> Whitespace demanged.
>
> Also please use 'true' instead of 'TRUE' for consistency (I know this
> is not your fault).
Done for the next iteration of this series, thanks!
--
Milian Wolff | milian.wolff@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
next prev parent reply other threads:[~2017-10-08 20:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-01 14:30 [PATCH v4 00/15] generate full callchain cursor entries for inlined frames Milian Wolff
2017-10-01 14:30 ` [PATCH v4 01/15] perf report: remove code to handle inline frames from browsers Milian Wolff
2017-10-01 14:30 ` [PATCH v4 02/15] perf util: store srcline in callchain_cursor_node Milian Wolff
2017-10-01 14:30 ` [PATCH v4 03/15] perf util: refactor inline_list to operate on symbols Milian Wolff
2017-10-05 1:56 ` Namhyung Kim
2017-10-08 19:53 ` Milian Wolff
2017-10-01 14:30 ` [PATCH v4 04/15] perf util: refactor inline_list to store srcline string directly Milian Wolff
2017-10-01 14:30 ` [PATCH v4 05/15] perf report: create real callchain entries for inlined frames Milian Wolff
2017-10-05 3:35 ` Namhyung Kim
2017-10-08 20:26 ` Milian Wolff
2017-10-01 14:30 ` [PATCH v4 06/15] perf report: fall-back to function name comparison for -g srcline Milian Wolff
2017-10-01 14:30 ` [PATCH v4 07/15] perf report: mark inlined frames in output by " (inlined)" suffix Milian Wolff
2017-10-01 14:30 ` [PATCH v4 08/15] perf script: mark inlined frames and do not print DSO for them Milian Wolff
2017-10-01 14:30 ` [PATCH v4 09/15] perf report: compare symbol name for inlined frames when matching Milian Wolff
2017-10-01 14:30 ` [PATCH v4 10/15] perf report: compare symbol name for inlined frames when sorting Milian Wolff
2017-10-01 14:30 ` [PATCH v4 11/15] perf report: properly handle branch count in match_chain Milian Wolff
2017-10-01 14:30 ` [PATCH v4 12/15] perf report: cache failed lookups of inlined frames Milian Wolff
2017-10-05 3:43 ` Namhyung Kim
2017-10-08 20:28 ` Milian Wolff [this message]
2017-10-01 14:30 ` [PATCH v4 13/15] perf report: cache srclines for callchain nodes Milian Wolff
2017-10-01 14:30 ` [PATCH v4 14/15] perf report: use srcline from callchain for hist entries Milian Wolff
2017-10-05 4:08 ` Namhyung Kim
2017-10-09 20:21 ` Milian Wolff
2017-10-01 14:31 ` [PATCH v4 15/15] perf util: enable handling of inlined frames by default Milian Wolff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3070389.UKGg5n47cQ@agathebauer \
--to=milian.wolff@kdab.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=kernel-team@lge.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.