All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>
Subject: Re: [PATCH v5] build: prevent accidentally building without NUMA support
Date: Tue, 27 Jun 2023 15:27:10 +0200	[thread overview]
Message-ID: <3070559.U3zVgo479M@thomas> (raw)
In-Reply-To: <20230615143854.374384-1-bruce.richardson@intel.com>

15/06/2023 16:38, Bruce Richardson:
> When libnuma development package is missing on a system, DPDK can still
> be built but will be missing much-needed support for NUMA memory
> management. This may later cause issues at runtime if the resulting
> binary is run on a NUMA system.
> 
> We can reduce the incidence of such runtime errors by ensuring that, for
> native builds*, libnuma is present - unless the user actually specifies
> via "max_numa_nodes" that they don't require NUMA support. Having this
> as an error condition is also in keeping with what is documented in the
> Linux GSG doc, where libnuma is listed as a requirement for building
> DPDK [1].
> 
> * NOTE: cross-compilation builds have a different logic set, with a
>   separate "numa" value indicating if numa support is necessary.
> 
> [1] https://doc.dpdk.org/guides-23.03/linux_gsg/sys_reqs.html
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> 
> ---
> V5: Rebase on main, since dependencies merged
> 
> V4: Add Depends-on tag so CI picks up dependency
> 
> V3:
> - install 32-bit libnuma packages on CI systems [thanks to David
>   for the changes]
> - split the patch out of the previous patchset, so it can be tracked
>   separately from the more minor fixup changes.
> 
> V2: Limit check to linux only

Is the test ci/Intel-compilation fixed?
Could you send a new version for testing the CI?




  reply	other threads:[~2023-06-27 13:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-13 16:58 [PATCH v3] build: prevent accidentally building without NUMA support Bruce Richardson
2023-06-13 17:08 ` [PATCH v4] " Bruce Richardson
2023-06-15 14:38 ` [PATCH v5] " Bruce Richardson
2023-06-27 13:27   ` Thomas Monjalon [this message]
2023-06-28  3:03     ` Tu, Lijuan
2023-07-03 15:14       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3070559.U3zVgo479M@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.