Re: [dpdk-dev] [PATCH] drivers/net/bonding: fix bug for lacp negotiation failed

[Thomas Monjalon <thomas@monjalon.net>]

Any review please?

19/05/2020 13:18, luyicai:
> When two host is connected directly without any devices like switch,
> and also enable dedicated tx/rx queues on bonding devices slaves,
> rx_machine_update would recieving partner lacp negotiation packets,
> which partner's port mac filled with zeros. So in this situation,
> it would never go rx_machine branch with correct mac!
> Thus bond mode 4 will negotiation failed.
> 
> Signed-off-by: luyicai <luyicai@huawei.com>
> ---
>  drivers/net/bonding/rte_eth_bond_8023ad.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
> index b77a37d..2002ec0 100644
> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
> @@ -798,7 +798,8 @@
>  		RTE_ASSERT(lacp->lacpdu.subtype == SLOW_SUBTYPE_LACP);
>  
>  		partner = &lacp->lacpdu.partner;
> -		if (rte_is_same_ether_addr(&partner->port_params.system,
> +		if (rte_is_zero_ether_addr(&partner->port_params.system) ||
> +			rte_is_same_ether_addr(&partner->port_params.system,
>  			&internals->mode4.mac_addr)) {
>  			/* This LACP frame is sending to the bonding port
>  			 * so pass it to rx_machine.
>