From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75010C4CECB for ; Thu, 12 Sep 2019 11:06:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5144C20692 for ; Thu, 12 Sep 2019 11:06:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731291AbfILLGb (ORCPT ); Thu, 12 Sep 2019 07:06:31 -0400 Received: from mail.thorsis.com ([92.198.35.195]:43925 "EHLO mail.thorsis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731203AbfILLGa (ORCPT ); Thu, 12 Sep 2019 07:06:30 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.thorsis.com (Postfix) with ESMTP id 7BD944858; Thu, 12 Sep 2019 13:08:05 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.thorsis.com Received: from mail.thorsis.com ([127.0.0.1]) by localhost (mail.thorsis.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aqkhD7EjSDJZ; Thu, 12 Sep 2019 13:08:05 +0200 (CEST) Received: by mail.thorsis.com (Postfix, from userid 109) id 655798D6B; Thu, 12 Sep 2019 13:08:02 +0200 (CEST) From: Alexander Dahl To: linux-arm-kernel@lists.infradead.org Cc: Eugen.Hristev@microchip.com, mturquette@baylibre.com, sboyd@kernel.org, alexandre.belloni@bootlin.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: at91: allow 24 Mhz clock as input for PLL Date: Thu, 12 Sep 2019 13:06:20 +0200 Message-ID: <30755021.BkS3ObC0RA@ada> In-Reply-To: <1568183622-7858-1-git-send-email-eugen.hristev@microchip.com> References: <1568183622-7858-1-git-send-email-eugen.hristev@microchip.com> Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hello, out of curiosity: The SAMA5D27-SOM1-EK board has a 24 MHz crystal, that is also what /sys/kernel/debug/clk/clk_summary says and the board runs without obvious problems. What is this change improving in real practice then? Greets Alex Am Mittwoch, 11. September 2019, 06:39:20 CEST schrieb Eugen.Hristev@microchip.com: > From: Eugen Hristev > > The PLL input range needs to be able to allow 24 Mhz crystal as input > Update the range accordingly in plla characteristics struct > > Signed-off-by: Eugen Hristev > --- > drivers/clk/at91/sama5d2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/at91/sama5d2.c b/drivers/clk/at91/sama5d2.c > index 6509d09..0de1108 100644 > --- a/drivers/clk/at91/sama5d2.c > +++ b/drivers/clk/at91/sama5d2.c > @@ -21,7 +21,7 @@ static const struct clk_range plla_outputs[] = { > }; > > static const struct clk_pll_characteristics plla_characteristics = { > - .input = { .min = 12000000, .max = 12000000 }, > + .input = { .min = 12000000, .max = 24000000 }, > .num_output = ARRAY_SIZE(plla_outputs), > .output = plla_outputs, > .icpll = plla_icpll, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08ABAC4CECB for ; Thu, 12 Sep 2019 11:16:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D147D20684 for ; Thu, 12 Sep 2019 11:16:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NlWHCcbo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D147D20684 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=thorsis.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=S+BzQZiZILEuI876tDplzzB8yMGm6lwt9eWbqBlrjTw=; b=NlWHCcboyMRtnvZU5WmEYMxom5 jh+8llxcZ7lgYMMig+/vB+r9CV6aFL6K3TmTDeeyg35iSMC3mtg7vJAZf0AAcEvuItYUQ7iSwHEJp 1XgSPaxBusHhEJRAKkSPTEIwLC6OVgIBHkrfgZiP4aCF19D+TM1WSgMq5ZIt9mcNPAY3djlJk219g LP5Hne+dsXZ3f12xhf9NA+tUHA04/7DblPEDcmmXisUdV786EDJi15wUYHbnEQcsXTlb7FoWiyPeI BSis3+JxNopr5h31VVmiqdkGK77LolVTzG3Fv8qxV6N9dC9wAixUw1qvdBynezHeHCWEF8K4YUWId 7fAIXOJQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8N4z-0005WD-He; Thu, 12 Sep 2019 11:16:01 +0000 Received: from mail.thorsis.com ([92.198.35.195]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8N4v-0005Vk-D9 for linux-arm-kernel@lists.infradead.org; Thu, 12 Sep 2019 11:15:59 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.thorsis.com (Postfix) with ESMTP id 4FF2F8BDB for ; Thu, 12 Sep 2019 13:08:05 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.thorsis.com Received: from mail.thorsis.com ([127.0.0.1]) by localhost (mail.thorsis.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5udyhmkdDJLh for ; Thu, 12 Sep 2019 13:08:05 +0200 (CEST) Received: by mail.thorsis.com (Postfix, from userid 109) id 480C84858; Thu, 12 Sep 2019 13:08:02 +0200 (CEST) From: Alexander Dahl To: linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] clk: at91: allow 24 Mhz clock as input for PLL Date: Thu, 12 Sep 2019 13:06:20 +0200 Message-ID: <30755021.BkS3ObC0RA@ada> In-Reply-To: <1568183622-7858-1-git-send-email-eugen.hristev@microchip.com> References: <1568183622-7858-1-git-send-email-eugen.hristev@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190912_041557_611452_81887C6C X-CRM114-Status: GOOD ( 12.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, sboyd@kernel.org, mturquette@baylibre.com, linux-kernel@vger.kernel.org, Eugen.Hristev@microchip.com, linux-clk@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, out of curiosity: The SAMA5D27-SOM1-EK board has a 24 MHz crystal, that is also what /sys/kernel/debug/clk/clk_summary says and the board runs without obvious problems. What is this change improving in real practice then? Greets Alex Am Mittwoch, 11. September 2019, 06:39:20 CEST schrieb Eugen.Hristev@microchip.com: > From: Eugen Hristev > > The PLL input range needs to be able to allow 24 Mhz crystal as input > Update the range accordingly in plla characteristics struct > > Signed-off-by: Eugen Hristev > --- > drivers/clk/at91/sama5d2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/at91/sama5d2.c b/drivers/clk/at91/sama5d2.c > index 6509d09..0de1108 100644 > --- a/drivers/clk/at91/sama5d2.c > +++ b/drivers/clk/at91/sama5d2.c > @@ -21,7 +21,7 @@ static const struct clk_range plla_outputs[] = { > }; > > static const struct clk_pll_characteristics plla_characteristics = { > - .input = { .min = 12000000, .max = 12000000 }, > + .input = { .min = 12000000, .max = 24000000 }, > .num_output = ARRAY_SIZE(plla_outputs), > .output = plla_outputs, > .icpll = plla_icpll, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel