From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] V4L: mt9m032: fix two dead-locks
Date: Mon, 09 Apr 2012 11:51:04 +0200 [thread overview]
Message-ID: <3076345.89Inf54hBS@avalon> (raw)
In-Reply-To: <Pine.LNX.4.64.1204082230360.808@axis700.grange>
Hi Guennadi,
Thanks for the patch.
On Sunday 08 April 2012 22:31:24 Guennadi Liakhovetski wrote:
> Fix a copy-paste typo and a nested locking function call in mt9m032.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree.
> ---
> drivers/media/video/mt9m032.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/video/mt9m032.c b/drivers/media/video/mt9m032.c
> index 7636672..645973c 100644
> --- a/drivers/media/video/mt9m032.c
> +++ b/drivers/media/video/mt9m032.c
> @@ -392,10 +392,11 @@ static int mt9m032_set_pad_format(struct v4l2_subdev
> *subdev, }
>
> /* Scaling is not supported, the format is thus fixed. */
> - ret = mt9m032_get_pad_format(subdev, fh, fmt);
> + fmt->format = *__mt9m032_get_pad_format(sensor, fh, fmt->which);
> + ret = 0;
>
> done:
> - mutex_lock(&sensor->lock);
> + mutex_unlock(&sensor->lock);
> return ret;
> }
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2012-04-09 9:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-08 20:31 [PATCH] V4L: mt9m032: fix two dead-locks Guennadi Liakhovetski
2012-04-09 9:51 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3076345.89Inf54hBS@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.