From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Chris Brandt <Chris.Brandt@renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Greg KH <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.cz>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] sh-sci: add R8A7743/5 support
Date: Wed, 05 Oct 2016 17:10:16 +0300 [thread overview]
Message-ID: <3079600.pjxVqDtBI9@avalon> (raw)
In-Reply-To: <SG2PR06MB1165204F1566A4B3B920F05B8AC40@SG2PR06MB1165.apcprd06.prod.outlook.com>
Hi Chris,
On Wednesday 05 Oct 2016 13:50:18 Chris Brandt wrote:
> > There are 34 compatible strings defined, one per UART + SoC combination,
> > plus a set of more generic ones. So far, the driver handles the r7s72100
> > compatible string separately as the UART on that chip is quite peculiar,
> > but for all other SoCs we only need to match against
>
> Just FYI...
> There are 2 different types of UARTS (SCI) on r7s72100: SCIF and SCI
>
> Getting the "SCI" ones to work takes some 'tweaking' of some registers in
> the interrupt controller that are outside of the scope of the SCI driver.
> Basically, the power on reset values for some IRQ signaling is wrong but
> can be adjusted with a register. At the moment, I've been fixing that in
> u-boot.
>
> So in reality, a "renesas,sci-r7s72100" is probably needed too if you want
> to throw that one on the pile....
I'm totally fine adding compatible strings when it makes sense, what bothers
me is a pile of compat strings to describe IP cores that are identical :-)
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2016-10-05 14:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 21:37 [PATCH] sh-sci: add R8A7743/5 support Sergei Shtylyov
2016-09-30 6:35 ` Simon Horman
2016-09-30 8:38 ` Geert Uytterhoeven
2016-09-30 15:06 ` Sergei Shtylyov
2016-10-05 9:55 ` Laurent Pinchart
2016-10-05 10:03 ` Geert Uytterhoeven
2016-10-05 13:28 ` Laurent Pinchart
2016-10-05 13:28 ` Rob Herring
2016-10-05 13:37 ` Laurent Pinchart
2016-10-05 13:50 ` Chris Brandt
2016-10-05 14:10 ` Laurent Pinchart [this message]
2016-10-06 20:55 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3079600.pjxVqDtBI9@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=Chris.Brandt@renesas.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.