All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Bruce Richardson
	<bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v2 0/2] 10G PMD: vectorized RX and TX functions
Date: Thu, 12 Jun 2014 00:19:17 +0200	[thread overview]
Message-ID: <3079600.trYA8PKFWl@xps13> (raw)
In-Reply-To: <1399888587-21068-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Hi Bruce,

You are introducing a new option CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE.
I feel a comment in the code would be helpful here.

Sorry for not having checked before but there are some checkpatch issues
in this PMD.
Other simple cleanup: I think some include directives are useless.

Could you rework a new version please?

Thanks
-- 
Thomas

  parent reply	other threads:[~2014-06-11 22:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-12  9:56 [PATCH v2 0/2] 10G PMD: vectorized RX and TX functions Bruce Richardson
     [not found] ` <1399888587-21068-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-05-12  9:56   ` [PATCH v2 1/2] 10G PMD: New vectorized functions for RX/TX Bruce Richardson
2014-05-12  9:56   ` [PATCH v2 2/2] 10G PMD: enable vector PMD compile for 64b linux Bruce Richardson
2014-06-06  7:11   ` [PATCH v2 0/2] 10G PMD: vectorized RX and TX functions Cao, Waterman
2014-06-11 22:19   ` Thomas Monjalon [this message]
2014-06-11 22:27     ` Richardson, Bruce
     [not found]       ` <59AF69C657FD0841A61C55336867B5B01AA35278-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-11 22:33         ` Thomas Monjalon
2014-06-13 22:52   ` [PATCH v3] 10G PMD: New vectorized functions for RX/TX Bruce Richardson
     [not found]     ` <1402699944-3902-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-06-16  8:25       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3079600.trYA8PKFWl@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.