Re: [PATCH v2 2/2] fetch2: Add gomodgit fetcher

["Christian Lindeberg" <christian.lindeberg@axis.com>]

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

On Sat, Sep 7, 2024 at 09:27 AM, Vyacheslav Yurkov wrote:

> 
> A few questions on the patchset.
> 
> - What if the module doesn't use any proxy? (E.g. hosted in a private
> repository)
> 

The gomodgit fetcher is for git repositories that needs to use the direct mode.
(Cf. https://go.dev/ref/mod#private-module-proxy-direct) ( https://go.dev/ref/mod#private-module-proxy-direct= )

> 
> - The current recipetool approach ( https://git.openembedded.org/openembedded-core/tree/scripts/lib/recipetool/create_go.py
> ) uses vendoring approach and all dependencies go into the SRC_URI. Thus
> it's required to populate the required license information for the
> manifest generation. Would that be possible with this fetcher as well?
> 

Yes, there would be no change when creating or updating the ${BPN}-licenses.inc
file compared to the vendoring approach. And then the gomod:// and gomodgit://
URLs would go into ${BPN}-modules.inc.

> 
> 
> Slava
> 
> 

Thanks,
Christian

[-- Attachment #2: Type: text/html, Size: 1465 bytes --]