From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:33104 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750800AbeETIu2 (ORCPT ); Sun, 20 May 2018 04:50:28 -0400 From: Laurent Pinchart To: Ulrich Hecht Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, Kieran Bingham Subject: Re: [PATCH 3/5] arm64: dts: renesas: r8a77995: Add LVDS support Date: Sun, 20 May 2018 11:50:50 +0300 Message-ID: <3087943.gJsCFVCJnt@avalon> In-Reply-To: <1526386840-15368-4-git-send-email-ulrich.hecht+renesas@gmail.com> References: <1526386840-15368-1-git-send-email-ulrich.hecht+renesas@gmail.com> <1526386840-15368-4-git-send-email-ulrich.hecht+renesas@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Ulrich, Thank you for the patch. On Tuesday, 15 May 2018 15:20:38 EEST Ulrich Hecht wrote: > From: Kieran Bingham > > The r8a77995 D3 platform has 2 LVDS channels connected to the DU. > > Signed-off-by: Kieran Bingham > [uli: moved lvds* into the soc node, added PM domains, resets] > Signed-off-by: Ulrich Hecht > --- > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 56 ++++++++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > b/arch/arm64/boot/dts/renesas/r8a77995.dtsi index ba98865..8e78110d 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > @@ -757,12 +757,68 @@ > port@1 { > reg = <1>; > du_out_lvds0: endpoint { > + remote-endpoint = <&lvds0_in>; > }; > }; > > port@2 { > reg = <2>; > du_out_lvds1: endpoint { > + remote-endpoint = <&lvds1_in>; > + }; > + }; > + }; > + }; > + > + lvds0: lvds-encoder@feb90000 { > + compatible = "renesas,r8a77995-lvds"; > + reg = <0 0xfeb90000 0 0x20>; > + clocks = <&cpg CPG_MOD 727>; > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > + resets = <&cpg 727>; > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + lvds0_in: endpoint { > + remote-endpoint = <&du_out_lvds0>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + lvds0_out: endpoint { > + }; > + }; > + }; > + }; > + > + lvds1: lvds-encoder@feb90100 { > + compatible = "renesas,r8a77995-lvds"; > + reg = <0 0xfeb90100 0 0x20>; > + clocks = <&cpg CPG_MOD 727>; > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > + resets = <&cpg 727>; While there seems to be a single clock for both LVDS encoders, it appears that two separate reset lines are used. Apart from that, Reviewed-by: Laurent Pinchart Given that the LVDS encoder driver isn't functional yet I wouldn't rule out a need to update the LVDS DT bindings in order to properly support D3. I don't mind if this patch gets merged already (provided the reset problem gets fixed of course), as long as it won't be considered a blocker for DT bindings rework. Otherwise I'd prefer delaying upstreaming until the whole series can be tested. > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + lvds1_in: endpoint { > + remote-endpoint = <&du_out_lvds1>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + lvds1_out: endpoint { > }; > }; > }; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 3/5] arm64: dts: renesas: r8a77995: Add LVDS support Date: Sun, 20 May 2018 11:50:50 +0300 Message-ID: <3087943.gJsCFVCJnt@avalon> References: <1526386840-15368-1-git-send-email-ulrich.hecht+renesas@gmail.com> <1526386840-15368-4-git-send-email-ulrich.hecht+renesas@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 487AB6E17C for ; Sun, 20 May 2018 08:50:28 +0000 (UTC) In-Reply-To: <1526386840-15368-4-git-send-email-ulrich.hecht+renesas@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ulrich Hecht Cc: linux-renesas-soc@vger.kernel.org, Kieran Bingham , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgVWxyaWNoLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUdWVzZGF5LCAxNSBNYXkg MjAxOCAxNToyMDozOCBFRVNUIFVscmljaCBIZWNodCB3cm90ZToKPiBGcm9tOiBLaWVyYW4gQmlu Z2hhbSA8a2llcmFuLmJpbmdoYW0rcmVuZXNhc0BpZGVhc29uYm9hcmQuY29tPgo+IAo+IFRoZSBy OGE3Nzk5NSBEMyBwbGF0Zm9ybSBoYXMgMiBMVkRTIGNoYW5uZWxzIGNvbm5lY3RlZCB0byB0aGUg RFUuCj4gCj4gU2lnbmVkLW9mZi1ieTogS2llcmFuIEJpbmdoYW0gPGtpZXJhbi5iaW5naGFtK3Jl bmVzYXNAaWRlYXNvbmJvYXJkLmNvbT4KPiBbdWxpOiBtb3ZlZCBsdmRzKiBpbnRvIHRoZSBzb2Mg bm9kZSwgYWRkZWQgUE0gZG9tYWlucywgcmVzZXRzXQo+IFNpZ25lZC1vZmYtYnk6IFVscmljaCBI ZWNodCA8dWxyaWNoLmhlY2h0K3JlbmVzYXNAZ21haWwuY29tPgo+IC0tLQo+ICBhcmNoL2FybTY0 L2Jvb3QvZHRzL3JlbmVzYXMvcjhhNzc5OTUuZHRzaSB8IDU2ICsrKysrKysrKysrKysrKysrKysr KysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDU2IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0t Z2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9yZW5lc2FzL3I4YTc3OTk1LmR0c2kKPiBiL2FyY2gv YXJtNjQvYm9vdC9kdHMvcmVuZXNhcy9yOGE3Nzk5NS5kdHNpIGluZGV4IGJhOTg4NjUuLjhlNzgx MTBkIDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcmVuZXNhcy9yOGE3Nzk5NS5k dHNpCj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9yZW5lc2FzL3I4YTc3OTk1LmR0c2kKPiBA QCAtNzU3LDEyICs3NTcsNjggQEAKPiAgCQkJCXBvcnRAMSB7Cj4gIAkJCQkJcmVnID0gPDE+Owo+ ICAJCQkJCWR1X291dF9sdmRzMDogZW5kcG9pbnQgewo+ICsJCQkJCQlyZW1vdGUtZW5kcG9pbnQg PSA8Jmx2ZHMwX2luPjsKPiAgCQkJCQl9Owo+ICAJCQkJfTsKPiAKPiAgCQkJCXBvcnRAMiB7Cj4g IAkJCQkJcmVnID0gPDI+Owo+ICAJCQkJCWR1X291dF9sdmRzMTogZW5kcG9pbnQgewo+ICsJCQkJ CQlyZW1vdGUtZW5kcG9pbnQgPSA8Jmx2ZHMxX2luPjsKPiArCQkJCQl9Owo+ICsJCQkJfTsKPiAr CQkJfTsKPiArCQl9Owo+ICsKPiArCQlsdmRzMDogbHZkcy1lbmNvZGVyQGZlYjkwMDAwIHsKPiAr CQkJY29tcGF0aWJsZSA9ICJyZW5lc2FzLHI4YTc3OTk1LWx2ZHMiOwo+ICsJCQlyZWcgPSA8MCAw eGZlYjkwMDAwIDAgMHgyMD47Cj4gKwkJCWNsb2NrcyA9IDwmY3BnIENQR19NT0QgNzI3PjsKPiAr CQkJcG93ZXItZG9tYWlucyA9IDwmc3lzYyBSOEE3Nzk5NV9QRF9BTFdBWVNfT04+Owo+ICsJCQly ZXNldHMgPSA8JmNwZyA3Mjc+Owo+ICsJCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ICsKPiArCQkJ cG9ydHMgewo+ICsJCQkJI2FkZHJlc3MtY2VsbHMgPSA8MT47Cj4gKwkJCQkjc2l6ZS1jZWxscyA9 IDwwPjsKPiArCj4gKwkJCQlwb3J0QDAgewo+ICsJCQkJCXJlZyA9IDwwPjsKPiArCQkJCQlsdmRz MF9pbjogZW5kcG9pbnQgewo+ICsJCQkJCQlyZW1vdGUtZW5kcG9pbnQgPSA8JmR1X291dF9sdmRz MD47Cj4gKwkJCQkJfTsKPiArCQkJCX07Cj4gKwo+ICsJCQkJcG9ydEAxIHsKPiArCQkJCQlyZWcg PSA8MT47Cj4gKwkJCQkJbHZkczBfb3V0OiBlbmRwb2ludCB7Cj4gKwkJCQkJfTsKPiArCQkJCX07 Cj4gKwkJCX07Cj4gKwkJfTsKPiArCj4gKwkJbHZkczE6IGx2ZHMtZW5jb2RlckBmZWI5MDEwMCB7 Cj4gKwkJCWNvbXBhdGlibGUgPSAicmVuZXNhcyxyOGE3Nzk5NS1sdmRzIjsKPiArCQkJcmVnID0g PDAgMHhmZWI5MDEwMCAwIDB4MjA+Owo+ICsJCQljbG9ja3MgPSA8JmNwZyBDUEdfTU9EIDcyNz47 Cj4gKwkJCXBvd2VyLWRvbWFpbnMgPSA8JnN5c2MgUjhBNzc5OTVfUERfQUxXQVlTX09OPjsKPiAr CQkJcmVzZXRzID0gPCZjcGcgNzI3PjsKCldoaWxlIHRoZXJlIHNlZW1zIHRvIGJlIGEgc2luZ2xl IGNsb2NrIGZvciBib3RoIExWRFMgZW5jb2RlcnMsIGl0IGFwcGVhcnMgdGhhdCAKdHdvIHNlcGFy YXRlIHJlc2V0IGxpbmVzIGFyZSB1c2VkLgoKQXBhcnQgZnJvbSB0aGF0LAoKUmV2aWV3ZWQtYnk6 IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KCkdp dmVuIHRoYXQgdGhlIExWRFMgZW5jb2RlciBkcml2ZXIgaXNuJ3QgZnVuY3Rpb25hbCB5ZXQgSSB3 b3VsZG4ndCBydWxlIG91dCBhIApuZWVkIHRvIHVwZGF0ZSB0aGUgTFZEUyBEVCBiaW5kaW5ncyBp biBvcmRlciB0byBwcm9wZXJseSBzdXBwb3J0IEQzLiBJIGRvbid0IAptaW5kIGlmIHRoaXMgcGF0 Y2ggZ2V0cyBtZXJnZWQgYWxyZWFkeSAocHJvdmlkZWQgdGhlIHJlc2V0IHByb2JsZW0gZ2V0cyBm aXhlZCAKb2YgY291cnNlKSwgYXMgbG9uZyBhcyBpdCB3b24ndCBiZSBjb25zaWRlcmVkIGEgYmxv Y2tlciBmb3IgRFQgYmluZGluZ3MgCnJld29yay4gT3RoZXJ3aXNlIEknZCBwcmVmZXIgZGVsYXlp bmcgdXBzdHJlYW1pbmcgdW50aWwgdGhlIHdob2xlIHNlcmllcyBjYW4gCmJlIHRlc3RlZC4KCj4g KwkJCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4gKwo+ICsJCQlwb3J0cyB7Cj4gKwkJCQkjYWRkcmVz cy1jZWxscyA9IDwxPjsKPiArCQkJCSNzaXplLWNlbGxzID0gPDA+Owo+ICsKPiArCQkJCXBvcnRA MCB7Cj4gKwkJCQkJcmVnID0gPDA+Owo+ICsJCQkJCWx2ZHMxX2luOiBlbmRwb2ludCB7Cj4gKwkJ CQkJCXJlbW90ZS1lbmRwb2ludCA9IDwmZHVfb3V0X2x2ZHMxPjsKPiArCQkJCQl9Owo+ICsJCQkJ fTsKPiArCj4gKwkJCQlwb3J0QDEgewo+ICsJCQkJCXJlZyA9IDwxPjsKPiArCQkJCQlsdmRzMV9v dXQ6IGVuZHBvaW50IHsKPiAgCQkJCQl9Owo+ICAJCQkJfTsKPiAgCQkJfTsKCi0tIApSZWdhcmRz LAoKTGF1cmVudCBQaW5jaGFydAoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK