All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: dhowells@redhat.com, Paul Mackerras <paulus@samba.org>,
	Arnd Bergmann <arnd@arndb.de>,
	torvalds@osdl.org, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] FRV: Wire up new syscalls
Date: Wed, 01 Jul 2009 15:10:03 +0100	[thread overview]
Message-ID: <30887.1246457403@redhat.com> (raw)
In-Reply-To: <20090701131326.GB13524@elte.hu>

Ingo Molnar <mingo@elte.hu> wrote:

> Yeah - still i'd suggest to just go with the generic code initially, 

Nah, that's no fun!  Besides, the code is very similar to the 32-bit code, and
I'm fairly certain it'll work.  I can also check it very easily by dumping
some temp test code in setup.c.

Anyway, I see the following errors:

kernel/perf_counter.c: In function 'perf_counter_index':
kernel/perf_counter.c:1889: error: 'PERF_COUNTER_INDEX_OFFSET' undeclared (first use in this function)
kernel/perf_counter.c:1889: error: (Each undeclared identifier is reported only once
kernel/perf_counter.c:1889: error: for each function it appears in.)
  CC      block/as-iosched.o
kernel/perf_counter.c:1890: warning: control reaches end of non-void function

But this symbol appears to be undocumented:

	warthog>grep -r PERF_COUNTER_INDEX_OFFSET Documentation/
	warthog1>grep -r INDEX_OFFSET Documentation/
	warthog1>

David

  reply	other threads:[~2009-07-01 14:10 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30 21:24 [PATCH] FRV: Wire up new syscalls David Howells
2009-06-30 21:34 ` Ingo Molnar
2009-06-30 21:41   ` Arnd Bergmann
2009-06-30 21:54     ` Ingo Molnar
2009-07-01 11:28       ` David Howells
2009-07-01 11:54         ` Ingo Molnar
2009-07-01 12:19           ` David Howells
2009-07-01 12:36             ` Paul Mackerras
2009-07-01 12:41               ` David Howells
2009-07-01 13:13                 ` Ingo Molnar
2009-07-01 14:10                   ` David Howells [this message]
2009-07-01 14:49                     ` Ingo Molnar
2009-07-01 15:19                       ` David Howells
2009-07-01 16:47                       ` [PATCH 1/2] FRV: Implement atomic64_t David Howells
2009-07-01 17:20                         ` Linus Torvalds
2009-07-01 17:33                           ` David Howells
2009-07-01 21:11                           ` Ingo Molnar
2009-07-01 22:57                           ` [PATCH] x86: Code atomic(64)_read and atomic(64)_set in C not CPP [was Re: FRV: Implement atomic64_t] Paul Mackerras
2009-07-02  7:21                             ` [tip:x86/urgent] x86: Code atomic(64)_read and atomic(64)_set in C not CPP tip-bot for Paul Mackerras
2009-07-02  7:21                             ` [PATCH] x86: Code atomic(64)_read and atomic(64)_set in C not CPP [was Re: FRV: Implement atomic64_t] Ingo Molnar
2009-07-01 23:46                           ` [PATCH 1/2] FRV: Implement atomic64_t [ver #2] David Howells
2009-07-01 23:46                           ` [PATCH 2/2] FRV: Add basic performance counter support " David Howells
2009-07-01 23:48                           ` [PATCH 1/2] FRV: Implement atomic64_t David Howells
2009-07-02 21:10                           ` Eric Dumazet
2009-07-02 21:28                             ` Linus Torvalds
2009-07-02 22:08                               ` [PATCH] x86: atomic64_t should be 8 bytes aligned Eric Dumazet
2009-07-02 23:53                                 ` Linus Torvalds
2009-07-03  6:14                                   ` Ingo Molnar
2009-07-03 12:42                                   ` [tip:perfcounters/urgent] x86: atomic64: The atomic64_t data type should be 8 bytes aligned on 32-bit too tip-bot for Eric Dumazet
2009-07-03 16:58                                     ` Linus Torvalds
2009-07-03 17:49                                       ` H. Peter Anvin
2009-07-03 12:42                                   ` [tip:perfcounters/urgent] x86: atomic64: Move the 32-bit atomic64_t implementation to a .c file tip-bot for Ingo Molnar
2009-07-03 16:47                                     ` Linus Torvalds
2009-07-03 18:31                                       ` [tip:perfcounters/urgent] x86: atomic64: Clean up atomic64_sub_and_test() and atomic64_add_negative() tip-bot for Ingo Molnar
2009-07-03 19:18                                       ` tip-bot for Ingo Molnar
2009-07-04  0:05                                     ` [tip:perfcounters/urgent] x86: atomic64: Move the 32-bit atomic64_t implementation to a .c file Paul Mackerras
2009-07-05 11:25                                       ` Ingo Molnar
2009-07-03 12:43                                   ` [tip:perfcounters/urgent] x86: atomic64: Improve atomic64_read() tip-bot for Eric Dumazet
2009-07-03 12:43                                   ` [tip:perfcounters/urgent] x86: atomic64: Improve cmpxchg8b() tip-bot for Eric Dumazet
2009-07-03 12:43                                   ` [tip:perfcounters/urgent] x86: atomic64: Improve atomic64_add_return() tip-bot for Ingo Molnar
2009-07-03 12:43                                   ` [tip:perfcounters/urgent] x86: atomic64: Reduce size of functions tip-bot for Ingo Molnar
2009-07-03 12:44                                   ` [tip:perfcounters/urgent] x86: atomic64: Fix unclean type use in atomic64_xchg() tip-bot for Ingo Molnar
2009-07-03 17:02                                     ` Linus Torvalds
2009-07-03 18:00                                       ` Ingo Molnar
2009-07-03 12:44                                   ` [tip:perfcounters/urgent] x86: atomic64: Improve atomic64_read() tip-bot for Eric Dumazet
2009-07-03 14:50                                     ` [PATCH -tip] x86: atomic64: inline atomic64_read() Eric Dumazet
2009-07-03 18:04                                       ` Ingo Molnar
2009-07-03 18:10                                         ` Arjan van de Ven
2009-07-03 18:18                                           ` Ingo Molnar
2009-07-03 18:25                                             ` Andi Kleen
2009-07-03 18:30                                             ` Arjan van de Ven
2009-07-03 18:43                                               ` Ingo Molnar
2009-07-03 18:24                                           ` Andi Kleen
2009-07-03 18:31                                           ` [tip:perfcounters/urgent] x86: atomic64: Optimize CMPXCHG8B sequences to not use the LOCK prefix tip-bot for Ingo Molnar
2009-07-03 18:45                                             ` Ingo Molnar
2009-07-03 19:10                                         ` [PATCH -tip] x86: atomic64: inline atomic64_read() Linus Torvalds
2009-07-03 19:17                                           ` Ingo Molnar
2009-07-03 19:38                                             ` Linus Torvalds
2009-07-03 21:40                                               ` Ingo Molnar
2009-07-03 18:31                                       ` [tip:perfcounters/urgent] x86: atomic64: Inline atomic64_read() again tip-bot for Eric Dumazet
2009-07-03 19:18                                       ` tip-bot for Eric Dumazet
2009-07-04  9:49                                       ` tip-bot for Eric Dumazet
2009-07-03 12:44                                   ` [tip:perfcounters/urgent] x86: atomic64: Code atomic(64)_read and atomic(64)_set in C not CPP tip-bot for Paul Mackerras
2009-07-03 12:48                                   ` tip-bot for Paul Mackerras
2009-07-03 12:48                                   ` [tip:perfcounters/urgent] x86: atomic64: Improve atomic64_read() tip-bot for Eric Dumazet
2009-07-03 15:33                                   ` [tip:perfcounters/urgent] x86: atomic64: Export APIs to modules tip-bot for Ingo Molnar
2009-07-03 18:30                                     ` tip-bot for Ingo Molnar
2009-07-03 18:30                                     ` [tip:perfcounters/urgent] x86: atomic64: Improve atomic64_xchg() tip-bot for Ingo Molnar
2009-07-03 12:01                               ` [patch] x86: atomic64_t: Improve atomic64_add_return() Ingo Molnar
2009-07-03 12:26                                 ` [PATCH] x86: atomic64_t: _cmpxchg() & _read() optimizations Eric Dumazet
2009-07-03 12:40                                   ` Ingo Molnar
2009-07-03 17:38                                 ` [patch] x86: atomic64_t: Improve atomic64_add_return() Linus Torvalds
2009-07-03  6:05                             ` [PATCH 1/2] FRV: Implement atomic64_t Eric Dumazet
2009-07-03 12:27                               ` Ingo Molnar
2009-07-03 12:39                                 ` Eric Dumazet
2009-07-03 11:17                             ` Ingo Molnar
2009-07-03 11:26                               ` Ingo Molnar
2009-07-01 16:47                       ` [PATCH 2/2] FRV: Add basic performance counter support David Howells
2009-07-01 21:10                         ` Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2014-11-09 16:26 [PATCH] FRV: Wire up new syscalls Faisal Abbas
2014-11-10 23:21 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30887.1246457403@redhat.com \
    --to=dhowells@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.