Re: [Buildroot] [PATCH v3 2/2] package/drogon: new package

[Julien Olivain via buildroot <buildroot@buildroot.org>]

Hi Dario,

I have few comments. See below.

On 02/01/2026 19:24, Dario Binacchi wrote:
> Drogon is a C++17/20 based HTTP application framework. It can be used 
> to
> easily build various types of web application server programs using 
> C++.
> 
> Project page: https://github.com/drogonframework/drogon
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> 
> ---
> 
> Changes v2 -> v3:
> - The PRs related to the patches have all been merged. The first PR was
>   merged by combining the three patches into a single one. Replace all
>   Upstream: links with the link to the final commit.
> - Add help text to the added KConfig options.
> - Select external libraries for BROTLI and YAML_CONFIG options.
> - Drop the host configurations. Files too.
> - Always add -DBUILD_CTL=ON to HOST_DROGON_CONF_OPTS (together with
>   -DBUILD_TESTS=OFF and -DBUILD_EXAMPLES=OFF).
> 
> Changes v1 -> v2:
> - Drop BR2_ARCH_IS_64 dependency. It has been tested on imx6ull 
> platform.
> - Add DROGON_INSTALL_STAGING
> - Add 0004-Fix-building-error-for-Werror-unused-value.patch for trantor
>   submodule.
> 
>  DEVELOPERS                                    |  1 +
>  package/Config.in                             |  1 +
>  .../0001-Fix-cross-compiling-2389.patch       | 76 +++++++++++++++++++
>  ...ilding-error-for-Werror-unused-value.patch | 42 ++++++++++
>  package/drogon/Config.in                      | 50 ++++++++++++
>  package/drogon/drogon.mk                      | 63 +++++++++++++++
>  6 files changed, 233 insertions(+)
>  create mode 100644 package/drogon/0001-Fix-cross-compiling-2389.patch
>  create mode 100644 
> package/drogon/0002-Fix-building-error-for-Werror-unused-value.patch
>  create mode 100644 package/drogon/Config.in
>  create mode 100644 package/drogon/drogon.mk
[...]
> diff --git a/package/drogon/drogon.mk b/package/drogon/drogon.mk
> new file mode 100644
> index 000000000000..06354280db07
> --- /dev/null
> +++ b/package/drogon/drogon.mk
> @@ -0,0 +1,63 @@
> +################################################################################
> +#
> +# drogon
> +#
> +################################################################################
> +
> +DROGON_VERSION = v1.9.11
> +DROGON_SITE = https://github.com/drogonframework/drogon
> +DROGON_SITE_METHOD = git
> +DROGON_GIT_SUBMODULES = YES
> +DROGON_LICENSE = MIT
> +DROGON_LICENSE_FILES = LICENSE

The drogon.hash file is missing. When running the
command "make drogon-legal-info", we can see the messages:

...
WARNING: no hash file for drogon-v1.9.11-git4.tar.gz
...
WARNING: no hash file for LICENSE

Could you add the hash file please?

Also, this package is introducing build failures. There is probably
missing dependencies.
See: https://gitlab.com/jolivain/buildroot/-/pipelines/2682597534

You can also reproduce locally with the command:
utils/test-pkg -a -p drogon

While fixing those issue, could you bump to the latest 1.9.13. This
should remove some (if not all) package patches.

Could you send an updated patch addressing those issues, please?

> +DROGON_INSTALL_STAGING = YES
> +
> +DROGON_DEPENDENCIES = jsoncpp util-linux zlib
> +HOST_DROGON_DEPENDENCIES = host-jsoncpp host-util-linux host-zlib
> +
> +DROGON_CONF_OPTS = \
> +	-DBUILD_TESTS=OFF
> +
> +HOST_DROGON_CONF_OPTS = \
> +	-DBUILD_CTL=ON \
> +	-DBUILD_EXAMPLES=OFF \
> +	-DBUILD_TESTS=OFF
> +
> +ifeq ($(BR2_PACKAGE_DROGON_BROTLI),y)
> +DROGON_DEPENDENCIES += brotli
> +DROGON_CONF_OPTS += -DBUILD_BROTLI=ON
> +else
> +DROGON_CONF_OPTS += -DBUILD_BROTLI=OFF
> +endif
> +
> +ifeq ($(BR2_PACKAGE_DROGON_CTL),y)
> +# When we have drogon_ctl for the target, we need to build the
> +# _drogon_ctl tool with host-drogon support so that it can be
> +# run during the building process
> +DROGON_DEPENDENCIES += host-drogon
> +DROGON_CONF_OPTS += -DBUILD_CTL=ON
> +else
> +DROGON_CONF_OPTS += -DBUILD_CTL=OFF
> +endif
> +
> +ifeq ($(BR2_PACKAGE_DROGON_EXAMPLES),y)
> +DROGON_CONF_OPTS += -DBUILD_EXAMPLES=ON
> +else
> +DROGON_CONF_OPTS += -DBUILD_EXMPLES=OFF
> +endif
> +
> +ifeq ($(BR2_PACKAGE_DROGON_ORM),y)
> +DROGON_CONF_OPTS += -DBUILD_ORM=ON
> +else
> +DROGON_CONF_OPTS += -DBUILD_ORM=OFF
> +endif
> +
> +ifeq ($(BR2_PACKAGE_DROGON_YAML_CONFIG),y)
> +DROGON_DEPENDENCIES += yaml-cpp
> +DROGON_CONF_OPTS += -DBUILD_YAML_CONFIG=ON
> +else
> +DROGON_CONF_OPTS += -DBUILD_YAML_CONFIG=OFF
> +endif
> +
> +$(eval $(cmake-package))
> +$(eval $(host-cmake-package))
> --
> 2.43.0

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot