All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@kernel.org>
To: Kuniyuki Iwashima <kuniyu@amazon.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Kuniyuki Iwashima <kuni1840@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next 1/2] ipv6: Remove in6addr_any alternatives.
Date: Tue, 28 Mar 2023 08:32:48 -0600	[thread overview]
Message-ID: <309a47d4-86bb-2a06-1910-3f080719ed59@kernel.org> (raw)
In-Reply-To: <20230327235455.52990-2-kuniyu@amazon.com>

On 3/27/23 5:54 PM, Kuniyuki Iwashima wrote:
> Some code defines the IPv6 wildcard address as a local variable and
> use it with memcmp() or ipv6_addr_equal().
> 
> Let's use in6addr_any and ipv6_addr_any() instead.
> 
> Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
> ---
>  .../net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c |  5 ++---
>  include/net/ip6_fib.h                                 |  9 +++------
>  include/trace/events/fib.h                            |  5 ++---
>  include/trace/events/fib6.h                           |  5 +----
>  net/ethtool/ioctl.c                                   | 10 +++++-----
>  net/ipv4/inet_hashtables.c                            | 11 ++++-------
>  6 files changed, 17 insertions(+), 28 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@kernel.org>



  parent reply	other threads:[~2023-03-28 14:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-27 23:54 [PATCH v2 net-next 0/2] ipv6: Random cleanup for in6addr_any Kuniyuki Iwashima
2023-03-27 23:54 ` [PATCH v2 net-next 1/2] ipv6: Remove in6addr_any alternatives Kuniyuki Iwashima
2023-03-28  6:27   ` Mark Bloch
2023-03-28 14:32   ` David Ahern [this message]
2023-03-27 23:54 ` [PATCH v2 net-next 2/2] 6lowpan: Remove redundant initialisation Kuniyuki Iwashima
2023-03-28  6:27   ` Mark Bloch
2023-03-28 19:00     ` Kuniyuki Iwashima
2023-03-29  8:00 ` [PATCH v2 net-next 0/2] ipv6: Random cleanup for in6addr_any patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=309a47d4-86bb-2a06-1910-3f080719ed59@kernel.org \
    --to=dsahern@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=kuni1840@gmail.com \
    --cc=kuniyu@amazon.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.