From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C8FAC433DB for ; Thu, 4 Feb 2021 14:21:46 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 892D164F51 for ; Thu, 4 Feb 2021 14:21:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 892D164F51 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0EE164B258; Thu, 4 Feb 2021 09:21:45 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A8w3DXjLzTF1; Thu, 4 Feb 2021 09:21:43 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7EB154B22D; Thu, 4 Feb 2021 09:21:43 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 40B944B1E2 for ; Thu, 4 Feb 2021 09:21:42 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6konzm5teMMY for ; Thu, 4 Feb 2021 09:21:41 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id E15234B1DA for ; Thu, 4 Feb 2021 09:21:40 -0500 (EST) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F6DA64DEB; Thu, 4 Feb 2021 14:21:39 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1l7fVp-00C1TC-Fb; Thu, 04 Feb 2021 14:21:37 +0000 MIME-Version: 1.0 Date: Thu, 04 Feb 2021 14:21:37 +0000 From: Marc Zyngier To: Alexandru Elisei Subject: Re: [PATCH v2 6/7] KVM: arm64: Upgrade PMU support to ARMv8.4 In-Reply-To: <7134513d-bccf-923f-961a-08527cf77f8e@arm.com> References: <20210125122638.2947058-1-maz@kernel.org> <20210125122638.2947058-7-maz@kernel.org> <56041147-0bd8-dbb2-d1ca-550f3db7f05d@redhat.com> <7808bec4-2ac5-a36d-2960-b4b90574e0d2@redhat.com> <7134513d-bccf-923f-961a-08527cf77f8e@arm.com> User-Agent: Roundcube Webmail/1.4.10 Message-ID: <30d455e9eacf8b4b9b43ff30b3a48309@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, eric.auger@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com, kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gMjAyMS0wMi0wNCAxMjozMiwgQWxleGFuZHJ1IEVsaXNlaSB3cm90ZToKPiBIaSwKPiAKPiBP biAyLzMvMjEgMToyOCBQTSwgTWFyYyBaeW5naWVyIHdyb3RlOgo+PiBPbiAyMDIxLTAyLTAzIDEy OjM5LCBBdWdlciBFcmljIHdyb3RlOgo+Pj4gSGksCj4+PiAKPj4+IE9uIDIvMy8yMSAxMjoyMCBQ TSwgTWFyYyBaeW5naWVyIHdyb3RlOgo+Pj4+IE9uIDIwMjEtMDItMDMgMTE6MDcsIEF1Z2VyIEVy aWMgd3JvdGU6Cj4+Pj4+IEhpIE1hcmMsCj4+Pj4+IE9uIDIvMy8yMSAxMTozNiBBTSwgTWFyYyBa eW5naWVyIHdyb3RlOgo+Pj4+Pj4gSGkgRXJpYywKPj4+Pj4+IAo+Pj4+Pj4gT24gMjAyMS0wMS0y NyAxNzo1MywgQXVnZXIgRXJpYyB3cm90ZToKPj4+Pj4+PiBIaSBNYXJjLAo+Pj4+Pj4+IAo+Pj4+ Pj4+IE9uIDEvMjUvMjEgMToyNiBQTSwgTWFyYyBaeW5naWVyIHdyb3RlOgo+Pj4+Pj4+PiBVcGdy YWRpbmcgdGhlIFBNVSBjb2RlIGZyb20gQVJNdjguMSB0byBBUk12OC40IHR1cm5zIG91dCB0byBi ZQo+Pj4+Pj4+PiBwcmV0dHkgZWFzeS4gQWxsIHRoYXQgaXMgcmVxdWlyZWQgaXMgc3VwcG9ydCBm b3IgUE1NSVJfRUwxLCAKPj4+Pj4+Pj4gd2hpY2gKPj4+Pj4+Pj4gaXMgcmVhZC1vbmx5LCBhbmQg Zm9yIHdoaWNoIHJldHVybmluZyAwIGlzIGEgdmFsaWQgb3B0aW9uIGFzIAo+Pj4+Pj4+PiBsb25n Cj4+Pj4+Pj4+IGFzIHdlIGRvbid0IGFkdmVydGlzZSBTVEFMTF9TTE9UIGFzIGFuIGltcGxlbWVu dGVkIGV2ZW50Lgo+Pj4+Pj4+PiAKPj4+Pj4+Pj4gTGV0J3MganVzdCBkbyB0aGF0IGFuZCBhZGp1 c3Qgd2hhdCB3ZSByZXR1cm4gdG8gdGhlIGd1ZXN0Lgo+Pj4+Pj4+PiAKPj4+Pj4+Pj4gU2lnbmVk LW9mZi1ieTogTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4KPj4+Pj4+Pj4gLS0tCj4+Pj4+ Pj4+IMKgYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9zeXNyZWcuaCB8wqAgMyArKysKPj4+Pj4+Pj4g wqBhcmNoL2FybTY0L2t2bS9wbXUtZW11bC5jwqDCoMKgwqDCoMKgIHzCoCA2ICsrKysrKwo+Pj4+ Pj4+PiDCoGFyY2gvYXJtNjQva3ZtL3N5c19yZWdzLmPCoMKgwqDCoMKgwqAgfCAxMSArKysrKysr LS0tLQo+Pj4+Pj4+PiDCoDMgZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgNCBkZWxl dGlvbnMoLSkKPj4+Pj4+Pj4gCj4+Pj4+Pj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2luY2x1 ZGUvYXNtL3N5c3JlZy5oCj4+Pj4+Pj4+IGIvYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9zeXNyZWcu aAo+Pj4+Pj4+PiBpbmRleCA4YjVlN2U1YzNjYzguLjJmYjNmMzg2NTg4YyAxMDA2NDQKPj4+Pj4+ Pj4gLS0tIGEvYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9zeXNyZWcuaAo+Pj4+Pj4+PiArKysgYi9h cmNoL2FybTY0L2luY2x1ZGUvYXNtL3N5c3JlZy5oCj4+Pj4+Pj4+IEBAIC04NDYsNyArODQ2LDEw IEBACj4+Pj4+Pj4+IAo+Pj4+Pj4+PiDCoCNkZWZpbmUgSURfREZSMF9QRVJGTU9OX1NISUZUwqDC oMKgwqDCoMKgwqAgMjQKPj4+Pj4+Pj4gCj4+Pj4+Pj4+ICsjZGVmaW5lIElEX0RGUjBfUEVSRk1P Tl84XzDCoMKgwqDCoMKgwqDCoCAweDMKPj4+Pj4+Pj4gwqAjZGVmaW5lIElEX0RGUjBfUEVSRk1P Tl84XzHCoMKgwqDCoMKgwqDCoCAweDQKPj4+Pj4+Pj4gKyNkZWZpbmUgSURfREZSMF9QRVJGTU9O XzhfNMKgwqDCoMKgwqDCoMKgIDB4NQo+Pj4+Pj4+PiArI2RlZmluZSBJRF9ERlIwX1BFUkZNT05f OF81wqDCoMKgwqDCoMKgwqAgMHg2Cj4+Pj4+Pj4+IAo+Pj4+Pj4+PiDCoCNkZWZpbmUgSURfSVNB UjRfU1dQX0ZSQUNfU0hJRlTCoMKgwqDCoMKgwqDCoCAyOAo+Pj4+Pj4+PiDCoCNkZWZpbmUgSURf SVNBUjRfUFNSX01fU0hJRlTCoMKgwqDCoMKgwqDCoCAyNAo+Pj4+Pj4+PiBkaWZmIC0tZ2l0IGEv YXJjaC9hcm02NC9rdm0vcG11LWVtdWwuYyAKPj4+Pj4+Pj4gYi9hcmNoL2FybTY0L2t2bS9wbXUt ZW11bC5jCj4+Pj4+Pj4+IGluZGV4IDM5OGY2ZGYxYmJlNC4uNzJjZDcwNGE4MzY4IDEwMDY0NAo+ Pj4+Pj4+PiAtLS0gYS9hcmNoL2FybTY0L2t2bS9wbXUtZW11bC5jCj4+Pj4+Pj4+ICsrKyBiL2Fy Y2gvYXJtNjQva3ZtL3BtdS1lbXVsLmMKPj4+Pj4+Pj4gQEAgLTc5NSw2ICs3OTUsMTIgQEAgdTY0 IGt2bV9wbXVfZ2V0X3BtY2VpZChzdHJ1Y3Qga3ZtX3ZjcHUgCj4+Pj4+Pj4+ICp2Y3B1LAo+Pj4+ Pj4+PiBib29sIHBtY2VpZDEpCj4+Pj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqAgYmFzZSA9IDA7Cj4+ Pj4+Pj4+IMKgwqDCoMKgIH0gZWxzZSB7Cj4+Pj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqAgdmFsID0g cmVhZF9zeXNyZWcocG1jZWlkMV9lbDApOwo+Pj4+Pj4+PiArwqDCoMKgwqDCoMKgwqAgLyoKPj4+ Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqAgKiBEb24ndCBhZHZlcnRpc2UgU1RBTExfU0xPVCwgYXMg UE1NSVJfRUwwIGlzIGhhbmRsZWQKPj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqAgKiBhcyBSQVoK Pj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqAgKi8KPj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIGlm ICh2Y3B1LT5rdm0tPmFyY2gucG11dmVyID49IElEX0FBNjRERlIwX1BNVVZFUl84XzQpCj4+Pj4+ Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHZhbCAmPSB+QklUX1VMTChBUk1WOF9QTVVWM19Q RVJGQ1RSX1NUQUxMX1NMT1QgLSAKPj4+Pj4+Pj4gMzIpOwo+Pj4+Pj4+IHdoYXQgYWJvdXQgdGhl IFNUQUxMX1NMT1RfQkFDS0VORCBhbmQgRlJPTlRFTkQgZXZlbnRzIHRoZW4/Cj4+Pj4+PiAKPj4+ Pj4+IEFyZW4ndCB0aGVzZSBhIG1hbmRhdG9yeSBBUk12OC4xIGZlYXR1cmU/IEkgZG9uJ3Qgc2Vl IGEgcmVhc29uIHRvCj4+Pj4+PiBkcm9wIHRoZW0uCj4+Pj4+IAo+Pj4+PiBJIHVuZGVyc3RhbmQg dGhlIDMgYXJlIGxpbmtlZCB0b2dldGhlci4KPj4+Pj4gCj4+Pj4+IEluIEQ3LjExIGl0IGlzIHNh aWQKPj4+Pj4gIgo+Pj4+PiBXaGVuIGFueSBvZiB0aGUgZm9sbG93aW5nIGNvbW1vbiBldmVudHMg YXJlIGltcGxlbWVudGVkLCBhbGwgdGhyZWUgCj4+Pj4+IG9mCj4+Pj4+IHRoZW0gYXJlIGltcGxl bWVudGVkOgo+Pj4+PiAweDAwM0QgLCBTVEFMTF9TTE9UX0JBQ0tFTkQsIE5vIG9wZXJhdGlvbiBz ZW50IGZvciBleGVjdXRpb24gb24gYSAKPj4+Pj4gU2xvdAo+Pj4+PiBkdWUgdG8gdGhlIGJhY2tl bmQsCj4+Pj4+IDB4MDAzRSAsIFNUQUxMX1NMT1RfRlJPTlRFTkQsIE5vIG9wZXJhdGlvbiBzZW50 IGZvciBleGVjdXRpb24gb24gYSAKPj4+Pj4gU2xvdAo+Pj4+PiBkdWUgdG8gdGhlIGZyb250ZW5k Lgo+Pj4+PiAweDAwM0YgLCBTVEFMTF9TTE9ULCBObyBvcGVyYXRpb24gc2VudCBmb3IgZXhlY3V0 aW9uIG9uIGEgU2xvdC4KPj4+Pj4gIgo+Pj4+IAo+Pj4+IFRoZXkgYXJlIGxpbmtlZCBpbiB0aGUg c2Vuc2UgdGhhdCB0aGV5IHJlcG9ydCByZWxhdGVkIGV2ZW50cywgYnV0IAo+Pj4+IHRoZXkKPj4+ PiBkb24ndCBoYXZlIHRvIGJlIGltcGxlbWVudGVkIGluIHRoZSBzYW1lIGxldmVsIG9mIHRoZSBh cmNoaXRlY3VyZSwgCj4+Pj4gaWYgb25seQo+Pj4+IGJlY2F1c2UgQkFDS0VORC9GUk9OVEVORCB3 ZXJlIGludHJvZHVjZWR3YXkgYmVmb3JlIEFSTXY4LjQuCj4+Pj4gCj4+Pj4gV2hhdCB0aGUgYXJj aGl0ZWN0dXJlIHNheXMgaXM6Cj4+Pj4gCj4+Pj4gLSBGb3IgRkVBVF9QTVV2M3AxIChBUk12OC4x KToKPj4+PiDCoCAiVGhlIFNUQUxMX0ZST05URU5EIGFuZCBTVEFMTF9CQUNLRU5EIGV2ZW50cyBh cmUgcmVxdWlyZWQgdG8gYmUKPj4+PiDCoMKgIGltcGxlbWVudGVkLiIgKEEyLjQuMSwgRERJMDQ4 N0cuYSkKPj4+IE9LCj4+Pj4gCj4+Pj4gLSBGb3IgRkVBVF9QTVV2M3A0IChBUk12OC40KToKPj4+ PiDCoCAiSWYgRkVBVF9QTVV2M3A0IGlzIGltcGxlbWVudGVkOgo+Pj4+IMKgwqAgLSBJZiBTVEFM TF9TTE9UIGlzIG5vdCBpbXBsZW1lbnRlZCwgaXQgaXMgSU1QTEVNRU5UQVRJT04gREVGSU5FRAo+ Pj4+IHdoZXRoZXIgdGhlIFBNTUlSIFN5c3RlbSByZWdpc3RlcnMgYXJlIGltcGxlbWVudGVkLgo+ Pj4+IMKgwqAgLSBJZiBTVEFMTF9TTE9UIGlzIGltcGxlbWVudGVkLCB0aGVuIHRoZSBQTU1JUiBT eXN0ZW0gcmVnaXN0ZXJzIAo+Pj4+IGFyZQo+Pj4+IGltcGxlbWVudGVkLiIgKEQ3LTI4NzMsIERE STA0ODdHLmEpCj4+Pj4gCj4+Pj4gU28gd2hpbGUgQkFDS0VORC9GUk9OVEVORCBhcmUgcmVxdWly ZWQgaW4gYW4gQVJNdjguNCBpbXBsZW1lbnRhdGlvbgo+Pj4+IGJ5IHZpcnR1ZSBvZiBiZWluZyBt YW5kYXRvcnkgaW4gQVJNdjguMSwgU1RBTExfU0xPVCBpc24ndCBhdCBhbnkgCj4+Pj4gcG9pbnQu Cj4+PiBCdXQgdGhlbiBob3cgZG8geW91IHVuZGVyc3RhbmQgIldoZW4gYW55IG9mIHRoZSBmb2xs b3dpbmcgY29tbW9uIAo+Pj4gZXZlbnRzCj4+PiBhcmUgaW1wbGVtZW50ZWQsIGFsbCB0aHJlZSBv ZiB0aGVtIGFyZSBpbXBsZW1lbnRlZCI/Cj4+IAo+PiBJIHRoaW5rIHRoYXQncyB3aG9sbHkgaW5j b25zaXN0ZW50LCBiZWNhdXNlIGl0IHdvdWxkIG1lYW4gdGhhdCAKPj4gU1RBTExfU0xPVAo+PiBp c24ndCBvcHRpb25hbCBvbiBBUk12OC40LCBhbmQgd291bGQgbWFrZSBQTU1JUiBtYW5kYXRvcnku Cj4gCj4gSSB0aGluayB0aGVyZSdzIHNvbWUgY29uZnVzaW9uIHJlZ2FyZGluZyB0aGUgZXZlbnQg bmFtZXMuIEZyb20gbXkgCj4gcmVhZGluZyBvZiB0aGUKPiBhcmNoaXRlY3R1cmUsIFNUQUxMICE9 IFNUQUxMX1NMT1QsIFNUQUxMX0JBQ0tFTkQgIT0gU1RBTExfU0xPVF9CQUNLRU5ELAo+IFNUQUxM X0ZST05URU5EICE9IFNUQUxMX1NMT1RfRlJPTlRFTkQuCgpEYW1taXQsIEkgaGFkbid0IHJlYWxp c2VkIHRoYXQgYXQgYWxsLiBUaGFua3MgZm9yIHB1dHRpbmcgbWUgcmlnaHQuCgo+IAo+IFNUQUxM eywgX0JBQ0tFTkQsIF9GUk9OVEVORH0gY291bnQgdGhlIG51bWJlciBvZiBDUFUgY3ljbGVzIHdo ZXJlIG5vCj4gaW5zdHJ1Y3Rpb25zCj4gYXJlIGJlaW5nIGV4ZWN1dGVkIG9uIHRoZSBQRSAocGFn ZSBENy0yODcyKSwgU1RBTExfU0xPVHssIF9CQUNLRU5ELCAKPiBfRlJPTlRFTkR9Cj4gY291bnQg dGhlIG51bWJlciBvZiBzbG90cyB3aGVyZSBubyBpbnN0cnVjdGlvbnMgYXJlIGJlaW5nIGV4ZWN1 dGVkCj4gKHBhZ2UgRDctMjg3MykuCj4gCj4gU1RBTExfe0JBQ0tFTkQsIEZST05URU5EfSBhcmUg cmVxdWlyZWQgYnkgQVJNdjguMS1QTVUgKHBhZ2VzIEEyLTc2LCAKPiBENy0yOTEzKTsKPiBTVEFM TCBpcyByZXF1aXJlZCBieSBBUk12OC40LVBNVSAocGFnZSBENy0yOTE0KS4KPiAKPiBTVEFMTF9T TE9UeywgX0JBQ0tFTkQsIF9GUk9OVEVORH0gYXJlIG9wdGlvbmFsIGluIEFSTXY4LjQtUE1VIChw YWdlcyAKPiBENy0yOTEzLAo+IEQ3LTI5MTQpLCBidXQgaWYgb25lIG9mIHRoZW0gaXMgaW1wbGVt ZW50ZWQsIGFsbCBvZiB0aGVtIG11c3QgYmUKPiBpbXBsZW1lbnRlZCAocGFnZSBENy0yOTE0KS4K PiAKPiBUaGUgcHJvYmxlbSBJIHNlZSB3aXRoIHRoaXMgcGF0Y2ggaXMgdGhhdCBpdCBkb2Vzbid0 IGNsZWFyIHRoZQo+IFNUQUxMX1NMT1Rfe0JBQ0tFTkQsIEZST05URU5EfSBldmVudCBiaXRzIGFs b25nIHdpdGggdGhlIFNUQUxMX1NMT1QgYml0IAo+IGZyb20KPiBQTUNFSUQxX0VMMC4KCk9LLCBz byBFcmljIHdhcyByaWdodCwgYW5kIEknbSBhbiBpbGxpdGVyYXRlIGlkaW90ISBJJ2xsIGZpeCB0 aGUgcGF0Y2ggCmFuZCByZXBvc3QKdGhlIHdob2xlIHRoaW5nLgoKVGhhbmtzLAoKICAgICAgICAg TS4KLS0gCkphenogaXMgbm90IGRlYWQuIEl0IGp1c3Qgc21lbGxzIGZ1bm55Li4uCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmt2bWFybSBtYWlsaW5nIGxp c3QKa3ZtYXJtQGxpc3RzLmNzLmNvbHVtYmlhLmVkdQpodHRwczovL2xpc3RzLmNzLmNvbHVtYmlh LmVkdS9tYWlsbWFuL2xpc3RpbmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90808C433E0 for ; Thu, 4 Feb 2021 14:22:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38E5C64DEB for ; Thu, 4 Feb 2021 14:22:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38E5C64DEB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T9jF2og+UmpZ+InD0SPDduuHLk+dkSlXjV1eJj8DLI0=; b=SQIeuX7KhavS9UL5N5dgGjk84 9g3+/V4gksoTFqZOPwM6bpYeOvAsCYo+e/5viHEeMcCLBMq5lLPKpYkZUc0A6yCD8Xjvyh1WYAOJC FmldUzz+Ca2dhGls5tZ2LbEIYEBkNZj4nys6N69qbw7hzyuUIwuPeXoyq93m+E1ZtikTgYSiwLmbr Xnm7afjxZSjmR0B5fB/w47BP36Whw6f9DCM5AiPvUzBm3DDUBXep5vFZTfARcxlvUv06Kv73B37ZA WcC+TaMtodECiHmgdvR9scpk97M/6XVOKPRWnL++535KYHkvzsJRSlyJ7pnxYQ5EORB05crxLEIC+ 6+AwMuAww==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7fVw-0001ox-7R; Thu, 04 Feb 2021 14:21:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7fVt-0001oM-AG for linux-arm-kernel@lists.infradead.org; Thu, 04 Feb 2021 14:21:42 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F6DA64DEB; Thu, 4 Feb 2021 14:21:39 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1l7fVp-00C1TC-Fb; Thu, 04 Feb 2021 14:21:37 +0000 MIME-Version: 1.0 Date: Thu, 04 Feb 2021 14:21:37 +0000 From: Marc Zyngier To: Alexandru Elisei Subject: Re: [PATCH v2 6/7] KVM: arm64: Upgrade PMU support to ARMv8.4 In-Reply-To: <7134513d-bccf-923f-961a-08527cf77f8e@arm.com> References: <20210125122638.2947058-1-maz@kernel.org> <20210125122638.2947058-7-maz@kernel.org> <56041147-0bd8-dbb2-d1ca-550f3db7f05d@redhat.com> <7808bec4-2ac5-a36d-2960-b4b90574e0d2@redhat.com> <7134513d-bccf-923f-961a-08527cf77f8e@arm.com> User-Agent: Roundcube Webmail/1.4.10 Message-ID: <30d455e9eacf8b4b9b43ff30b3a48309@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, eric.auger@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210204_092141_484442_62EDC6A6 X-CRM114-Status: GOOD ( 26.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, Suzuki K Poulose , Auger Eric , James Morse , linux-arm-kernel@lists.infradead.org, kernel-team@android.com, kvmarm@lists.cs.columbia.edu, Julien Thierry Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMS0wMi0wNCAxMjozMiwgQWxleGFuZHJ1IEVsaXNlaSB3cm90ZToKPiBIaSwKPiAKPiBP biAyLzMvMjEgMToyOCBQTSwgTWFyYyBaeW5naWVyIHdyb3RlOgo+PiBPbiAyMDIxLTAyLTAzIDEy OjM5LCBBdWdlciBFcmljIHdyb3RlOgo+Pj4gSGksCj4+PiAKPj4+IE9uIDIvMy8yMSAxMjoyMCBQ TSwgTWFyYyBaeW5naWVyIHdyb3RlOgo+Pj4+IE9uIDIwMjEtMDItMDMgMTE6MDcsIEF1Z2VyIEVy aWMgd3JvdGU6Cj4+Pj4+IEhpIE1hcmMsCj4+Pj4+IE9uIDIvMy8yMSAxMTozNiBBTSwgTWFyYyBa eW5naWVyIHdyb3RlOgo+Pj4+Pj4gSGkgRXJpYywKPj4+Pj4+IAo+Pj4+Pj4gT24gMjAyMS0wMS0y NyAxNzo1MywgQXVnZXIgRXJpYyB3cm90ZToKPj4+Pj4+PiBIaSBNYXJjLAo+Pj4+Pj4+IAo+Pj4+ Pj4+IE9uIDEvMjUvMjEgMToyNiBQTSwgTWFyYyBaeW5naWVyIHdyb3RlOgo+Pj4+Pj4+PiBVcGdy YWRpbmcgdGhlIFBNVSBjb2RlIGZyb20gQVJNdjguMSB0byBBUk12OC40IHR1cm5zIG91dCB0byBi ZQo+Pj4+Pj4+PiBwcmV0dHkgZWFzeS4gQWxsIHRoYXQgaXMgcmVxdWlyZWQgaXMgc3VwcG9ydCBm b3IgUE1NSVJfRUwxLCAKPj4+Pj4+Pj4gd2hpY2gKPj4+Pj4+Pj4gaXMgcmVhZC1vbmx5LCBhbmQg Zm9yIHdoaWNoIHJldHVybmluZyAwIGlzIGEgdmFsaWQgb3B0aW9uIGFzIAo+Pj4+Pj4+PiBsb25n Cj4+Pj4+Pj4+IGFzIHdlIGRvbid0IGFkdmVydGlzZSBTVEFMTF9TTE9UIGFzIGFuIGltcGxlbWVu dGVkIGV2ZW50Lgo+Pj4+Pj4+PiAKPj4+Pj4+Pj4gTGV0J3MganVzdCBkbyB0aGF0IGFuZCBhZGp1 c3Qgd2hhdCB3ZSByZXR1cm4gdG8gdGhlIGd1ZXN0Lgo+Pj4+Pj4+PiAKPj4+Pj4+Pj4gU2lnbmVk LW9mZi1ieTogTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4KPj4+Pj4+Pj4gLS0tCj4+Pj4+ Pj4+IMKgYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9zeXNyZWcuaCB8wqAgMyArKysKPj4+Pj4+Pj4g wqBhcmNoL2FybTY0L2t2bS9wbXUtZW11bC5jwqDCoMKgwqDCoMKgIHzCoCA2ICsrKysrKwo+Pj4+ Pj4+PiDCoGFyY2gvYXJtNjQva3ZtL3N5c19yZWdzLmPCoMKgwqDCoMKgwqAgfCAxMSArKysrKysr LS0tLQo+Pj4+Pj4+PiDCoDMgZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgNCBkZWxl dGlvbnMoLSkKPj4+Pj4+Pj4gCj4+Pj4+Pj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2luY2x1 ZGUvYXNtL3N5c3JlZy5oCj4+Pj4+Pj4+IGIvYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9zeXNyZWcu aAo+Pj4+Pj4+PiBpbmRleCA4YjVlN2U1YzNjYzguLjJmYjNmMzg2NTg4YyAxMDA2NDQKPj4+Pj4+ Pj4gLS0tIGEvYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9zeXNyZWcuaAo+Pj4+Pj4+PiArKysgYi9h cmNoL2FybTY0L2luY2x1ZGUvYXNtL3N5c3JlZy5oCj4+Pj4+Pj4+IEBAIC04NDYsNyArODQ2LDEw IEBACj4+Pj4+Pj4+IAo+Pj4+Pj4+PiDCoCNkZWZpbmUgSURfREZSMF9QRVJGTU9OX1NISUZUwqDC oMKgwqDCoMKgwqAgMjQKPj4+Pj4+Pj4gCj4+Pj4+Pj4+ICsjZGVmaW5lIElEX0RGUjBfUEVSRk1P Tl84XzDCoMKgwqDCoMKgwqDCoCAweDMKPj4+Pj4+Pj4gwqAjZGVmaW5lIElEX0RGUjBfUEVSRk1P Tl84XzHCoMKgwqDCoMKgwqDCoCAweDQKPj4+Pj4+Pj4gKyNkZWZpbmUgSURfREZSMF9QRVJGTU9O XzhfNMKgwqDCoMKgwqDCoMKgIDB4NQo+Pj4+Pj4+PiArI2RlZmluZSBJRF9ERlIwX1BFUkZNT05f OF81wqDCoMKgwqDCoMKgwqAgMHg2Cj4+Pj4+Pj4+IAo+Pj4+Pj4+PiDCoCNkZWZpbmUgSURfSVNB UjRfU1dQX0ZSQUNfU0hJRlTCoMKgwqDCoMKgwqDCoCAyOAo+Pj4+Pj4+PiDCoCNkZWZpbmUgSURf SVNBUjRfUFNSX01fU0hJRlTCoMKgwqDCoMKgwqDCoCAyNAo+Pj4+Pj4+PiBkaWZmIC0tZ2l0IGEv YXJjaC9hcm02NC9rdm0vcG11LWVtdWwuYyAKPj4+Pj4+Pj4gYi9hcmNoL2FybTY0L2t2bS9wbXUt ZW11bC5jCj4+Pj4+Pj4+IGluZGV4IDM5OGY2ZGYxYmJlNC4uNzJjZDcwNGE4MzY4IDEwMDY0NAo+ Pj4+Pj4+PiAtLS0gYS9hcmNoL2FybTY0L2t2bS9wbXUtZW11bC5jCj4+Pj4+Pj4+ICsrKyBiL2Fy Y2gvYXJtNjQva3ZtL3BtdS1lbXVsLmMKPj4+Pj4+Pj4gQEAgLTc5NSw2ICs3OTUsMTIgQEAgdTY0 IGt2bV9wbXVfZ2V0X3BtY2VpZChzdHJ1Y3Qga3ZtX3ZjcHUgCj4+Pj4+Pj4+ICp2Y3B1LAo+Pj4+ Pj4+PiBib29sIHBtY2VpZDEpCj4+Pj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqAgYmFzZSA9IDA7Cj4+ Pj4+Pj4+IMKgwqDCoMKgIH0gZWxzZSB7Cj4+Pj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqAgdmFsID0g cmVhZF9zeXNyZWcocG1jZWlkMV9lbDApOwo+Pj4+Pj4+PiArwqDCoMKgwqDCoMKgwqAgLyoKPj4+ Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqAgKiBEb24ndCBhZHZlcnRpc2UgU1RBTExfU0xPVCwgYXMg UE1NSVJfRUwwIGlzIGhhbmRsZWQKPj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqAgKiBhcyBSQVoK Pj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqAgKi8KPj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIGlm ICh2Y3B1LT5rdm0tPmFyY2gucG11dmVyID49IElEX0FBNjRERlIwX1BNVVZFUl84XzQpCj4+Pj4+ Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHZhbCAmPSB+QklUX1VMTChBUk1WOF9QTVVWM19Q RVJGQ1RSX1NUQUxMX1NMT1QgLSAKPj4+Pj4+Pj4gMzIpOwo+Pj4+Pj4+IHdoYXQgYWJvdXQgdGhl IFNUQUxMX1NMT1RfQkFDS0VORCBhbmQgRlJPTlRFTkQgZXZlbnRzIHRoZW4/Cj4+Pj4+PiAKPj4+ Pj4+IEFyZW4ndCB0aGVzZSBhIG1hbmRhdG9yeSBBUk12OC4xIGZlYXR1cmU/IEkgZG9uJ3Qgc2Vl IGEgcmVhc29uIHRvCj4+Pj4+PiBkcm9wIHRoZW0uCj4+Pj4+IAo+Pj4+PiBJIHVuZGVyc3RhbmQg dGhlIDMgYXJlIGxpbmtlZCB0b2dldGhlci4KPj4+Pj4gCj4+Pj4+IEluIEQ3LjExIGl0IGlzIHNh aWQKPj4+Pj4gIgo+Pj4+PiBXaGVuIGFueSBvZiB0aGUgZm9sbG93aW5nIGNvbW1vbiBldmVudHMg YXJlIGltcGxlbWVudGVkLCBhbGwgdGhyZWUgCj4+Pj4+IG9mCj4+Pj4+IHRoZW0gYXJlIGltcGxl bWVudGVkOgo+Pj4+PiAweDAwM0QgLCBTVEFMTF9TTE9UX0JBQ0tFTkQsIE5vIG9wZXJhdGlvbiBz ZW50IGZvciBleGVjdXRpb24gb24gYSAKPj4+Pj4gU2xvdAo+Pj4+PiBkdWUgdG8gdGhlIGJhY2tl bmQsCj4+Pj4+IDB4MDAzRSAsIFNUQUxMX1NMT1RfRlJPTlRFTkQsIE5vIG9wZXJhdGlvbiBzZW50 IGZvciBleGVjdXRpb24gb24gYSAKPj4+Pj4gU2xvdAo+Pj4+PiBkdWUgdG8gdGhlIGZyb250ZW5k Lgo+Pj4+PiAweDAwM0YgLCBTVEFMTF9TTE9ULCBObyBvcGVyYXRpb24gc2VudCBmb3IgZXhlY3V0 aW9uIG9uIGEgU2xvdC4KPj4+Pj4gIgo+Pj4+IAo+Pj4+IFRoZXkgYXJlIGxpbmtlZCBpbiB0aGUg c2Vuc2UgdGhhdCB0aGV5IHJlcG9ydCByZWxhdGVkIGV2ZW50cywgYnV0IAo+Pj4+IHRoZXkKPj4+ PiBkb24ndCBoYXZlIHRvIGJlIGltcGxlbWVudGVkIGluIHRoZSBzYW1lIGxldmVsIG9mIHRoZSBh cmNoaXRlY3VyZSwgCj4+Pj4gaWYgb25seQo+Pj4+IGJlY2F1c2UgQkFDS0VORC9GUk9OVEVORCB3 ZXJlIGludHJvZHVjZWR3YXkgYmVmb3JlIEFSTXY4LjQuCj4+Pj4gCj4+Pj4gV2hhdCB0aGUgYXJj aGl0ZWN0dXJlIHNheXMgaXM6Cj4+Pj4gCj4+Pj4gLSBGb3IgRkVBVF9QTVV2M3AxIChBUk12OC4x KToKPj4+PiDCoCAiVGhlIFNUQUxMX0ZST05URU5EIGFuZCBTVEFMTF9CQUNLRU5EIGV2ZW50cyBh cmUgcmVxdWlyZWQgdG8gYmUKPj4+PiDCoMKgIGltcGxlbWVudGVkLiIgKEEyLjQuMSwgRERJMDQ4 N0cuYSkKPj4+IE9LCj4+Pj4gCj4+Pj4gLSBGb3IgRkVBVF9QTVV2M3A0IChBUk12OC40KToKPj4+ PiDCoCAiSWYgRkVBVF9QTVV2M3A0IGlzIGltcGxlbWVudGVkOgo+Pj4+IMKgwqAgLSBJZiBTVEFM TF9TTE9UIGlzIG5vdCBpbXBsZW1lbnRlZCwgaXQgaXMgSU1QTEVNRU5UQVRJT04gREVGSU5FRAo+ Pj4+IHdoZXRoZXIgdGhlIFBNTUlSIFN5c3RlbSByZWdpc3RlcnMgYXJlIGltcGxlbWVudGVkLgo+ Pj4+IMKgwqAgLSBJZiBTVEFMTF9TTE9UIGlzIGltcGxlbWVudGVkLCB0aGVuIHRoZSBQTU1JUiBT eXN0ZW0gcmVnaXN0ZXJzIAo+Pj4+IGFyZQo+Pj4+IGltcGxlbWVudGVkLiIgKEQ3LTI4NzMsIERE STA0ODdHLmEpCj4+Pj4gCj4+Pj4gU28gd2hpbGUgQkFDS0VORC9GUk9OVEVORCBhcmUgcmVxdWly ZWQgaW4gYW4gQVJNdjguNCBpbXBsZW1lbnRhdGlvbgo+Pj4+IGJ5IHZpcnR1ZSBvZiBiZWluZyBt YW5kYXRvcnkgaW4gQVJNdjguMSwgU1RBTExfU0xPVCBpc24ndCBhdCBhbnkgCj4+Pj4gcG9pbnQu Cj4+PiBCdXQgdGhlbiBob3cgZG8geW91IHVuZGVyc3RhbmQgIldoZW4gYW55IG9mIHRoZSBmb2xs b3dpbmcgY29tbW9uIAo+Pj4gZXZlbnRzCj4+PiBhcmUgaW1wbGVtZW50ZWQsIGFsbCB0aHJlZSBv ZiB0aGVtIGFyZSBpbXBsZW1lbnRlZCI/Cj4+IAo+PiBJIHRoaW5rIHRoYXQncyB3aG9sbHkgaW5j b25zaXN0ZW50LCBiZWNhdXNlIGl0IHdvdWxkIG1lYW4gdGhhdCAKPj4gU1RBTExfU0xPVAo+PiBp c24ndCBvcHRpb25hbCBvbiBBUk12OC40LCBhbmQgd291bGQgbWFrZSBQTU1JUiBtYW5kYXRvcnku Cj4gCj4gSSB0aGluayB0aGVyZSdzIHNvbWUgY29uZnVzaW9uIHJlZ2FyZGluZyB0aGUgZXZlbnQg bmFtZXMuIEZyb20gbXkgCj4gcmVhZGluZyBvZiB0aGUKPiBhcmNoaXRlY3R1cmUsIFNUQUxMICE9 IFNUQUxMX1NMT1QsIFNUQUxMX0JBQ0tFTkQgIT0gU1RBTExfU0xPVF9CQUNLRU5ELAo+IFNUQUxM X0ZST05URU5EICE9IFNUQUxMX1NMT1RfRlJPTlRFTkQuCgpEYW1taXQsIEkgaGFkbid0IHJlYWxp c2VkIHRoYXQgYXQgYWxsLiBUaGFua3MgZm9yIHB1dHRpbmcgbWUgcmlnaHQuCgo+IAo+IFNUQUxM eywgX0JBQ0tFTkQsIF9GUk9OVEVORH0gY291bnQgdGhlIG51bWJlciBvZiBDUFUgY3ljbGVzIHdo ZXJlIG5vCj4gaW5zdHJ1Y3Rpb25zCj4gYXJlIGJlaW5nIGV4ZWN1dGVkIG9uIHRoZSBQRSAocGFn ZSBENy0yODcyKSwgU1RBTExfU0xPVHssIF9CQUNLRU5ELCAKPiBfRlJPTlRFTkR9Cj4gY291bnQg dGhlIG51bWJlciBvZiBzbG90cyB3aGVyZSBubyBpbnN0cnVjdGlvbnMgYXJlIGJlaW5nIGV4ZWN1 dGVkCj4gKHBhZ2UgRDctMjg3MykuCj4gCj4gU1RBTExfe0JBQ0tFTkQsIEZST05URU5EfSBhcmUg cmVxdWlyZWQgYnkgQVJNdjguMS1QTVUgKHBhZ2VzIEEyLTc2LCAKPiBENy0yOTEzKTsKPiBTVEFM TCBpcyByZXF1aXJlZCBieSBBUk12OC40LVBNVSAocGFnZSBENy0yOTE0KS4KPiAKPiBTVEFMTF9T TE9UeywgX0JBQ0tFTkQsIF9GUk9OVEVORH0gYXJlIG9wdGlvbmFsIGluIEFSTXY4LjQtUE1VIChw YWdlcyAKPiBENy0yOTEzLAo+IEQ3LTI5MTQpLCBidXQgaWYgb25lIG9mIHRoZW0gaXMgaW1wbGVt ZW50ZWQsIGFsbCBvZiB0aGVtIG11c3QgYmUKPiBpbXBsZW1lbnRlZCAocGFnZSBENy0yOTE0KS4K PiAKPiBUaGUgcHJvYmxlbSBJIHNlZSB3aXRoIHRoaXMgcGF0Y2ggaXMgdGhhdCBpdCBkb2Vzbid0 IGNsZWFyIHRoZQo+IFNUQUxMX1NMT1Rfe0JBQ0tFTkQsIEZST05URU5EfSBldmVudCBiaXRzIGFs b25nIHdpdGggdGhlIFNUQUxMX1NMT1QgYml0IAo+IGZyb20KPiBQTUNFSUQxX0VMMC4KCk9LLCBz byBFcmljIHdhcyByaWdodCwgYW5kIEknbSBhbiBpbGxpdGVyYXRlIGlkaW90ISBJJ2xsIGZpeCB0 aGUgcGF0Y2ggCmFuZCByZXBvc3QKdGhlIHdob2xlIHRoaW5nLgoKVGhhbmtzLAoKICAgICAgICAg TS4KLS0gCkphenogaXMgbm90IGRlYWQuIEl0IGp1c3Qgc21lbGxzIGZ1bm55Li4uCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ED94C433E0 for ; Thu, 4 Feb 2021 14:32:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7B8164EE2 for ; Thu, 4 Feb 2021 14:32:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236748AbhBDObv (ORCPT ); Thu, 4 Feb 2021 09:31:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:34970 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236693AbhBDOWW (ORCPT ); Thu, 4 Feb 2021 09:22:22 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F6DA64DEB; Thu, 4 Feb 2021 14:21:39 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1l7fVp-00C1TC-Fb; Thu, 04 Feb 2021 14:21:37 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 04 Feb 2021 14:21:37 +0000 From: Marc Zyngier To: Alexandru Elisei Cc: Auger Eric , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, James Morse , Julien Thierry , Suzuki K Poulose , kernel-team@android.com Subject: Re: [PATCH v2 6/7] KVM: arm64: Upgrade PMU support to ARMv8.4 In-Reply-To: <7134513d-bccf-923f-961a-08527cf77f8e@arm.com> References: <20210125122638.2947058-1-maz@kernel.org> <20210125122638.2947058-7-maz@kernel.org> <56041147-0bd8-dbb2-d1ca-550f3db7f05d@redhat.com> <7808bec4-2ac5-a36d-2960-b4b90574e0d2@redhat.com> <7134513d-bccf-923f-961a-08527cf77f8e@arm.com> User-Agent: Roundcube Webmail/1.4.10 Message-ID: <30d455e9eacf8b4b9b43ff30b3a48309@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, eric.auger@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2021-02-04 12:32, Alexandru Elisei wrote: > Hi, > > On 2/3/21 1:28 PM, Marc Zyngier wrote: >> On 2021-02-03 12:39, Auger Eric wrote: >>> Hi, >>> >>> On 2/3/21 12:20 PM, Marc Zyngier wrote: >>>> On 2021-02-03 11:07, Auger Eric wrote: >>>>> Hi Marc, >>>>> On 2/3/21 11:36 AM, Marc Zyngier wrote: >>>>>> Hi Eric, >>>>>> >>>>>> On 2021-01-27 17:53, Auger Eric wrote: >>>>>>> Hi Marc, >>>>>>> >>>>>>> On 1/25/21 1:26 PM, Marc Zyngier wrote: >>>>>>>> Upgrading the PMU code from ARMv8.1 to ARMv8.4 turns out to be >>>>>>>> pretty easy. All that is required is support for PMMIR_EL1, >>>>>>>> which >>>>>>>> is read-only, and for which returning 0 is a valid option as >>>>>>>> long >>>>>>>> as we don't advertise STALL_SLOT as an implemented event. >>>>>>>> >>>>>>>> Let's just do that and adjust what we return to the guest. >>>>>>>> >>>>>>>> Signed-off-by: Marc Zyngier >>>>>>>> --- >>>>>>>>  arch/arm64/include/asm/sysreg.h |  3 +++ >>>>>>>>  arch/arm64/kvm/pmu-emul.c       |  6 ++++++ >>>>>>>>  arch/arm64/kvm/sys_regs.c       | 11 +++++++---- >>>>>>>>  3 files changed, 16 insertions(+), 4 deletions(-) >>>>>>>> >>>>>>>> diff --git a/arch/arm64/include/asm/sysreg.h >>>>>>>> b/arch/arm64/include/asm/sysreg.h >>>>>>>> index 8b5e7e5c3cc8..2fb3f386588c 100644 >>>>>>>> --- a/arch/arm64/include/asm/sysreg.h >>>>>>>> +++ b/arch/arm64/include/asm/sysreg.h >>>>>>>> @@ -846,7 +846,10 @@ >>>>>>>> >>>>>>>>  #define ID_DFR0_PERFMON_SHIFT        24 >>>>>>>> >>>>>>>> +#define ID_DFR0_PERFMON_8_0        0x3 >>>>>>>>  #define ID_DFR0_PERFMON_8_1        0x4 >>>>>>>> +#define ID_DFR0_PERFMON_8_4        0x5 >>>>>>>> +#define ID_DFR0_PERFMON_8_5        0x6 >>>>>>>> >>>>>>>>  #define ID_ISAR4_SWP_FRAC_SHIFT        28 >>>>>>>>  #define ID_ISAR4_PSR_M_SHIFT        24 >>>>>>>> diff --git a/arch/arm64/kvm/pmu-emul.c >>>>>>>> b/arch/arm64/kvm/pmu-emul.c >>>>>>>> index 398f6df1bbe4..72cd704a8368 100644 >>>>>>>> --- a/arch/arm64/kvm/pmu-emul.c >>>>>>>> +++ b/arch/arm64/kvm/pmu-emul.c >>>>>>>> @@ -795,6 +795,12 @@ u64 kvm_pmu_get_pmceid(struct kvm_vcpu >>>>>>>> *vcpu, >>>>>>>> bool pmceid1) >>>>>>>>          base = 0; >>>>>>>>      } else { >>>>>>>>          val = read_sysreg(pmceid1_el0); >>>>>>>> +        /* >>>>>>>> +         * Don't advertise STALL_SLOT, as PMMIR_EL0 is handled >>>>>>>> +         * as RAZ >>>>>>>> +         */ >>>>>>>> +        if (vcpu->kvm->arch.pmuver >= ID_AA64DFR0_PMUVER_8_4) >>>>>>>> +            val &= ~BIT_ULL(ARMV8_PMUV3_PERFCTR_STALL_SLOT - >>>>>>>> 32); >>>>>>> what about the STALL_SLOT_BACKEND and FRONTEND events then? >>>>>> >>>>>> Aren't these a mandatory ARMv8.1 feature? I don't see a reason to >>>>>> drop them. >>>>> >>>>> I understand the 3 are linked together. >>>>> >>>>> In D7.11 it is said >>>>> " >>>>> When any of the following common events are implemented, all three >>>>> of >>>>> them are implemented: >>>>> 0x003D , STALL_SLOT_BACKEND, No operation sent for execution on a >>>>> Slot >>>>> due to the backend, >>>>> 0x003E , STALL_SLOT_FRONTEND, No operation sent for execution on a >>>>> Slot >>>>> due to the frontend. >>>>> 0x003F , STALL_SLOT, No operation sent for execution on a Slot. >>>>> " >>>> >>>> They are linked in the sense that they report related events, but >>>> they >>>> don't have to be implemented in the same level of the architecure, >>>> if only >>>> because BACKEND/FRONTEND were introducedway before ARMv8.4. >>>> >>>> What the architecture says is: >>>> >>>> - For FEAT_PMUv3p1 (ARMv8.1): >>>>   "The STALL_FRONTEND and STALL_BACKEND events are required to be >>>>    implemented." (A2.4.1, DDI0487G.a) >>> OK >>>> >>>> - For FEAT_PMUv3p4 (ARMv8.4): >>>>   "If FEAT_PMUv3p4 is implemented: >>>>    - If STALL_SLOT is not implemented, it is IMPLEMENTATION DEFINED >>>> whether the PMMIR System registers are implemented. >>>>    - If STALL_SLOT is implemented, then the PMMIR System registers >>>> are >>>> implemented." (D7-2873, DDI0487G.a) >>>> >>>> So while BACKEND/FRONTEND are required in an ARMv8.4 implementation >>>> by virtue of being mandatory in ARMv8.1, STALL_SLOT isn't at any >>>> point. >>> But then how do you understand "When any of the following common >>> events >>> are implemented, all three of them are implemented"? >> >> I think that's wholly inconsistent, because it would mean that >> STALL_SLOT >> isn't optional on ARMv8.4, and would make PMMIR mandatory. > > I think there's some confusion regarding the event names. From my > reading of the > architecture, STALL != STALL_SLOT, STALL_BACKEND != STALL_SLOT_BACKEND, > STALL_FRONTEND != STALL_SLOT_FRONTEND. Dammit, I hadn't realised that at all. Thanks for putting me right. > > STALL{, _BACKEND, _FRONTEND} count the number of CPU cycles where no > instructions > are being executed on the PE (page D7-2872), STALL_SLOT{, _BACKEND, > _FRONTEND} > count the number of slots where no instructions are being executed > (page D7-2873). > > STALL_{BACKEND, FRONTEND} are required by ARMv8.1-PMU (pages A2-76, > D7-2913); > STALL is required by ARMv8.4-PMU (page D7-2914). > > STALL_SLOT{, _BACKEND, _FRONTEND} are optional in ARMv8.4-PMU (pages > D7-2913, > D7-2914), but if one of them is implemented, all of them must be > implemented (page D7-2914). > > The problem I see with this patch is that it doesn't clear the > STALL_SLOT_{BACKEND, FRONTEND} event bits along with the STALL_SLOT bit > from > PMCEID1_EL0. OK, so Eric was right, and I'm an illiterate idiot! I'll fix the patch and repost the whole thing. Thanks, M. -- Jazz is not dead. It just smells funny...