From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from z5.mailgun.us ([104.130.96.5]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdUYJ-00043k-Ey for ath10k@lists.infradead.org; Fri, 13 Nov 2020 08:35:28 +0000 MIME-Version: 1.0 Date: Fri, 13 Nov 2020 16:35:07 +0800 From: Wen Gong Subject: Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable In-Reply-To: <798cea679ae1df5a2ab9b59dd81c8e2b3ca2d6e3.camel@sipsolutions.net> References: <20170308132022.4216-1-johannes@sipsolutions.net> <07179008e9369bc81e152009ca85191d@codeaurora.org> <5decc452-7b2a-db1d-c5eb-04ab6bb61553@broadcom.com> <4b8f37fde23262547edb6ed4635cf89b@codeaurora.org> <83dd20def685d303106f285400367b6e@codeaurora.org> <798cea679ae1df5a2ab9b59dd81c8e2b3ca2d6e3.camel@sipsolutions.net> Message-ID: <30e2e578983e4df447e0c26c5bba0aba@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Johannes Berg Cc: Arend Van Spriel , kirtika@google.com, linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org On 2020-11-13 16:16, Johannes Berg wrote: > On Fri, 2020-11-13 at 16:14 +0800, Wen Gong wrote: >> On 2020-11-13 15:38, Johannes Berg wrote: >> > On Fri, 2020-11-13 at 10:08 +0800, Wen Gong wrote: >> > > > Which was the intent of this change, wasn't it? >> > >> > Indeed. Permitting this leads to warnings later. >> > >> > > We need to set the tx rate to fixed at a single rate, e.g., >> > > 54M/48M/36M... for a test case. >> > > I do not want a clear error message, I want to the 54M rate pass/set >> > > success to lower wlan driver. >> > > Then lower wlan driver can handle it. >> > >> > No, that will not happen. You should configure your test AP to actually >> > support 54M. >> Yes, the AP support 54M, but it is not basic rate, so >> ieee80211_set_bitrate_mask will reject 54M >> because fail for check (mask->control[band].legacy & basic_rates). > > Ah. So this is what I said in the original commit message even: > >> Technically, selecting basic rates as the criterion is a bit too >> restrictive, but calculating the usable rates over all stations >> (e.g. in AP mode) is harder, and all stations must support the >> basic rates. Similarly, in client mode, the basic rates will be >> used anyway for control frames. > > I guess if we really want to redefine the user rate mask to not apply > to > control frames, then we can relax this? > Yes, for AP mode, it is hard to calculate the usable rates over all stations. But for STATION mode, it can set 54M because AP support it, so it should not reject it. If add a check for nl80211_iftype of ieee80211_vif in ieee80211_set_bitrate_mask, it can solve this like this: if (sdata->vif.type != NL80211_IFTYPE_STATION && !(mask->control[band].legacy & basic_rates)) > johannes _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from m42-4.mailgun.net ([69.72.42.4]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdUYJ-00043j-Im for ath11k@lists.infradead.org; Fri, 13 Nov 2020 08:35:28 +0000 MIME-Version: 1.0 Date: Fri, 13 Nov 2020 16:35:07 +0800 From: Wen Gong Subject: Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable In-Reply-To: <798cea679ae1df5a2ab9b59dd81c8e2b3ca2d6e3.camel@sipsolutions.net> References: <20170308132022.4216-1-johannes@sipsolutions.net> <07179008e9369bc81e152009ca85191d@codeaurora.org> <5decc452-7b2a-db1d-c5eb-04ab6bb61553@broadcom.com> <4b8f37fde23262547edb6ed4635cf89b@codeaurora.org> <83dd20def685d303106f285400367b6e@codeaurora.org> <798cea679ae1df5a2ab9b59dd81c8e2b3ca2d6e3.camel@sipsolutions.net> Message-ID: <30e2e578983e4df447e0c26c5bba0aba@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: Johannes Berg Cc: Arend Van Spriel , kirtika@google.com, linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org On 2020-11-13 16:16, Johannes Berg wrote: > On Fri, 2020-11-13 at 16:14 +0800, Wen Gong wrote: >> On 2020-11-13 15:38, Johannes Berg wrote: >> > On Fri, 2020-11-13 at 10:08 +0800, Wen Gong wrote: >> > > > Which was the intent of this change, wasn't it? >> > >> > Indeed. Permitting this leads to warnings later. >> > >> > > We need to set the tx rate to fixed at a single rate, e.g., >> > > 54M/48M/36M... for a test case. >> > > I do not want a clear error message, I want to the 54M rate pass/set >> > > success to lower wlan driver. >> > > Then lower wlan driver can handle it. >> > >> > No, that will not happen. You should configure your test AP to actually >> > support 54M. >> Yes, the AP support 54M, but it is not basic rate, so >> ieee80211_set_bitrate_mask will reject 54M >> because fail for check (mask->control[band].legacy & basic_rates). > > Ah. So this is what I said in the original commit message even: > >> Technically, selecting basic rates as the criterion is a bit too >> restrictive, but calculating the usable rates over all stations >> (e.g. in AP mode) is harder, and all stations must support the >> basic rates. Similarly, in client mode, the basic rates will be >> used anyway for control frames. > > I guess if we really want to redefine the user rate mask to not apply > to > control frames, then we can relax this? > Yes, for AP mode, it is hard to calculate the usable rates over all stations. But for STATION mode, it can set 54M because AP support it, so it should not reject it. If add a check for nl80211_iftype of ieee80211_vif in ieee80211_set_bitrate_mask, it can solve this like this: if (sdata->vif.type != NL80211_IFTYPE_STATION && !(mask->control[band].legacy & basic_rates)) > johannes -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A978C388F7 for ; Fri, 13 Nov 2020 08:35:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EEA7620936 for ; Fri, 13 Nov 2020 08:35:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="BPW1Xht0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726227AbgKMIfT (ORCPT ); Fri, 13 Nov 2020 03:35:19 -0500 Received: from z5.mailgun.us ([104.130.96.5]:35894 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726207AbgKMIfS (ORCPT ); Fri, 13 Nov 2020 03:35:18 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1605256518; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=TQ/FyemNE4zNsYTi0wu0urrERDS18xGXwFxSVBBB0fQ=; b=BPW1Xht0BlXnzGJXV8xrXkGjuraLZU7X8FohHEfour0PO+a05soZMtGt83eH6mwQHqvVrlPh hvsuKUFPGMbyBMXNLi/HGCqcWlhNoEz0wj6PMiUGCjcdaSSjrfa9sJRHb/pQ2Hews7KUqDrT 9sAA3tn0liSg0C7ABkobY9FR0Wk= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n10.prod.us-east-1.postgun.com with SMTP id 5fae453c309342b914c294e2 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 13 Nov 2020 08:35:08 GMT Sender: wgong=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 09ED0C433C9; Fri, 13 Nov 2020 08:35:08 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: wgong) by smtp.codeaurora.org (Postfix) with ESMTPSA id 72FFDC433C8; Fri, 13 Nov 2020 08:35:07 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 13 Nov 2020 16:35:07 +0800 From: Wen Gong To: Johannes Berg Cc: Arend Van Spriel , linux-wireless@vger.kernel.org, kirtika@google.com, linux-wireless-owner@vger.kernel.org, ath11k@lists.infradead.org, ath10k@lists.infradead.org Subject: Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable In-Reply-To: <798cea679ae1df5a2ab9b59dd81c8e2b3ca2d6e3.camel@sipsolutions.net> References: <20170308132022.4216-1-johannes@sipsolutions.net> <07179008e9369bc81e152009ca85191d@codeaurora.org> <5decc452-7b2a-db1d-c5eb-04ab6bb61553@broadcom.com> <4b8f37fde23262547edb6ed4635cf89b@codeaurora.org> <83dd20def685d303106f285400367b6e@codeaurora.org> <798cea679ae1df5a2ab9b59dd81c8e2b3ca2d6e3.camel@sipsolutions.net> Message-ID: <30e2e578983e4df447e0c26c5bba0aba@codeaurora.org> X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-11-13 16:16, Johannes Berg wrote: > On Fri, 2020-11-13 at 16:14 +0800, Wen Gong wrote: >> On 2020-11-13 15:38, Johannes Berg wrote: >> > On Fri, 2020-11-13 at 10:08 +0800, Wen Gong wrote: >> > > > Which was the intent of this change, wasn't it? >> > >> > Indeed. Permitting this leads to warnings later. >> > >> > > We need to set the tx rate to fixed at a single rate, e.g., >> > > 54M/48M/36M... for a test case. >> > > I do not want a clear error message, I want to the 54M rate pass/set >> > > success to lower wlan driver. >> > > Then lower wlan driver can handle it. >> > >> > No, that will not happen. You should configure your test AP to actually >> > support 54M. >> Yes, the AP support 54M, but it is not basic rate, so >> ieee80211_set_bitrate_mask will reject 54M >> because fail for check (mask->control[band].legacy & basic_rates). > > Ah. So this is what I said in the original commit message even: > >> Technically, selecting basic rates as the criterion is a bit too >> restrictive, but calculating the usable rates over all stations >> (e.g. in AP mode) is harder, and all stations must support the >> basic rates. Similarly, in client mode, the basic rates will be >> used anyway for control frames. > > I guess if we really want to redefine the user rate mask to not apply > to > control frames, then we can relax this? > Yes, for AP mode, it is hard to calculate the usable rates over all stations. But for STATION mode, it can set 54M because AP support it, so it should not reject it. If add a check for nl80211_iftype of ieee80211_vif in ieee80211_set_bitrate_mask, it can solve this like this: if (sdata->vif.type != NL80211_IFTYPE_STATION && !(mask->control[band].legacy & basic_rates)) > johannes