From: Oleksii Kurochko <oleksii.kurochko@gmail.com>
To: Hirokazu Takahashi <taka@valinux.co.jp>, xen-devel@lists.xenproject.org
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>,
"Bertrand Marquis" <bertrand.marquis@arm.com>,
"Michal Orzel" <michal.orzel@amd.com>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Jan Beulich" <jbeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Timothy Pearson" <tpearson@raptorengineering.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Connor Davis" <connojdavis@gmail.com>,
"Dario Faggioli" <dfaggioli@suse.com>,
"Juergen Gross" <jgross@suse.com>,
"George Dunlap" <gwd@xenproject.org>
Subject: Re: [PATCH v4 2/3] xen/sched: Link CPU topology to scheduler
Date: Fri, 3 Jul 2026 13:44:16 +0200 [thread overview]
Message-ID: <30e859e2-ee54-4d02-ac2c-08f8f80547bf@gmail.com> (raw)
In-Reply-To: <20260703091544.183548-3-taka@valinux.co.jp>
On 7/3/26 11:15 AM, Hirokazu Takahashi wrote:
>
> /*
> diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c
> index 95946634d1..ada430f262 100644
> --- a/xen/common/sched/credit2.c
> +++ b/xen/common/sched/credit2.c
> @@ -9,6 +9,7 @@
> * Based on an earlier verson by Emmanuel Ackaouy.
> */
>
> +#include <xen/cpu-topology.h>
> #include <xen/errno.h>
> #include <xen/init.h>
> #include <xen/lib.h>
> @@ -37,6 +38,8 @@ static unsigned int cpu_nr_siblings(unsigned int cpu)
> {
> #ifdef CONFIG_X86
> return cpu_data[cpu].x86_num_siblings;
> +#elif defined(CONFIG_CPU_TOPOLOGY)
> + return cpu_topology ? cpu_topology[cpu].num_siblings : 1;
Shouldn't here be CONFIG_GENERIC_CPU_TOPOLOGY?
~ Oleksii
next prev parent reply other threads:[~2026-07-03 11:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 9:15 [PATCH v4 0/3] xen/arm: Device Tree based CPU topology support Hirokazu Takahashi
2026-07-03 9:15 ` [PATCH v4 1/3] xen/device-tree: Parse 'cpu-map' node for CPU topology exploration Hirokazu Takahashi
2026-07-03 9:15 ` [PATCH v4 2/3] xen/sched: Link CPU topology to scheduler Hirokazu Takahashi
2026-07-03 11:44 ` Oleksii Kurochko [this message]
2026-07-07 6:46 ` Hirokazu Takahashi
2026-07-03 9:15 ` [PATCH v4 3/3] xen/sched: Make cpu_nr_siblings() architecture-specific Hirokazu Takahashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30e859e2-ee54-4d02-ac2c-08f8f80547bf@gmail.com \
--to=oleksii.kurochko@gmail.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=alistair.francis@wdc.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=bertrand.marquis@arm.com \
--cc=connojdavis@gmail.com \
--cc=dfaggioli@suse.com \
--cc=gwd@xenproject.org \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=taka@valinux.co.jp \
--cc=tpearson@raptorengineering.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.