From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:54765 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750752AbeBUXxl (ORCPT ); Wed, 21 Feb 2018 18:53:41 -0500 From: Laurent Pinchart To: Rob Herring Cc: Laurent Pinchart , dri-devel , "open list:MEDIA DRIVERS FOR RENESAS - FCP" , Frank Rowand , devicetree@vger.kernel.org Subject: Re: [PATCH v4 08/16] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes Date: Thu, 22 Feb 2018 01:54:23 +0200 Message-ID: <31008700.E3yMoWPLls@avalon> In-Reply-To: References: <20180220231046.32638-1-laurent.pinchart+renesas@ideasonboard.com> <20180220231046.32638-9-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Rob, On Thursday, 22 February 2018 01:28:48 EET Rob Herring wrote: > On Tue, Feb 20, 2018 at 5:10 PM, Laurent Pinchart wrote: > > The internal LVDS encoders now have their own DT bindings. Before > > switching the driver infrastructure to those new bindings, implement > > backward-compatibility through live DT patching. > > > > Patching is disabled and will be enabled along with support for the new > > DT bindings in the DU driver. > > > > Signed-off-by: Laurent Pinchart > > > > --- > > [...] > > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dts > > b/drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dts new file mode > > 100644 > > index 000000000000..6ebb355b652a > > --- /dev/null > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dts > > @@ -0,0 +1,81 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * rcar_du_of_lvds_r8a7790.dts - Legacy LVDS DT bindings conversion for > > R8A7790 > > + * > > + * Copyright (C) 2018 Laurent Pinchart > > > > + * > > + * Based on work from Jyri Sarha > > + * Copyright (C) 2015 Texas Instruments > > + */ > > + > > +#include > > Doesn't seem to be used in any of these. It's a leftover from a previous test. I'll remove it in all the .dts files. > Otherwise, > > Reviewed-by: Rob Herring > > > + > > +/dts-v1/; > > +/plugin/; > > +/ { > > + fragment@0 { > > + target-path = "/"; > > + __overlay__ { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + lvds@feb90000 { > > + compatible = "renesas,r8a7790-lvds"; > > + reg = <0 0xfeb90000 0 0x1c>; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + lvds0_input: endpoint { > > + }; > > + }; > > + port@1 { > > + reg = <1>; > > + lvds0_out: endpoint { > > + }; > > + }; > > + }; > > + }; > > + > > + lvds@feb94000 { > > + compatible = "renesas,r8a7790-lvds"; > > + reg = <0 0xfeb94000 0 0x1c>; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + lvds1_input: endpoint { > > + }; > > + }; > > + port@1 { > > + reg = <1>; > > + lvds1_out: endpoint { > > + }; > > + }; > > + }; > > + }; > > + }; > > + }; > > + > > + fragment@1 { > > + target-path = "/display@feb00000/ports"; > > + __overlay__ { > > + port@1 { > > + endpoint { > > + remote-endpoint = <&lvds0_input>; > > + }; > > + }; > > + port@2 { > > + endpoint { > > + remote-endpoint = <&lvds1_input>; > > + }; > > + }; > > + }; > > + }; > > +}; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 08/16] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes Date: Thu, 22 Feb 2018 01:54:23 +0200 Message-ID: <31008700.E3yMoWPLls@avalon> References: <20180220231046.32638-1-laurent.pinchart+renesas@ideasonboard.com> <20180220231046.32638-9-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring Cc: "open list:MEDIA DRIVERS FOR RENESAS - FCP" , devicetree@vger.kernel.org, Laurent Pinchart , Frank Rowand , dri-devel List-Id: devicetree@vger.kernel.org SGkgUm9iLAoKT24gVGh1cnNkYXksIDIyIEZlYnJ1YXJ5IDIwMTggMDE6Mjg6NDggRUVUIFJvYiBI ZXJyaW5nIHdyb3RlOgo+IE9uIFR1ZSwgRmViIDIwLCAyMDE4IGF0IDU6MTAgUE0sIExhdXJlbnQg UGluY2hhcnQgd3JvdGU6Cj4gPiBUaGUgaW50ZXJuYWwgTFZEUyBlbmNvZGVycyBub3cgaGF2ZSB0 aGVpciBvd24gRFQgYmluZGluZ3MuIEJlZm9yZQo+ID4gc3dpdGNoaW5nIHRoZSBkcml2ZXIgaW5m cmFzdHJ1Y3R1cmUgdG8gdGhvc2UgbmV3IGJpbmRpbmdzLCBpbXBsZW1lbnQKPiA+IGJhY2t3YXJk LWNvbXBhdGliaWxpdHkgdGhyb3VnaCBsaXZlIERUIHBhdGNoaW5nLgo+ID4gCj4gPiBQYXRjaGlu ZyBpcyBkaXNhYmxlZCBhbmQgd2lsbCBiZSBlbmFibGVkIGFsb25nIHdpdGggc3VwcG9ydCBmb3Ig dGhlIG5ldwo+ID4gRFQgYmluZGluZ3MgaW4gdGhlIERVIGRyaXZlci4KPiA+IAo+ID4gU2lnbmVk LW9mZi1ieTogTGF1cmVudCBQaW5jaGFydAo+ID4gPGxhdXJlbnQucGluY2hhcnQrcmVuZXNhc0Bp ZGVhc29uYm9hcmQuY29tPgo+ID4gLS0tCj4gCj4gWy4uLl0KPiAKPiA+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X29mX2x2ZHNfcjhhNzc5MC5kdHMKPiA+IGIv ZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9vZl9sdmRzX3I4YTc3OTAuZHRzIG5ldyBm aWxlIG1vZGUKPiA+IDEwMDY0NAo+ID4gaW5kZXggMDAwMDAwMDAwMDAwLi42ZWJiMzU1YjY1MmEK PiA+IC0tLSAvZGV2L251bGwKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJf ZHVfb2ZfbHZkc19yOGE3NzkwLmR0cwo+ID4gQEAgLTAsMCArMSw4MSBAQAo+ID4gKy8vIFNQRFgt TGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4wCj4gPiArLyoKPiA+ICsgKiByY2FyX2R1X29mX2x2 ZHNfcjhhNzc5MC5kdHMgLSBMZWdhY3kgTFZEUyBEVCBiaW5kaW5ncyBjb252ZXJzaW9uIGZvcgo+ ID4gUjhBNzc5MAo+ID4gKyAqCj4gPiArICogQ29weXJpZ2h0IChDKSAyMDE4IExhdXJlbnQgUGlu Y2hhcnQKPiA+IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4gPiArICoKPiA+ ICsgKiBCYXNlZCBvbiB3b3JrIGZyb20gSnlyaSBTYXJoYSA8anNhcmhhQHRpLmNvbT4KPiA+ICsg KiBDb3B5cmlnaHQgKEMpIDIwMTUgVGV4YXMgSW5zdHJ1bWVudHMKPiA+ICsgKi8KPiA+ICsKPiA+ ICsjaW5jbHVkZSA8ZHQtYmluZGluZ3MvY2xvY2svcmVuZXNhcy1jcGctbXNzci5oPgo+IAo+IERv ZXNuJ3Qgc2VlbSB0byBiZSB1c2VkIGluIGFueSBvZiB0aGVzZS4KCkl0J3MgYSBsZWZ0b3ZlciBm cm9tIGEgcHJldmlvdXMgdGVzdC4gSSdsbCByZW1vdmUgaXQgaW4gYWxsIHRoZSAuZHRzIGZpbGVz LgoKPiBPdGhlcndpc2UsCj4gCj4gUmV2aWV3ZWQtYnk6IFJvYiBIZXJyaW5nIDxyb2JoQGtlcm5l bC5vcmc+Cj4gCj4gPiArCj4gPiArL2R0cy12MS87Cj4gPiArL3BsdWdpbi87Cj4gPiArLyB7Cj4g PiArICAgICAgIGZyYWdtZW50QDAgewo+ID4gKyAgICAgICAgICAgICAgIHRhcmdldC1wYXRoID0g Ii8iOwo+ID4gKyAgICAgICAgICAgICAgIF9fb3ZlcmxheV9fIHsKPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgICNhZGRyZXNzLWNlbGxzID0gPDI+Owo+ID4gKyAgICAgICAgICAgICAgICAgICAg ICAgI3NpemUtY2VsbHMgPSA8Mj47Cj4gPiArCj4gPiArICAgICAgICAgICAgICAgICAgICAgICBs dmRzQGZlYjkwMDAwIHsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29tcGF0 aWJsZSA9ICJyZW5lc2FzLHI4YTc3OTAtbHZkcyI7Cj4gPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHJlZyA9IDwwIDB4ZmViOTAwMDAgMCAweDFjPjsKPiA+ICsKPiA+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgcG9ydHMgewo+ID4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICNhZGRyZXNzLWNlbGxzID0gPDE+Owo+ID4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICNzaXplLWNlbGxzID0gPDA+Owo+ID4gKwo+ID4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBvcnRAMCB7Cj4gPiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWcgPSA8MD47Cj4g PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsdmRzMF9p bnB1dDogZW5kcG9pbnQgewo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgfTsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICB9Owo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBvcnRAMSB7 Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWcg PSA8MT47Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBsdmRzMF9vdXQ6IGVuZHBvaW50IHsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIH07Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgfTsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfTsKPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgIH07Cj4gPiArCj4gPiArICAgICAgICAgICAgICAgICAgICAg ICBsdmRzQGZlYjk0MDAwIHsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29t cGF0aWJsZSA9ICJyZW5lc2FzLHI4YTc3OTAtbHZkcyI7Cj4gPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHJlZyA9IDwwIDB4ZmViOTQwMDAgMCAweDFjPjsKPiA+ICsKPiA+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcG9ydHMgewo+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICNhZGRyZXNzLWNlbGxzID0gPDE+Owo+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICNzaXplLWNlbGxzID0gPDA+Owo+ID4gKwo+ ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBvcnRAMCB7Cj4gPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWcgPSA8MD47 Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsdmRz MV9pbnB1dDogZW5kcG9pbnQgewo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfTsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB9Owo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBvcnRA MSB7Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBy ZWcgPSA8MT47Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBsdmRzMV9vdXQ6IGVuZHBvaW50IHsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIH07Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgfTsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfTsKPiA+ ICsgICAgICAgICAgICAgICAgICAgICAgIH07Cj4gPiArICAgICAgICAgICAgICAgfTsKPiA+ICsg ICAgICAgfTsKPiA+ICsKPiA+ICsgICAgICAgZnJhZ21lbnRAMSB7Cj4gPiArICAgICAgICAgICAg ICAgdGFyZ2V0LXBhdGggPSAiL2Rpc3BsYXlAZmViMDAwMDAvcG9ydHMiOwo+ID4gKyAgICAgICAg ICAgICAgIF9fb3ZlcmxheV9fIHsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIHBvcnRAMSB7 Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGVuZHBvaW50IHsKPiA+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZW1vdGUtZW5kcG9pbnQgPSA8Jmx2 ZHMwX2lucHV0PjsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfTsKPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgIH07Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICBwb3J0 QDIgewo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlbmRwb2ludCB7Cj4gPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVtb3RlLWVuZHBvaW50ID0g PCZsdmRzMV9pbnB1dD47Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH07Cj4g PiArICAgICAgICAgICAgICAgICAgICAgICB9Owo+ID4gKyAgICAgICAgICAgICAgIH07Cj4gPiAr ICAgICAgIH07Cj4gPiArfTsKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==