All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH maint v2] batman-adv: fix TT sync flag inconsistencies
Date: Sat, 29 Jul 2017 10:25:37 +0200	[thread overview]
Message-ID: <3105199.cDmPPX3bfG@sven-edge> (raw)
In-Reply-To: <20170706050225.24455-1-linus.luessing@c0d3.blue>

[-- Attachment #1: Type: text/plain, Size: 1183 bytes --]

On Donnerstag, 6. Juli 2017 07:02:25 CEST Linus Lüssing wrote:
> This patch fixes an issue in the translation table code potentially
> leading to a TT Request + Response storm. The issue may occur for nodes
> involving BLA and an inconsistent configuration of the batman-adv AP
> isolation feature. However, since the new multicast optimizations, a
> single, malformed packet may lead to a mesh-wide, persistent
> Denial-of-Service, too.
[...]
> This patch fixes this issue by storing the flags used in the CRC
> calculation on a a per TT orig entry basis to be able to respond with
> the correct, original flags in an intermediate TT Response for one
> thing. And to be able to correctly unset sync flags once all nodes
> announcing a sync flag vanish for another.
> 
> Fixes: fa614fd04692 ("batman-adv: fix tt_global_entries flags update")
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>

Simon wanted to have a look at this patch before applying it. But I've already 
queued it up for openwrt-routing [1]. This should hopefully help people which 
want to test it.

Kind regards,
	Sven

[1] https://github.com/openwrt-routing/packages/pull/316


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2017-07-29  8:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-06  5:02 [B.A.T.M.A.N.] [PATCH maint v2] batman-adv: fix TT sync flag inconsistencies Linus Lüssing
2017-07-24  5:48 ` Antonio Quartulli
2017-07-29  8:25 ` Sven Eckelmann [this message]
2017-07-29  8:51   ` Linus Lüssing
2017-07-31  8:51 ` Simon Wunderlich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3105199.cDmPPX3bfG@sven-edge \
    --to=sven@narfation.org \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.