From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADE75C433DB for ; Thu, 14 Jan 2021 17:57:57 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A9A923B4B for ; Thu, 14 Jan 2021 17:57:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A9A923B4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-555-SNLK_v7SMZ2it4oEl-Gc4g-1; Thu, 14 Jan 2021 12:57:52 -0500 X-MC-Unique: SNLK_v7SMZ2it4oEl-Gc4g-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 39340100C600; Thu, 14 Jan 2021 17:57:47 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 729A55C1BD; Thu, 14 Jan 2021 17:57:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5885C4A7C6; Thu, 14 Jan 2021 17:57:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 10EHvg0i017557 for ; Thu, 14 Jan 2021 12:57:42 -0500 Received: by smtp.corp.redhat.com (Postfix) id 70D622026D14; Thu, 14 Jan 2021 17:57:42 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6D0472026D12 for ; Thu, 14 Jan 2021 17:57:35 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 59F2A800296 for ; Thu, 14 Jan 2021 17:57:35 +0000 (UTC) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by relay.mimecast.com with ESMTP id us-mta-284-_s-VSsOaNM2xZj1yqVZ6KQ-1; Thu, 14 Jan 2021 12:57:31 -0500 X-MC-Unique: _s-VSsOaNM2xZj1yqVZ6KQ-1 Received: from [192.168.86.31] (c-71-197-163-6.hsd1.wa.comcast.net [71.197.163.6]) by linux.microsoft.com (Postfix) with ESMTPSA id D7E4720B6C40; Thu, 14 Jan 2021 09:57:28 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D7E4720B6C40 To: Mimi Zohar , stephen.smalley.work@gmail.com, casey@schaufler-ca.com, agk@redhat.com, snitzer@redhat.com, gmazyland@gmail.com, paul@paul-moore.com References: <20210108040708.8389-1-tusharsu@linux.microsoft.com> <20210108040708.8389-6-tusharsu@linux.microsoft.com> <73a82dff7be151298f51c0db6f3c4996ccf44a19.camel@linux.ibm.com> From: Tushar Sugandhi Message-ID: <3105b0b9-4e74-691c-56ab-6ca183cb2038@linux.microsoft.com> Date: Thu, 14 Jan 2021 09:57:27 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <73a82dff7be151298f51c0db6f3c4996ccf44a19.camel@linux.ibm.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: dm-devel@redhat.com Cc: sashal@kernel.org, dm-devel@redhat.com, selinux@vger.kernel.org, jmorris@namei.org, linux-kernel@vger.kernel.org, nramas@linux.microsoft.com, linux-security-module@vger.kernel.org, tyhicks@linux.microsoft.com, linux-integrity@vger.kernel.org Subject: Re: [dm-devel] [PATCH v10 5/8] IMA: limit critical data measurement based on a label X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" On 2021-01-13 6:09 p.m., Mimi Zohar wrote: > On Thu, 2021-01-07 at 20:07 -0800, Tushar Sugandhi wrote: >> Integrity critical data may belong to a single subsystem or it may >> arise from cross subsystem interaction. Currently there is no mechanism >> to group or limit the data based on certain label. Limiting and >> grouping critical data based on a label would make it flexible and >> configurable to measure. >> >> Define "label:=", a new IMA policy condition, for the IMA func >> CRITICAL_DATA to allow grouping and limiting measurement of integrity >> critical data. >> >> Limit the measurement to the labels that are specified in the IMA >> policy - CRITICAL_DATA+"label:=". If "label:=" is not provided with >> the func CRITICAL_DATA, measure all the input integrity critical data. >> >> Signed-off-by: Tushar Sugandhi >> Reviewed-by: Tyler Hicks > > This is looking a lot better. > > thanks, > > Mimi > Thanks a lot for the feedback Mimi. Appreciate it. :) ~Tushar -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2605DC43381 for ; Thu, 14 Jan 2021 17:58:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E002123B53 for ; Thu, 14 Jan 2021 17:58:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727719AbhANR6K (ORCPT ); Thu, 14 Jan 2021 12:58:10 -0500 Received: from linux.microsoft.com ([13.77.154.182]:45194 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726428AbhANR6K (ORCPT ); Thu, 14 Jan 2021 12:58:10 -0500 Received: from [192.168.86.31] (c-71-197-163-6.hsd1.wa.comcast.net [71.197.163.6]) by linux.microsoft.com (Postfix) with ESMTPSA id D7E4720B6C40; Thu, 14 Jan 2021 09:57:28 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D7E4720B6C40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1610647049; bh=A4xGRwtz6F/ItvEdkk7Mb8VZ62q+X4ffVSeGTPCYbj0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Ms+8Ksq1OiZWytgF1KBjTZpUlM/Mljo9UN9DsX4FbPYkGZEwDl5l+ublRojq3l+De onLI2IsuQjAtzreV8nfOQy2Nu+zA1sGousMbny+4FLoyhNB6TfSDRuDcSX3k/nSKp0 9dODlIIkdzCGk3Y9ixlK26nnvqfpz21QyroeBZDk= Subject: Re: [PATCH v10 5/8] IMA: limit critical data measurement based on a label To: Mimi Zohar , stephen.smalley.work@gmail.com, casey@schaufler-ca.com, agk@redhat.com, snitzer@redhat.com, gmazyland@gmail.com, paul@paul-moore.com Cc: tyhicks@linux.microsoft.com, sashal@kernel.org, jmorris@namei.org, nramas@linux.microsoft.com, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com References: <20210108040708.8389-1-tusharsu@linux.microsoft.com> <20210108040708.8389-6-tusharsu@linux.microsoft.com> <73a82dff7be151298f51c0db6f3c4996ccf44a19.camel@linux.ibm.com> From: Tushar Sugandhi Message-ID: <3105b0b9-4e74-691c-56ab-6ca183cb2038@linux.microsoft.com> Date: Thu, 14 Jan 2021 09:57:27 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <73a82dff7be151298f51c0db6f3c4996ccf44a19.camel@linux.ibm.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On 2021-01-13 6:09 p.m., Mimi Zohar wrote: > On Thu, 2021-01-07 at 20:07 -0800, Tushar Sugandhi wrote: >> Integrity critical data may belong to a single subsystem or it may >> arise from cross subsystem interaction. Currently there is no mechanism >> to group or limit the data based on certain label. Limiting and >> grouping critical data based on a label would make it flexible and >> configurable to measure. >> >> Define "label:=", a new IMA policy condition, for the IMA func >> CRITICAL_DATA to allow grouping and limiting measurement of integrity >> critical data. >> >> Limit the measurement to the labels that are specified in the IMA >> policy - CRITICAL_DATA+"label:=". If "label:=" is not provided with >> the func CRITICAL_DATA, measure all the input integrity critical data. >> >> Signed-off-by: Tushar Sugandhi >> Reviewed-by: Tyler Hicks > > This is looking a lot better. > > thanks, > > Mimi > Thanks a lot for the feedback Mimi. Appreciate it. :) ~Tushar