From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: kevin sztern <kevin.sztern@epita.fr>
Cc: mtk.manpages@gmail.com,
"linux-man@vger.kernel.org" <linux-man@vger.kernel.org>
Subject: Re: [PATCH] packet.7: fix tpacket_auxdata fields.
Date: Thu, 12 Dec 2019 09:56:05 +0100 [thread overview]
Message-ID: <310adfd2-a3eb-5656-ebf3-0effafcb7fdc@gmail.com> (raw)
In-Reply-To: <20191126232125.9433-1-kevin.sztern@epita.fr>
Hello Kevin,
On 11/27/19 12:22 AM, kevin sztern wrote:
> The definition of the tpacket_auxdata struct in the manpage is not the
> same as the definition found in /include/uapi/linux/if_packet.h.
>
> In particular, instead of a tp_padding field, there is a tp_vlan_tpid
> field. An example of a project using this field is libpcap[1].
>
> [1]: https://github.com/the-tcpdump-group/libpcap/blob/master/pcap-linux.c#L349
Thanks. Patch applied.
Cheers,
Michael
> ---
> man7/packet.7 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man7/packet.7 b/man7/packet.7
> index b624d47d1..ecbd63409 100644
> --- a/man7/packet.7
> +++ b/man7/packet.7
> @@ -257,7 +257,7 @@ struct tpacket_auxdata {
> __u16 tp_mac;
> __u16 tp_net;
> __u16 tp_vlan_tci;
> - __u16 tp_padding;
> + __u16 tp_vlan_tpid;
> };
> .EE
> .in
>
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
prev parent reply other threads:[~2019-12-12 8:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 23:22 [PATCH] packet.7: fix tpacket_auxdata fields kevin sztern
2019-12-12 8:56 ` Michael Kerrisk (man-pages) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=310adfd2-a3eb-5656-ebf3-0effafcb7fdc@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=kevin.sztern@epita.fr \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.