From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Stein Subject: Re: Adding new CAN driver Date: Wed, 02 Nov 2016 15:14:52 +0100 Message-ID: <3113364.8FuUfmAlHQ@ws-stein> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from webbox1416.server-home.net ([77.236.96.61]:33973 "EHLO webbox1416.server-home.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbcKBOPC (ORCPT ); Wed, 2 Nov 2016 10:15:02 -0400 In-Reply-To: Sender: linux-can-owner@vger.kernel.org List-ID: To: Ramesh Shanmugasundaram Cc: Marc Kleine-Budde , =?utf-8?B?S2/FgsWCxIV0YWos?= Remigiusz , Uwe Bonnes , "linux-can@vger.kernel.org" , Oliver Hartkopp On Wednesday 02 November 2016 13:38:22, Ramesh Shanmugasundaram wrote: > > > I didn't get a chance to work on adding support for termination to > > > "ip". Before investing any effort I would prefer to get confirmation > > > from Oliver of Marc that the direction is right. Anyway setting up > > > termination via sysfs works just fine. It is described in readme file > > > in repository. > > > > > > I'd like to see a netlink interface for this. Oliver what about adding it > > to CTRL_MODE? > > > Is it about the CAN bus termination? Why the driver need to be aware of it? > If it needed for some reason shouldn't it be a device tree property of that > device/bridge node? I would consider this as a feature, which has to be enabled or disabled on demand dynamically, depending on current physical connection, especially regarding USB devices. In thise cases there is also no device tree applicable. Best regards, Alexander