From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: Benjamin Poirier <bpoirier@nvidia.com>
Cc: netdev@vger.kernel.org, Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jiri Pirko <jiri@resnulli.us>, Shuah Khan <shuah@kernel.org>,
Jonathan Toppins <jtoppins@redhat.com>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net v3 0/4] Unsync addresses from ports when stopping aggregated devices
Date: Thu, 08 Sep 2022 16:25:43 -0700 [thread overview]
Message-ID: <31139.1662679543@famine> (raw)
In-Reply-To: <20220907075642.475236-1-bpoirier@nvidia.com>
Benjamin Poirier <bpoirier@nvidia.com> wrote:
>This series fixes similar problems in the bonding and team drivers.
>
>Because of missing dev_{uc,mc}_unsync() calls, addresses added to
>underlying devices may be leftover after the aggregated device is deleted.
>Add the missing calls and a few related tests.
I'm not seeing any gaps in the logic; so, for the bonding parts
of the series
Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>
-J
>v2:
>* fix selftest installation, see patch 3
>
>v3:
>* Split lacpdu_multicast changes to their own patch, #1
>* In ndo_{add,del}_slave methods, only perform address list changes when
> the aggregated device is up (patches 2 & 3)
>* Add selftest function related to the above change (patch 4)
>
>Benjamin Poirier (4):
> net: bonding: Share lacpdu_mcast_addr definition
> net: bonding: Unsync device addresses on ndo_stop
> net: team: Unsync device addresses on ndo_stop
> net: Add tests for bonding and team address list management
>
> MAINTAINERS | 1 +
> drivers/net/bonding/bond_3ad.c | 5 +-
> drivers/net/bonding/bond_main.c | 57 +++++----
> drivers/net/team/team.c | 24 +++-
> include/net/bond_3ad.h | 2 -
> include/net/bonding.h | 3 +
> tools/testing/selftests/Makefile | 1 +
> .../selftests/drivers/net/bonding/Makefile | 5 +-
> .../selftests/drivers/net/bonding/config | 1 +
> .../drivers/net/bonding/dev_addr_lists.sh | 109 ++++++++++++++++++
> .../selftests/drivers/net/bonding/lag_lib.sh | 61 ++++++++++
> .../selftests/drivers/net/team/Makefile | 6 +
> .../testing/selftests/drivers/net/team/config | 3 +
> .../drivers/net/team/dev_addr_lists.sh | 51 ++++++++
> 14 files changed, 297 insertions(+), 32 deletions(-)
> create mode 100755 tools/testing/selftests/drivers/net/bonding/dev_addr_lists.sh
> create mode 100644 tools/testing/selftests/drivers/net/bonding/lag_lib.sh
> create mode 100644 tools/testing/selftests/drivers/net/team/Makefile
> create mode 100644 tools/testing/selftests/drivers/net/team/config
> create mode 100755 tools/testing/selftests/drivers/net/team/dev_addr_lists.sh
>
>--
>2.37.2
>
---
-Jay Vosburgh, jay.vosburgh@canonical.com
next prev parent reply other threads:[~2022-09-08 23:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 7:56 [PATCH net v3 0/4] Unsync addresses from ports when stopping aggregated devices Benjamin Poirier
2022-09-07 7:56 ` [PATCH net v3 1/4] net: bonding: Share lacpdu_mcast_addr definition Benjamin Poirier
2022-09-07 7:56 ` [PATCH net v3 2/4] net: bonding: Unsync device addresses on ndo_stop Benjamin Poirier
2022-09-07 7:56 ` [PATCH net v3 3/4] net: team: " Benjamin Poirier
2022-09-07 7:56 ` [PATCH net v3 4/4] net: Add tests for bonding and team address list management Benjamin Poirier
2022-09-08 23:25 ` Jay Vosburgh [this message]
2022-09-16 13:40 ` [PATCH net v3 0/4] Unsync addresses from ports when stopping aggregated devices patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31139.1662679543@famine \
--to=jay.vosburgh@canonical.com \
--cc=andy@greyhouse.net \
--cc=bpoirier@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=jtoppins@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.