All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Binoy Jayan <binoy.jayan@linaro.org>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	kevin Barnett <kevin.barnett@microsemi.com>,
	Don Brace <don.brace@microsemi.com>,
	Scott Benesh <scott.benesh@microsemi.com>,
	Johannes Thumshirn <jthumshirn@suse.de>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] scsi: smartpqi: Replace semaphore sync_request_sem with mutex
Date: Thu, 20 Oct 2016 11:10:39 +0200	[thread overview]
Message-ID: <3118730.6uvAdDZXCF@wuerfel> (raw)
In-Reply-To: <1476953642-2160-2-git-send-email-binoy.jayan@linaro.org>

On Thursday, October 20, 2016 2:24:01 PM CEST Binoy Jayan wrote:
> -       sema_init(&ctrl_info->sync_request_sem,
> -               PQI_RESERVED_IO_SLOTS_SYNCHRONOUS_REQUESTS);
> +       mutex_init(&ctrl_info->sync_request_mutex);
> 

Looking at this again, I see that PQI_RESERVED_IO_SLOTS_SYNCHRONOUS_REQUESTS
is '3', so this is in fact a counting semaphore rather than a mutex,
and the conversion is changing the behavior.

The patch can't go in unless you either show that it should be
a normal mutex rather than a counting semaphore, or you find a way
to keep the behavior the same.

	Arnd

  parent reply	other threads:[~2016-10-20  9:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-20  8:54 [PATCH 0/2] smartpqi: Remove semaphores Binoy Jayan
2016-10-20  8:54 ` [PATCH 1/2] scsi: smartpqi: Replace semaphore sync_request_sem with mutex Binoy Jayan
2016-10-20  9:06   ` Arnd Bergmann
2016-10-24 10:04     ` Binoy Jayan
2016-10-24 10:10       ` Arnd Bergmann
2016-10-20  9:10   ` Arnd Bergmann [this message]
2016-10-24 10:09     ` Binoy Jayan
2016-10-20  8:54 ` [PATCH 2/2] scsi: smartpqi: Replace semaphore lun_reset_sem " Binoy Jayan
2016-10-20  9:08   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3118730.6uvAdDZXCF@wuerfel \
    --to=arnd@arndb.de \
    --cc=binoy.jayan@linaro.org \
    --cc=don.brace@microsemi.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=jthumshirn@suse.de \
    --cc=kevin.barnett@microsemi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=scott.benesh@microsemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.