From: David Howells <dhowells@redhat.com>
To: Matt Mackall <mpm@selenic.com>
Cc: David Howells <dhowells@redhat.com>, Aubrey <aubreylee@gmail.com>,
Nick Piggin <nickpiggin@yahoo.com.au>,
linux-kernel@vger.kernel.org, davidm@snapgear.com,
gerg@snapgear.com
Subject: Re: kernel BUGs when removing largish files with the SLOB allocator
Date: Tue, 12 Sep 2006 22:59:45 +0100 [thread overview]
Message-ID: <31224.1158098385@warthog.cambridge.redhat.com> (raw)
In-Reply-To: <20060912210425.GG19707@waste.org>
Matt Mackall <mpm@selenic.com> wrote:
> The only tricky part is the timer points back to _this very function_.
OIC. Brrr. That _definitely_ needs commenting - as has been demonstrated.
SLOB is using the theoretically one-shot initiator to do garbage collection.
The:
if (size == PAGE_SIZE) /* trying to shrink arena? */
return 0;
In slob_alloc() definitely looks very dodgy, now that I see it. What happens
if some normal user asks to allocate exactly a page? Oh... I suppose it never
gets into slob_alloc() to allocate the main piece of storage.
David
next prev parent reply other threads:[~2006-09-12 22:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 6:56 kernel BUGs when removing largish files with the SLOB allocator Aubrey
2006-09-04 10:21 ` David Howells
2006-09-05 3:52 ` Aubrey
2006-09-05 9:35 ` David Howells
2006-09-06 2:35 ` Aubrey
2006-09-06 3:36 ` Nick Piggin
2006-09-12 8:07 ` Aubrey
2006-09-12 8:54 ` David Howells
2006-09-12 10:53 ` Aubrey
2006-09-12 17:43 ` Matt Mackall
2006-09-12 19:10 ` David Howells
2006-09-12 20:51 ` Matt Mackall
2006-09-12 20:56 ` David Howells
2006-09-12 21:04 ` Matt Mackall
2006-09-12 21:59 ` David Howells [this message]
2006-09-13 19:39 ` Matt Mackall
2006-09-13 2:16 ` Nick Piggin
2006-09-13 7:21 ` Aubrey
2006-09-12 19:25 ` David Howells
2006-09-12 20:28 ` Matt Mackall
2006-09-12 21:02 ` David Howells
2006-09-12 21:15 ` Matt Mackall
2006-09-12 20:49 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31224.1158098385@warthog.cambridge.redhat.com \
--to=dhowells@redhat.com \
--cc=aubreylee@gmail.com \
--cc=davidm@snapgear.com \
--cc=gerg@snapgear.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.