From: Marat Khalili <marat.khalili@huawei.com>
To: Yang Xiaoliang <xiaoliangyang69@gmail.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"john.mcnamara@intel.com" <john.mcnamara@intel.com>
Subject: RE: [PATCH] examples/skeleton: fix typo in initialization comment
Date: Mon, 24 Aug 2026 16:13:16 +0000 [thread overview]
Message-ID: <3127ca2c2be14896af8014c4b95704e0@huawei.com> (raw)
In-Reply-To: <20260812152555.32070-1-xiaoliangyang69@gmail.com>
> -----Original Message-----
> From: Yang Xiaoliang <xiaoliangyang69@gmail.com>
> Sent: Wednesday 12 August 2026 16:26
> To: dev@dpdk.org
> Cc: bruce.richardson@intel.com; john.mcnamara@intel.com; Yang Xiaoliang <xiaoliangyang69@gmail.com>
> Subject: [PATCH] examples/skeleton: fix typo in initialization comment
>
> Fix "Initializion" typo, should be "Initialization".
>
> The sample app guide includes the comment via literalinclude with :start-after: anchored on the same
> string, so update both files together to keep the snippet extraction working.
>
> Signed-off-by: Yang Xiaoliang <xiaoliangyang69@gmail.com>
> ---
> doc/guides/sample_app_ug/skeleton.rst | 2 +-
> examples/skeleton/basicfwd.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/sample_app_ug/skeleton.rst b/doc/guides/sample_app_ug/skeleton.rst
> index c4a29033fe..8a436b1182 100644
> --- a/doc/guides/sample_app_ug/skeleton.rst
> +++ b/doc/guides/sample_app_ug/skeleton.rst
> @@ -55,7 +55,7 @@ function. The value returned is the number of parsed arguments:
>
> .. literalinclude:: ../../../examples/skeleton/basicfwd.c
> :language: c
> - :start-after: Initializion the Environment Abstraction Layer (EAL). 8<
> + :start-after: Initialization the Environment Abstraction Layer (EAL). 8<
> :end-before: >8 End of initialization the Environment Abstraction Layer (EAL).
> :dedent: 1
>
> diff --git a/examples/skeleton/basicfwd.c b/examples/skeleton/basicfwd.c
> index e8c18d5b87..3fdb83519f 100644
> --- a/examples/skeleton/basicfwd.c
> +++ b/examples/skeleton/basicfwd.c
> @@ -176,7 +176,7 @@ main(int argc, char *argv[])
> unsigned nb_ports;
> uint16_t portid;
>
> - /* Initializion the Environment Abstraction Layer (EAL). 8< */
> + /* Initialization the Environment Abstraction Layer (EAL). 8< */
> int ret = rte_eal_init(argc, argv);
> if (ret < 0)
> rte_exit(EXIT_FAILURE, "Error with EAL initialization\n");
> --
> 2.43.0
Even with the fix the phrase is still incorrect, nouns do not take direct object.
Should probably be `Initializing` or `Initialization of`. Consider using an LLM.
prev parent reply other threads:[~2026-08-24 16:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 15:25 [PATCH] examples/skeleton: fix typo in initialization comment Yang Xiaoliang
2026-08-24 16:13 ` Marat Khalili [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3127ca2c2be14896af8014c4b95704e0@huawei.com \
--to=marat.khalili@huawei.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=xiaoliangyang69@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.