All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Schmitt" <scdbackup@gmx.net>
To: grub-devel@gnu.org
Cc: fengtao40@huawei.com
Subject: Re: Possible memory fault in fs/iso9660 (correction)
Date: Sat, 19 Nov 2022 13:57:59 +0100	[thread overview]
Message-ID: <31282400423403277134@scdbackup.webframe.org> (raw)
In-Reply-To: <3122440041805325292@scdbackup.webframe.org>

Hi,

i wrote:
> I think the loop end condition should use 4 rather than 1:
>       (char *) entry < (char *) sua + sua_size - 4 && entry->len > 0

Urm ... better "3 rather than 1":

       (char *) entry < (char *) sua + sua_size - 3 && entry->len > 0

The memory fault by entry->len will appear if
  entry >= sua + sua_size - 2


(Only good i did not submit a patch attempt.
Why is that "- 1" present anyways ? Shall it ensure the presence of
entry->type ?)


Have a nice day :)

Thomas



  reply	other threads:[~2022-11-19 12:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-19 12:38 Possible memory fault in fs/iso9660 Thomas Schmitt
2022-11-19 12:57 ` Thomas Schmitt [this message]
2022-11-24 13:17   ` Possible memory fault in fs/iso9660 (correction) Daniel Kiper
2022-11-24 15:16     ` Thomas Schmitt
2022-11-29  9:32       ` Fengtao (fengtao, Euler)
2022-11-29 14:26         ` Daniel Kiper
2022-11-29 19:12           ` Thomas Schmitt
2022-11-29 18:47         ` Thomas Schmitt
2022-12-12 14:32           ` Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31282400423403277134@scdbackup.webframe.org \
    --to=scdbackup@gmx.net \
    --cc=fengtao40@huawei.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.