All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: fix a comment
Date: Thu, 9 May 2013 15:12:13 +0200 (CEST)	[thread overview]
Message-ID: <312861995.674402.1368105133277.JavaMail.root@advansee.com> (raw)
In-Reply-To: <1368083537-32075-1-git-send-email-yamada.m@jp.panasonic.com>

Dear Masahiro Yamada,

On Thursday, May 9, 2013 9:12:17 AM, Masahiro Yamada wrote:
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
>  arch/arm/lib/crt0.S |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/lib/crt0.S b/arch/arm/lib/crt0.S
> index a9657d1..58fcd03 100644
> --- a/arch/arm/lib/crt0.S
> +++ b/arch/arm/lib/crt0.S
> @@ -103,7 +103,7 @@ ENTRY(_main)
>  	sub	r8, r8, #GD_SIZE		/* new GD is below bd */
>  
>  	adr	lr, here
> -	ldr	r0, [r8, #GD_RELOC_OFF]		/* lr = gd->start_addr_sp */
> +	ldr	r0, [r8, #GD_RELOC_OFF]		/* r0 = gd->reloc_off */
>  	add	lr, lr, r0
>  	ldr	r0, [r8, #GD_RELOCADDR]		/* r0 = gd->relocaddr */
>  	b	relocate_code
> --
> 1.7.9.5
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
> 

Correct. While you're at it, can you also fix the comment on line 100:
"r8 = gd->start_addr_sp" -> "sp = gd->start_addr_sp"

Thanks.

Best regards,
Beno?t

  reply	other threads:[~2013-05-09 13:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-09  7:12 [U-Boot] [PATCH] arm: fix a comment Masahiro Yamada
2013-05-09 13:12 ` Benoît Thébaudeau [this message]
2013-05-10  4:31   ` Masahiro Yamada
2013-05-10  4:21 ` [U-Boot] [PATCH v2] " y at epochmail.jp.panasonic.com
2013-05-10  8:23   ` Masahiro Yamada
2013-05-10  4:24 ` Masahiro Yamada
2013-05-14  1:43   ` Masahiro Yamada
2013-05-14  6:20     ` Albert ARIBAUD
2013-05-15  8:33       ` [U-Boot] [PATCH v3] cosmetic: arm: fix comments in arch/arm/lib/crt0.S Masahiro Yamada
2013-06-10 19:25         ` Albert ARIBAUD
2013-05-15  8:46       ` [U-Boot] [PATCH v2] arm: fix a comment Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=312861995.674402.1368105133277.JavaMail.root@advansee.com \
    --to=benoit.thebaudeau@advansee.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.