Re: [PATCH v2 5/5] drm/i915/irq: split ILK display irq handling

[Jani Nikula <jani.nikula@intel.com>]

On Tue, 23 Sep 2025, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Tue, Sep 23, 2025 at 05:31:08PM +0300, Jani Nikula wrote:
>> Split out display irq handling on ilk. Since the master IRQ enable is in
>> DEIIR, we'll need to do this in two parts. First, add
>> ilk_display_irq_master_disable() to disable master and south interrupts,
>> and second, add (repurposed) ilk_display_irq_handler() to finish display
>> irq handling.
>> 
>> It's not the prettiest thing you ever saw, but improves separation of
>> display irq handling. And removes HAS_PCH_NOP() and DISPLAY_VER() checks
>> from core irq code.
>> 
>> v2:
>> - Separate ilk_display_irq_master_enable() (Ville)
>> - Use _fw mmio accessors (Ville)
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Thanks for the swift reviews, pushed to din.

Xe CI didn't run on this version, but this does not touch any codepaths
that get run on platforms in Xe CI. And the previous version passed.

BR,
Jani.



-- 
Jani Nikula, Intel