Re: [PATCH 2/4] ARM64: renesas: r8a7795: Add VSP instances

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Geert,

On Tuesday 22 December 2015 14:43:34 Geert Uytterhoeven wrote:
> On Thu, Dec 17, 2015 at 8:21 AM, Laurent Pinchart wrote:
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > b/arch/arm64/boot/dts/renesas/r8a7795.dtsi index
> > 9ce6a5ea6629..47f97ffc6c8b 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > @@ -775,5 +775,119 @@
> >                         clocks = <&cpg CPG_MOD 915>;
> >                         status = "disabled";
> >                 };
> > +
> > +               vspbc: vsp@fe920000 {
> > +                       compatible = "renesas,vsp2";
> > +                       reg = <0 0xfe920000 0 0x8000>;
> > +                       interrupts = <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&cpg CPG_MOD 624>;
> 
> No "power-domains = <&cpg_clocks>;"?
> Each vsp device node corresponds nicely to one vsp module, and the driver
> doesn't care at all about the clock, except for (explicit) PM of the vsp
> modules.
> 
> That would allow to simplify vsp1_device_get(), vsp1_pm_suspend(), and
> vsp1_pm_resume(), and get rid of vsp1_device_put() in favor of
> pm_runtime_put().

I'm all for simplification :-) I'll try to find time to move the driver to 
runtime PM. What will happen if the power domain is specified in DT but the 
driver doesn't use runtime PM yet ?

-- 
Regards,

Laurent Pinchart