From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v8 01/15] eal: introduce atomic exchange operation Date: Fri, 26 Jan 2018 18:14:01 +0100 Message-ID: <3131860.My9xXdrCmY@xps> References: <20180126020151.979-1-stephen@networkplumber.org> <20180126020151.979-2-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Chao Zhu , bruce.richardson@intel.com, konstantin.ananyev@intel.com To: Stephen Hemminger Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 81EFB1B315 for ; Fri, 26 Jan 2018 18:14:44 +0100 (CET) In-Reply-To: <20180126020151.979-2-stephen@networkplumber.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/01/2018 03:01, Stephen Hemminger: > To handle atomic update of link status (64 bit), every driver > was doing its own version using cmpset. > Atomic exchange is a useful primitive in its own right; > therefore make it a EAL routine. > > Signed-off-by: Stephen Hemminger > --- > .../common/include/arch/ppc_64/rte_atomic.h | 21 +++++- > .../common/include/arch/x86/rte_atomic.h | 24 +++++++ > .../common/include/arch/x86/rte_atomic_32.h | 12 ++++ > .../common/include/arch/x86/rte_atomic_64.h | 12 ++++ > lib/librte_eal/common/include/generic/rte_atomic.h | 78 ++++++++++++++++++++++ > 5 files changed, 146 insertions(+), 1 deletion(-) Looks good, thanks. It probably deserves a review by PPC experts. Adding Chao, maintainer of this part. + Bruce and Konstantin for x86 part.