Re: [PATCH v3 1/3] drm/layerscape: Add sii9022a driver

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Meng Yi <meng.yi@nxp.com>,
	Xiubo Li <lixiubo@cmss.chinamobile.com>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Alison Wang <alison.wang@nxp.com>,
	Emil Velikov <emil.l.velikov@gmail.com>,
	ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v3 1/3] drm/layerscape: Add sii9022a driver
Date: Thu, 10 Mar 2016 11:11:15 +0200	[thread overview]
Message-ID: <3136741.oOyACC9Lar@avalon> (raw)
In-Reply-To: <20160309142200.2a96123e@bbrezillon>

Hi Boris,

On Wednesday 09 March 2016 14:22:00 Boris Brezillon wrote:
> On Wed, 9 Mar 2016 11:49:38 +0000 Emil Velikov wrote:
> > On 9 March 2016 at 08:31, Meng Yi <meng.yi@nxp.com> wrote:
> >> The SiI9022A is an ultra low-power HDMI transmitter. It supports
> >> resolutions from standard definition 480i/p and 576i/p all the way
> >> to high-definition 720p, 1080i, and 1080p, the highest resolution
> >> supported 4K today. It also supports all PC resolutions up
> >> to UXGA for netbooks
> > 
> > An alternative approach (making a drm bridge) for the sii902x devices
> > was taken by Boris a bit before your initial submission of this driver
> > [1]. I believe that you guys can coordinate and once a decision is made
> > whether a i2c or bridge driver (personally leaning towards the
> > latter), you can work together and review each others' work.
> 
> The reason I decided to expose the device as a drm_bridge is because
> there was several discussions about merging drm_bridge and
> drm_encoder_slave, and IIRC, the proposal was to move to the drm_bridge
> approach.

That's correct. We're converting the adv7511 driver from the slave encoder 
framework to the bridge framework, and I really would like to see the 
remaining three drivers (ch7006, sil164 and tda998x) being converted too. We 
could then finally get rid of drm_slave_encoder.

> Another reason I've chosen to go for the drm_bridge solution is because
> I wanted to avoid as much as possible the development of a new glue for
> each new encoder bridge type (HDMI/DVI, DP, ...), and, AFAICT drm_bridge
> allow that, while it's a bit more complicated with drm_encoder_slave.
>
> > Alternatively you can take a review/comment on a similar work (SiI8620
> > bridge device) by Andrzej, who would return the favour and check this
> > series :-)
> 
> Yes, I'll try to have a look.

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel