From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH 1/2] arm64: dts: rockchip: Fix multiple thermal zones conflict in rk3399.dtsi Date: Thu, 27 Jun 2019 00:26:59 +0200 Message-ID: <3137613.utG1qvTnjZ@phil> References: <20190604165802.7338-1-daniel.lezcano@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20190604165802.7338-1-daniel.lezcano@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Daniel Lezcano Cc: linux-kernel@vger.kernel.org, edubezval@gmail.com, manivannan.sadhasivam@linaro.org, Rob Herring , Mark Rutland , Matthias Brugger , Philipp Tomsich , Christoph Muellner , Viresh Kumar , Enric Balletbo i Serra , Emil Renner Berthing , Randy Li , Tony Xie , Vicente Bergas , Klaus Goger , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Rockchip SoC support" List-Id: linux-rockchip.vger.kernel.org Am Dienstag, 4. Juni 2019, 18:57:57 CEST schrieb Daniel Lezcano: > Currently the common thermal zones definitions for the rk3399 assumes > multiple thermal zones are supported by the governors. This is not the > case and each thermal zone has its own governor instance acting > individually without collaboration with other governors. > > As the cooling device for the CPU and the GPU thermal zones is the > same, each governors take different decisions for the same cooling > device leading to conflicting instructions and an erratic behavior. > > As the cooling-maps is about to become an optional property, let's > remove the cpu cooling device map from the GPU thermal zone. > > Signed-off-by: Daniel Lezcano applied both patches for 5.3 Thanks Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E510C48BD6 for ; Thu, 27 Jun 2019 05:29:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51168208E3 for ; Thu, 27 Jun 2019 05:29:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fn78++8y"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Dxqj0cia" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51168208E3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AcfmlqNlGhpu8Tlh8MPTBmMAgbNXBrX1PUOswBj5xWE=; b=fn78++8yGtQsex YzJfhHySBIPIGJFaqwTw+p0kheCCj8QvtfWbmq4wb7Tb9Al13x2sMC4ynci3NBEfYOhqo2VkvXpni TvRFSGuXqfjV4yEHwR0Qr3nYo1nv5RnRTC6lv8SxJgxDcavsBVXwUVipwaDHL0b96TOZusSWZCnkC qGRCINkri0b6XAXOAepWblbrao6haqUH/oNrwQSmcGOgudAKVwUc63ZVc6IyT91MEBHgUn8OvueOV 7/9cVQtHEko/Fmpxu48mDvjNBc3sGt5m7FHMNH7hX/2G0q9uZswgPCi426qtZSytqi9H2fDGAZSJ+ I7Q2ayuoq4tYGyL5UuUw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hgMyK-0000MD-2B; Thu, 27 Jun 2019 05:29:24 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hgMsn-00033C-6f; Thu, 27 Jun 2019 05:23:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=P/IuSyAbQhXoB6N8MgUtFItwFW363oZJoVXKBRyzROs=; b=Dxqj0ciavKjOw1A7BFxt2ChdbN g6iKuYEjcOuzoy0NB4TU4b7ah5cjKtaNpUlb18Pce/cFhFdiXh96buGbrBiL6Zi24wQsr6MK0Mita 53NUCNROdxw7EJHVVGC9+e3dM9rohJk3W9dmBtnwlKjidbcV0K8jqj57LhaPev3/HOPmBuOpBFuhh YM+R8ezG/DaabPwZsqcP0oOcqQ0Y5R+ZqJevwDcYFcZbfp+kde+QaYRTGsFj2qzYNUX0jNNFKTxbN HYewGz11KDUh0GvCqMm6oRE4+sNvIx7uRGgsFqs9WeAoD+GhmzIgS906GswDxWI9Q+ryXGo26e+0c U25eXMWA==; Received: from gloria.sntech.de ([185.11.138.130]) by casper.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hgGNl-0006xn-L5; Wed, 26 Jun 2019 22:27:15 +0000 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgGNY-0004SG-E9; Thu, 27 Jun 2019 00:27:00 +0200 From: Heiko Stuebner To: Daniel Lezcano Subject: Re: [PATCH 1/2] arm64: dts: rockchip: Fix multiple thermal zones conflict in rk3399.dtsi Date: Thu, 27 Jun 2019 00:26:59 +0200 Message-ID: <3137613.utG1qvTnjZ@phil> In-Reply-To: <20190604165802.7338-1-daniel.lezcano@linaro.org> References: <20190604165802.7338-1-daniel.lezcano@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190626_232713_768493_9D3BD0B0 X-CRM114-Status: GOOD ( 13.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Emil Renner Berthing , "open list:ARM/Rockchip SoC support" , Tony Xie , Viresh Kumar , Randy Li , linux-kernel@vger.kernel.org, Vicente Bergas , edubezval@gmail.com, Enric Balletbo i Serra , Rob Herring , Klaus Goger , manivannan.sadhasivam@linaro.org, Matthias Brugger , Philipp Tomsich , "moderated list:ARM/Rockchip SoC support" , Christoph Muellner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Dienstag, 4. Juni 2019, 18:57:57 CEST schrieb Daniel Lezcano: > Currently the common thermal zones definitions for the rk3399 assumes > multiple thermal zones are supported by the governors. This is not the > case and each thermal zone has its own governor instance acting > individually without collaboration with other governors. > > As the cooling device for the CPU and the GPU thermal zones is the > same, each governors take different decisions for the same cooling > device leading to conflicting instructions and an erratic behavior. > > As the cooling-maps is about to become an optional property, let's > remove the cpu cooling device map from the GPU thermal zone. > > Signed-off-by: Daniel Lezcano applied both patches for 5.3 Thanks Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31A62C48BD6 for ; Wed, 26 Jun 2019 22:27:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 096A421738 for ; Wed, 26 Jun 2019 22:27:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726638AbfFZW1I (ORCPT ); Wed, 26 Jun 2019 18:27:08 -0400 Received: from gloria.sntech.de ([185.11.138.130]:56788 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726370AbfFZW1I (ORCPT ); Wed, 26 Jun 2019 18:27:08 -0400 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgGNY-0004SG-E9; Thu, 27 Jun 2019 00:27:00 +0200 From: Heiko Stuebner To: Daniel Lezcano Cc: linux-kernel@vger.kernel.org, edubezval@gmail.com, manivannan.sadhasivam@linaro.org, Rob Herring , Mark Rutland , Matthias Brugger , Philipp Tomsich , Christoph Muellner , Viresh Kumar , Enric Balletbo i Serra , Emil Renner Berthing , Randy Li , Tony Xie , Vicente Bergas , Klaus Goger , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Rockchip SoC support" , "open list:ARM/Rockchip SoC support" Subject: Re: [PATCH 1/2] arm64: dts: rockchip: Fix multiple thermal zones conflict in rk3399.dtsi Date: Thu, 27 Jun 2019 00:26:59 +0200 Message-ID: <3137613.utG1qvTnjZ@phil> In-Reply-To: <20190604165802.7338-1-daniel.lezcano@linaro.org> References: <20190604165802.7338-1-daniel.lezcano@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 4. Juni 2019, 18:57:57 CEST schrieb Daniel Lezcano: > Currently the common thermal zones definitions for the rk3399 assumes > multiple thermal zones are supported by the governors. This is not the > case and each thermal zone has its own governor instance acting > individually without collaboration with other governors. > > As the cooling device for the CPU and the GPU thermal zones is the > same, each governors take different decisions for the same cooling > device leading to conflicting instructions and an erratic behavior. > > As the cooling-maps is about to become an optional property, let's > remove the cpu cooling device map from the GPU thermal zone. > > Signed-off-by: Daniel Lezcano applied both patches for 5.3 Thanks Heiko