Re: [dpdk-dev] [PATCH 0/6] net/bnxt: bounds checking patches

[Thomas Monjalon <thomas@monjalon.net>]

Why there was no progress on this during 6 months?

Ajit, it was out of my radar because delegated to you.

Please restart fresh with a separate patch for EAL,
addressing comments. Thanks


31/03/2020 20:04, Stephen Hemminger:
> On Tue, 31 Mar 2020 10:52:47 -0700
> Ajit Khaparde <ajit.khaparde@broadcom.com> wrote:
> 
> > On Tue, Mar 31, 2020 at 5:23 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> > 
> > > On 3/3/2020 5:59 PM, Stephen Hemminger wrote:  
> > > > This set of patches came from security review of bnxt driver.
> > > > It introduces a set of overflow macros that could be more widely
> > > > used in other places in DPDK to check for math overflows.
> > > >
> > > > Stephen Hemminger (6):
> > > >   eal: add portable way to check for math overflow
> > > >   net/bnxt: fix potential data race
> > > >   net/bnxt: avoid potential out of bounds read
> > > >   net/bnxt: check for integer overflow in buffer sizing
> > > >   net/bnxt: add integer underflow check
> > > >   net/bnxt: sanitize max_l2_ctx
> > > >  
> > >
> > > Hi Ajit,
> > >
> > > I can see this patchset has been merged into your tree, although the note
> > > in the
> > > mail list is missing. Since it has eal changes, I believe they should be
> > > reviewed first before merging into brcm tree, can you separate the eal and
> > > dependent patch for review, we can proceed with rest?
> > >  
> > I don't mind.
> > But being original owner - Stephen, do you want to go ahead?
> > 
> > Thanks
> > Ajit
> > 
> > >
> > > Regards,
> > > ferruh
> > >  
> 
> Sure, I expected normal review cycle on this.
> Hoped that other drivers and eal core would also add overflow checks
>