From: Hagen Paul Pfeifer <hagen@jauu.net>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Shriram Rajagopalan <rshriram@cs.ubc.ca>,
<netdev@vger.kernel.org>, Brendan Cully <brendan@cs.ubc.ca>
Subject: Re: [PATCH V2] net/sched: sch_plug - Queue traffic until an explicit release command
Date: Mon, 30 Jan 2012 15:54:52 +0100 [thread overview]
Message-ID: <313929ea4dca3c8fd6948797e03121a8@localhost> (raw)
In-Reply-To: <1327934756.2243.3.camel@mojatatu>
On Mon, 30 Jan 2012 09:45:56 -0500, Jamal Hadi Salim wrote:
> Please address the comment from Hagen on the printk (kill it).
> Other than that i think this simple enough and non-intrusive
> to other users that you can add an Acked-by from me.
> It will be nice to get it to be generic as per Hagen's and my
> earlier comments.
I thought about sch_plug a second time and I like the idea of a user-space
based flow-controlled queue. But as I wrote in my first email: the current
implementation is a little bit XEN specific. Make it more general
(plug/unplug, plug/packet-based-unplug) and it is a great contribution.
Hagen
next prev parent reply other threads:[~2012-01-30 14:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-29 7:53 [PATCH V2] net/sched: sch_plug - Queue traffic until an explicit release command Shriram Rajagopalan
2012-01-29 17:25 ` Hagen Paul Pfeifer
2012-01-30 14:45 ` Jamal Hadi Salim
2012-01-30 14:54 ` Hagen Paul Pfeifer [this message]
2012-01-30 16:47 ` Shriram Rajagopalan
2012-01-31 15:25 ` Hagen Paul Pfeifer
2012-01-31 16:20 ` Shriram Rajagopalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=313929ea4dca3c8fd6948797e03121a8@localhost \
--to=hagen@jauu.net \
--cc=brendan@cs.ubc.ca \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=rshriram@cs.ubc.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.