All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>
Subject: Re: [RFC] Remove Kernel Network Interface (KNI)
Date: Fri, 13 Jan 2023 19:34:24 +0100	[thread overview]
Message-ID: <3142342.SvYEEZNnvj@thomas> (raw)
In-Reply-To: <20230113091326.20d210c9@hermes.local>

13/01/2023 18:13, Stephen Hemminger:
> On Fri, 13 Jan 2023 09:12:16 +0100
> Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> > 13/01/2023 06:03, Stephen Hemminger:
> > > The Linux special network driver for kernel networking has been
> > > a long term problem for DPDK. The performance benefits of KNI
> > > are available via virtio-user and XDP, and the simpler kernel
> > > interface via TAP is also available.
> > > 
> > > This driver has required lots of effort to keep up with the
> > > kernel API changes. And the overall architecture of the driver
> > > is fundamentally insecure and has unfixable locking and data
> > > race problems. No developer has been willing to do extensive
> > > tests or be the maintainer.
> > > 
> > > In short, the time has come to do some early spring cleaning
> > > and remove KNI from DPDK 23.03.  
> > 
> > In doc/guides/rel_notes/deprecation.rst it is announced
> > to be removed in 23.11. Let's keep this RFC for later :)
> > 
> > 
> 
> For 23.03 could we add a deprecation log message when library is
> used and when kernel module is loaded.

We already have a message in the lib:

int
rte_kni_init(unsigned int max_kni_ifaces __rte_unused)
{
	RTE_LOG(WARNING, KNI, "WARNING: KNI is deprecated and will be removed in DPDK 23.11\n");

It is a good idea to add a message in the kernel module loading.





  reply	other threads:[~2023-01-13 18:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13  5:03 [RFC] Remove Kernel Network Interface (KNI) Stephen Hemminger
2023-01-13  8:12 ` Thomas Monjalon
2023-01-13 17:13   ` Stephen Hemminger
2023-01-13 18:34     ` Thomas Monjalon [this message]
2023-01-13 23:25       ` Stephen Hemminger
2023-01-14 22:21         ` Tyler Retzlaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3142342.SvYEEZNnvj@thomas \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.