From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1crQj8-0004WR-6e for ath10k@lists.infradead.org; Fri, 24 Mar 2017 15:02:15 +0000 Received: by mail-wr0-x242.google.com with SMTP id u108so798072wrb.2 for ; Fri, 24 Mar 2017 08:01:45 -0700 (PDT) From: Christian Lamparter Subject: Re: QCA9984 bmi identification failure Date: Fri, 24 Mar 2017 16:01:42 +0100 Message-ID: <3143301.IOZImBPhRt@debian64> In-Reply-To: <4960795b-028f-27b1-8bdf-6c9fb2242f5f@dd-wrt.com> References: <3243718.FYinmXYgr7@debian64> <4960795b-028f-27b1-8bdf-6c9fb2242f5f@dd-wrt.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Sebastian Gottschall Cc: Adrian Chadd , "linux-wireless (linux-wireless@vger.kernel.org)" , ath10k@lists.infradead.org, ath10k-devel , "Valo, Kalle" , hannu.nyman@iki.fi, Michal Kazior T24gRnJpZGF5LCBNYXJjaCAyNCwgMjAxNyAxMTowOTowMyBBTSBDRVQgU2ViYXN0aWFuIEdvdHRz Y2hhbGwgd3JvdGU6Cj4gaSBoYXZlIGEgcjc4MDAgcnVubmluZy4gY29uc2lkZXIgdG8gdXNlIHRo ZSBib2FyZC5iaW4gZmlsZSB3aGljaCBpcyAKPiBzdG9yZWQgaW4gZmxhc2ggbWVtb3J5IG9mIHRo ZSByNzgwMC4KV2VsbCwgdGhpcyBpcyBhIGJpdCBiZXNpZGUgdGhlIHBvaW50LiBCdXQgd2hhdCBt YWtlcyB5b3UgdGhpbmsgdGhhdCAKd2hhdCBpcyBzdG9yZWQgaW4gdGhlIGZsYXNoIG1lbW9yeSBv ZiBSNzgwMCBpcyB0aGUgImJvYXJkLmJpbiI/IApJIGtub3cgdGhhdCBOZXRnZWFyIHByb3ZpZGVk IGEgbXlyaWFkIG9mIGRpZmZlcmVudCBib2FyZCBkYXRhIGZpbGVzCndpdGggaW4gdGhlcmUgR1BM IGRyb3A6CgpIZXJlJ3MgYSBsaW5rOgo8aHR0cHM6Ly9naXRodWIuY29tL3BhdWwtY2hhbWJlcnMv bmV0Z2Vhci1yNzgwMC90cmVlL21hc3Rlci9naXRfaG9tZS9tYWR3aWZpLTExbi5naXQvaGFscGh5 X3Rvb2xzL2hvc3QvZWVwcm9tVXRpbC9yZWxlYXNlX3FjYTk5ODQvaHcxPgoKU28sIGRvZXMgdGhl IGRhdGEgaW4geW91ciBmbGFzaCBtYXRjaGVzIGFueSBvZiB0aG9zZSBmaWxlcyAxOjEgb3Igbm90 PwoKKE5vdGU6IEZyb20gd2hhdCBJIGtub3csIGl0J3MgdGhlIGNhbGRhdGEgdGhhdCdzIGluIHRo ZSBmbGFzaC4gCmNhbGRhdGEg4omIIGNhbCtib2FyZC4gQnV0IEknbSBhc2tpbmcgd2h5IGF0aDEw aydzIGJtaSBpZGVudGlmaWNhdGlvbgppc24ndCB3b3JraW5nIGZvciB0aG9zZSBjaGlwcyByaWdo dCBub3cuIEFuZCBqdWRnaW5nIGZyb20geW91ciBsb2dzLAp5b3UgYXJlIHVzaW5nIHByb2JhYmx5 IGEgc2ltaWxhciBXQSB0byB0aGUgCjkzNi1hdGgxMGtfc2tpcF9vdHBfY2hlY2sucGF0Y2ggb3V0 IG9mIG5lY2Vzc2l0eSBhcyB3ZWxsLikKCj4gdGhlcmUgYXJlIDIgc3RvcmVkIGZvciBib3RoIGNh cmRzLiB5b3UgbmVlZCB0byBwYXRjaCBhdGgxMGsgdG8gdXNlIAo+IGRpZmZlcmVudCBib2FyZC5i aW4gZmlsZXMgZm9yIGVhY2ggY2FyZC4KRXhhY3RseS4gV2h5IGRvIHlvdSAob3IgYW55b25lIGZv ciB0aGF0IG1hdHRlcikgbmVlZCB0byBwYXRjaCBhdGgxMGs/ClRoZSBkcml2ZXIgaXMgc3VwcG9z ZWQgdG8gc3VwcG9ydCB0aGUgUUNBOTk4NCBvdXQgb2YgdGhlIGJveCwgcmlnaHQ/CgpBbmQgSSBr bm93LCB0aGF0IHRoZSBibWkgaWRlbnRpZmljYXRpb24gaXMgc3VwcG9zZWQgdG8gd29yaywgYXMK c29tZWJvZHkgcG9zdGVkIHRoZSBmb2xsb3dpbmcgbG9nOgo8aHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvcGlwZXJtYWlsL2xlZGUtZGV2LzIwMTYtRGVjZW1iZXIvMDA0OTg3Lmh0bWw+CgpbICAz NzkuMzkyMjEwXSBhdGgxMGtfcGNpIDAwMDI6MDE6MDAuMDogYm9vdCB1cGxvYWQgb3RwIHRvIDB4 MTIzNCBsZW4gOTAwMCBmb3IgYm9hcmQgaWQKWyAgMzc5LjM5OTk0NV0gYXRoMTBrX3BjaSAwMDAy OjAxOjAwLjA6IGJtaSBmYXN0IGRvd25sb2FkIGFkZHJlc3MgMHgxMjM0IGJ1ZmZlciAweGUxNjc2 MDM4IGxlbmd0aCA5MDAwClsgIDM3OS40MDg5NzddIGF0aDEwa19wY2kgMDAwMjowMTowMC4wOiBi bWkgbHogc3RyZWFtIHN0YXJ0IGFkZHJlc3MgMHgxMjM0ClsgIDM3OS40MTU2MDNdIGF0aDEwa19w Y2kgMDAwMjowMTowMC4wOiBibWkgbHogZGF0YSBidWZmZXIgMHhlMTY3NjAzOCBsZW5ndGggOTAw MApbICAzNzkuNDUxNjI2XSBhdGgxMGtfcGNpIDAwMDI6MDE6MDAuMDogYm1pIGx6IHN0cmVhbSBz dGFydCBhZGRyZXNzIDB4MApbICAzNzkuNDU3OTg1XSBhdGgxMGtfcGNpIDAwMDI6MDE6MDAuMDog Ym1pIGV4ZWN1dGUgYWRkcmVzcyAweDEyMzQgcGFyYW0gMHgxMApbICAzODAuODU3MDA2XSBhdGgx MGtfcGNpIDAwMDI6MDE6MDAuMDogYm1pIGV4ZWN1dGUgcmVzdWx0IDB4NDAwClsgIDM4MC44NjI3 NDldIGF0aDEwa19wY2kgMDAwMjowMTowMC4wOiBib290IGdldCBvdHAgYm9hcmQgaWQgcmVzdWx0 IDB4MDAwMDA0MDAgYm9hcmRfaWQgMSBjaGlwX2lkIDAKWyAgMzgwLjg3MTYwM10gYXRoMTBrX3Bj aSAwMDAyOjAxOjAwLjA6IGJvb3QgdXNpbmcgYm9hcmQgbmFtZSAnYnVzPXBjaSxibWktY2hpcC1p ZD0wLGJtaS1ib2FyZC1pZD0xJwpbICAzODAuODgwNDY4XSBhdGgxMGtfcGNpIDAwMDI6MDE6MDAu MDogYm9hcmQgbmFtZQpbICAzODAuODg0OTk5XSBhdGgxMGtfcGNpIDAwMDI6MDE6MDAuMDogMDAw MDAwMDA6IDYyIDc1IDczIDNkIDcwIDYzIDY5IDJjIDYyIDZkIDY5IDJkIDYzIDY4IDY5IDcwICBi dXM9cGNpLGJtaS1jaGlwClsgIDM4MC44OTUxNTldIGF0aDEwa19wY2kgMDAwMjowMTowMC4wOiAw MDAwMDAxMDogMmQgNjkgNjQgM2QgMzAgMmMgNjIgNmQgNjkgMmQgNjIgNmYgNjEgNzIgNjQgMmQg IC1pZD0wLGJtaS1ib2FyZC0KWyAgMzgwLjkwNTMxN10gYXRoMTBrX3BjaSAwMDAyOjAxOjAwLjA6 IDAwMDAwMDIwOiA2OSA2NCAzZCAzMSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgaWQ9MQpbICAzODAuOTE0NDM2XSBhdGgxMGtfcGNpIDAwMDI6MDE6MDAuMDogYm9vdCBmb3Vu ZCBtYXRjaCBmb3IgbmFtZSAnYnVzPXBjaSxibWktY2hpcC1pZD0wLGJtaS1ib2FyZC1pZD0xJwpb ICAzODAuOTIzNjQwXSBhdGgxMGtfcGNpIDAwMDI6MDE6MDAuMDogYm9vdCBmb3VuZCBib2FyZCBk YXRhIGZvciAnYnVzPXBjaSxibWktY2hpcC1pZD0wLGJtaS1ib2FyZC1pZD0xJwpbICAzODAuOTMy ODQ1XSBhdGgxMGtfcGNpIDAwMDI6MDE6MDAuMDogdXNpbmcgYm9hcmQgYXBpIDIKLi4uCgpUaGUg Ym9hcmQgbmFtZSBmb3IgdGhlIFFDQTk5ODQgaXMgc3VwcG9zZWQgdG8gbG9vayBsaWtlCiInYnVz PXBjaSxibWktY2hpcC1pZD0wLGJtaS1ib2FyZC1pZD0xJyIKCmFuZCBub3QgbGlrZSAoZnJvbSB5 b3VyIGxvZyk6Cj4gYnVzPXBjaSx2ZW5kb3I9MTY4YyxkZXZpY2U9MDA0NixzdWJzeXN0ZW0tdmVu ZG9yPTE2OGMsc3Vic3lzdGVtLWRldmljZT1jYWZlIAo+IGZyb20gYXRoMTBrL1FDQTk5ODQvaHcx LjAvYm9hcmQtMi5iaW4KCj4gdGhlIGZhaWxlZCB0byBmZXRjaCBib2FyZCBkYXRhIGVycm9yIGlz IG5vcm1hbC4gCkkgZG9uJ3QgdGhpbmsgaXQgaXMuIEkgdGhpbmsgaXQncyBhIHJlZ3Jlc3Npb24u CgpUaGFua3MsCkNocmlzdGlhbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KYXRoMTBrIG1haWxpbmcgbGlzdAphdGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDEwawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wr0-f195.google.com ([209.85.128.195]:35041 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751520AbdCXPDS (ORCPT ); Fri, 24 Mar 2017 11:03:18 -0400 Received: by mail-wr0-f195.google.com with SMTP id u108so798071wrb.2 for ; Fri, 24 Mar 2017 08:01:45 -0700 (PDT) From: Christian Lamparter To: Sebastian Gottschall Cc: ath10k@lists.infradead.org, ath10k-devel , Michal Kazior , "Valo, Kalle" , "linux-wireless (linux-wireless@vger.kernel.org)" , hannu.nyman@iki.fi, Adrian Chadd Subject: Re: QCA9984 bmi identification failure Date: Fri, 24 Mar 2017 16:01:42 +0100 Message-ID: <3143301.IOZImBPhRt@debian64> (sfid-20170324_160323_344521_AAA42767) In-Reply-To: <4960795b-028f-27b1-8bdf-6c9fb2242f5f@dd-wrt.com> References: <3243718.FYinmXYgr7@debian64> <4960795b-028f-27b1-8bdf-6c9fb2242f5f@dd-wrt.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: On Friday, March 24, 2017 11:09:03 AM CET Sebastian Gottschall wrote: > i have a r7800 running. consider to use the board.bin file which is=20 > stored in flash memory of the r7800. Well, this is a bit beside the point. But what makes you think that=20 what is stored in the flash memory of R7800 is the "board.bin"?=20 I know that Netgear provided a myriad of different board data files with in there GPL drop: Here's a link: So, does the data in your flash matches any of those files 1:1 or not? (Note: From what I know, it's the caldata that's in the flash.=20 caldata =E2=89=88 cal+board. But I'm asking why ath10k's bmi identification isn't working for those chips right now. And judging from your logs, you are using probably a similar WA to the=20 936-ath10k_skip_otp_check.patch out of necessity as well.) > there are 2 stored for both cards. you need to patch ath10k to use=20 > different board.bin files for each card. Exactly. Why do you (or anyone for that matter) need to patch ath10k? The driver is supposed to support the QCA9984 out of the box, right? And I know, that the bmi identification is supposed to work, as somebody posted the following log: [ 379.392210] ath10k_pci 0002:01:00.0: boot upload otp to 0x1234 len 9000 = for board id [ 379.399945] ath10k_pci 0002:01:00.0: bmi fast download address 0x1234 bu= ffer 0xe1676038 length 9000 [ 379.408977] ath10k_pci 0002:01:00.0: bmi lz stream start address 0x1234 [ 379.415603] ath10k_pci 0002:01:00.0: bmi lz data buffer 0xe1676038 lengt= h 9000 [ 379.451626] ath10k_pci 0002:01:00.0: bmi lz stream start address 0x0 [ 379.457985] ath10k_pci 0002:01:00.0: bmi execute address 0x1234 param 0x= 10 [ 380.857006] ath10k_pci 0002:01:00.0: bmi execute result 0x400 [ 380.862749] ath10k_pci 0002:01:00.0: boot get otp board id result 0x0000= 0400 board_id 1 chip_id 0 [ 380.871603] ath10k_pci 0002:01:00.0: boot using board name 'bus=3Dpci,bm= i-chip-id=3D0,bmi-board-id=3D1' [ 380.880468] ath10k_pci 0002:01:00.0: board name [ 380.884999] ath10k_pci 0002:01:00.0: 00000000: 62 75 73 3d 70 63 69 2c 6= 2 6d 69 2d 63 68 69 70 bus=3Dpci,bmi-chip [ 380.895159] ath10k_pci 0002:01:00.0: 00000010: 2d 69 64 3d 30 2c 62 6d 6= 9 2d 62 6f 61 72 64 2d -id=3D0,bmi-board- [ 380.905317] ath10k_pci 0002:01:00.0: 00000020: 69 64 3d 31 = id=3D1 [ 380.914436] ath10k_pci 0002:01:00.0: boot found match for name 'bus=3Dpc= i,bmi-chip-id=3D0,bmi-board-id=3D1' [ 380.923640] ath10k_pci 0002:01:00.0: boot found board data for 'bus=3Dpc= i,bmi-chip-id=3D0,bmi-board-id=3D1' [ 380.932845] ath10k_pci 0002:01:00.0: using board api 2 =2E.. The board name for the QCA9984 is supposed to look like "'bus=3Dpci,bmi-chip-id=3D0,bmi-board-id=3D1'" and not like (from your log): > bus=3Dpci,vendor=3D168c,device=3D0046,subsystem-vendor=3D168c,subsystem-d= evice=3Dcafe=20 > from ath10k/QCA9984/hw1.0/board-2.bin > the failed to fetch board data error is normal.=20 I don't think it is. I think it's a regression. Thanks, Christian