Re: [PATCH v1 1/1] mmc: atmel-mci: allow DMA transfers for AVR32

[Arnd Bergmann <arnd@arndb.de>]

On Thursday 06 August 2015 09:01:56 Ludovic Desroches wrote:
> Hi Andy,
> 
> Your patch does a bit more than reverting commit ecb89f2f5f3e. I will
> split it in order to see well which previous patches have been reverted.
> 
> On Mon, Jul 27, 2015 at 05:45:34PM +0300, Andy Shevchenko wrote:
> > On Mon, 2015-07-27 at 14:24 +0200, Arnd Bergmann wrote:
> > > On Monday 27 July 2015 14:53:30 you wrote:
> > > > The commit ecb89f2f5f3e (mmc: atmel-mci: remove compat for non DT 
> > > > board when
> > > > requesting dma chan) removes compat transfer which breaks DMA
> > > > support for ATNGW100. This patch returns back that functionality.
> > > > 
> > > > Cc: Ludovic Desroches <ludovic.desroches@atmel.com>
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > 
> > > 
> > > How about moving that filter function into arch/avr32 to make the
> > > mmc driver independent of the underlying dma engine implementation
> > > at the same time?
> 
> It would be great to not keep code which becomes architecture dependant.
> If we can move the filter function somewhere in arch/avr32, we will have
> to revert commit fda1b26 and use dma_request_slave_channel_compat.
> 
> I had a look to the arch/avr32 directory but I don't know where to put
> this kind of stuff.

Next to the at32_add_device_mci() function, with a pointer to the filter
function added to struct mci_platform_data, and the mci_dma_data
structure replaced with a void pointer after moving the definition
to the same place.

	Arnd