From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1dWKHO-0004Cw-GC for mharc-grub-devel@gnu.org; Sat, 15 Jul 2017 06:26:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWKHL-0004Cm-Nb for grub-devel@gnu.org; Sat, 15 Jul 2017 06:26:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWKHI-0006cT-Io for grub-devel@gnu.org; Sat, 15 Jul 2017 06:26:27 -0400 Received: from mout.gmx.net ([212.227.15.15]:53848) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dWKHI-0006Zx-4Y for grub-devel@gnu.org; Sat, 15 Jul 2017 06:26:24 -0400 Received: from scdbackup.webframe.org ([87.167.207.232]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MNYxW-1dZ5R02tcQ-007DS4 for ; Sat, 15 Jul 2017 12:26:20 +0200 Date: Sat, 15 Jul 2017 12:25:20 +0200 From: "Thomas Schmitt" To: grub-devel@gnu.org Subject: Re: grub-mkrescue reacts vaguely on xorriso problems Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit References: <24380769927419764858@scdbackup.webframe.org> In-Reply-To: <24380769927419764858@scdbackup.webframe.org> Message-Id: <31472768394924736204@scdbackup.webframe.org> X-Provags-ID: V03:K0:CvkxLj37pdFaRxBxlQ+JXXYsx07Bh7Sb0RvCd2MjV92dfzI1Ahe eu9WPvfjhMlzJpQaseWN239PH2VuY78dRnDK7lf7q/VS3N234hyb/GI9MCjLIKxSMDe/PKN 8qbNH2OZWu4pc9aUoz4BrhiFrnEV8Vh/pQxKMWEAycJXMCyqqDrD7//+2/X2HGkJdF+vhNQ aQt2nyXRKO3C93VI1huCQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:3HC4KW0yFvM=:rimjfgvwd+QRf1MUqJjToz EhgNe2fVWX4ay7PjgcAL5aj2p3iOaIKfOqhN6KulOtIpIO9FxIoSHbEbOXWMgK+iav4FsQnLZ rv1cuF8Cf1ccfxHx3oQ+PVQ/XmP6J5gV5JrAYQjOP9TtdkVW3JkGw5x+Azb1fnd+ID4LHY/6+ cKv0n1s9LiGriPboCO/WvlkIPNpgvS7DRELGqCGV56S6T/o0btmwjEnPXjtmrnrHrePZkKFFH wYQWkAd8N32B7WvpqPXy2rE6hWm2K+omQpMWWaYQlQsKbucoace+QB3sXQfvbKJjGpKs0yt9A v3spQPXuzDufWHRxKzmW30eazWL9pagJ4POxdQToIU6Wsd3vEIDGIVERH3+fR9W4S/57fxvr9 k1kkLR96/dd4nvaSo9ApGHkslkk/LdMkH7vB13Ip6Gq7Wk14VzjFYoPG+1IIwv+2AE7P1eGxP cuARZQC8YYU25cHOJrj7ZaiswWp4idEN6+AHcDiY7+jNax5aVuKcnhIh5l3ybjZIW3yNWsWt5 VGpzo9rSr6DXp26JeKyFvoHa5TAOHpaXRP5QMz6yDtlVuKtCP9U0kM9EkZz4GX0Y5vfBASbAt 0LLKD1NMs4aGTcFfLcIFQp1HZRHeB/h1jpK7uhMpZeQjvGT9qSjw97wWod4vKm8DbV8uOPKVv iQryiSpKCiEnNpipsjUNpvU6esMRBKGH5wjQCR/utJFDcUqz/hwIj7Wo3xdkUOlYtYwJhB3Bm VSiLmLPmyh6XgMPvXwveIzOxtiG3ydQkTAXlBtXHJ7LfoMtQoQqCAxahDNxHnayHIa7eCbJF6 j2taMe9Cwl/es2S6KmhVPhl1pzDCkmdeftgM2sO8W0eEEz5+qE= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.15.15 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Jul 2017 10:26:28 -0000 Hi, Ping. (Bug or feature ? If bug: what exactly would be the desirable behavior ?) -------------------------------------------------------------------------- Date: Wed, 14 Jun 2017 11:37:11 +0200 From: Thomas Schmitt To: grub-devel@gnu.org Subject: grub-mkrescue reacts vaguely on xorriso problems Hi, on occasion of https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=864701 "grub-common: grub-mkrescue does nothing, successfully" i wonder whether the reaction of grub-mkrescue on xorriso problems is intended and appropriate. E.g. with: grub-mkrescue -o output.iso SOURCE -------------------------------------------------------------------------- If xorriso is missing, then grub-mkrescue reports grub-mkrescue: warning: Your xorriso doesn't support `--grub2-boot-info'. Some features are disabled. Please use xorriso 1.2.9 or later.. and returns exit value 0. I.e. it does not say that xorriso does not work at all and it does not indicate the failure to its caller. I understand from http://git.savannah.gnu.org/cgit/grub.git/tree/util/grub-mkrescue.c#n571 that the warning is only emitted if the ISO gets prepared for x86 BIOS. So in other cases the run might be totally silent (did not test). Several distros ship grub-mkrescue in packages which do not mandatorily depend on xorriso. So a clearer message from upstream about the necessity of xorriso seems desirable. -------------------------------------------------------------------------- If xorriso is executable and of sufficient version but the user makes a mistake with grub-mkrescue argument SOURCE (or with some added xorrisofs options), then xorriso aborts with e.g. xorriso : FAILURE : Cannot determine attributes of source file '...' : No such file or directory ... xorriso : aborting : -abort_on 'FAILURE' encountered 'FAILURE' no ISO image emerges but grub-mkrescue exits with value 0. A xorriso batch run returns exit value 5 if it aborts due to the -abort_on threshold. But grub-mkrescue ignores the exit value of xorriso in http://git.savannah.gnu.org/cgit/grub.git/tree/util/grub-mkrescue.c#n963 -------------------------------------------------------------------------- Have a nice day :) Thomas