From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, Wolfram Sang <wsa@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Samuel Clark <slc2015@gmail.com>,
stable@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH] i2c: designware: Fix handling of real but unexpected device interrupts
Date: Wed, 28 Sep 2022 08:49:14 +0300 [thread overview]
Message-ID: <31477388-b57b-5383-9c6a-18905c28253e@linux.intel.com> (raw)
In-Reply-To: <YzMKHf+aNKiGVkyn@smile.fi.intel.com>
+ Hans
I forgot to Cc you yesterday even especially had a question for you :-(
Patch here and my comment to Andy below.
https://patchwork.ozlabs.org/project/linux-i2c/patch/20220927135644.1656369-1-jarkko.nikula@linux.intel.com/
On 9/27/22 17:35, Andy Shevchenko wrote:
> On Tue, Sep 27, 2022 at 04:56:44PM +0300, Jarkko Nikula wrote:
>> #define STATUS_IDLE 0x0
>
> A side note: I think the clearer is to use STATUS_MASK and use
> '&= ~STATUS_MASK' instead of '= STATUS_IDLE' in the affected pieces
> of the code.
>
>> -#define STATUS_WRITE_IN_PROGRESS 0x1
>> -#define STATUS_READ_IN_PROGRESS 0x2
>> +#define STATUS_ACTIVE 0x1
>> +#define STATUS_WRITE_IN_PROGRESS 0x2
>> +#define STATUS_READ_IN_PROGRESS 0x4
>
> Can we at the same time replace them with BIT()?
>
> ...
>
> Otherwise looks good to me,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
Good points. I'll add these to follow up patches.
Jarkko
next prev parent reply other threads:[~2022-09-28 5:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 13:56 [PATCH] i2c: designware: Fix handling of real but unexpected device interrupts Jarkko Nikula
2022-09-27 14:35 ` Andy Shevchenko
2022-09-28 5:49 ` Jarkko Nikula [this message]
2022-09-28 8:13 ` Hans de Goede
2022-10-01 22:40 ` Wolfram Sang
2022-10-02 8:10 ` Hans de Goede
2022-10-05 19:01 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31477388-b57b-5383-9c6a-18905c28253e@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=slc2015@gmail.com \
--cc=stable@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.