From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 04/29] drm/omap: Use atomic suspend/resume helpers Date: Mon, 10 Dec 2018 08:49:57 +0200 Message-ID: <3149436.95CKvIV4Vr@avalon> References: <20181205150022.24200-1-laurent.pinchart@ideasonboard.com> <20181205150022.24200-5-laurent.pinchart@ideasonboard.com> <20181209215309.uktuwmbvci6r55db@earth.universe> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id BC98F6E2F3 for ; Mon, 10 Dec 2018 06:49:19 +0000 (UTC) In-Reply-To: <20181209215309.uktuwmbvci6r55db@earth.universe> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sebastian Reichel Cc: Tomi Valkeinen , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgU2ViYXN0aWFuLAoKT24gU3VuZGF5LCA5IERlY2VtYmVyIDIwMTggMjM6NTM6MDkgRUVUIFNl YmFzdGlhbiBSZWljaGVsIHdyb3RlOgo+IEhpLAo+IAo+IE9uIFdlZCwgRGVjIDA1LCAyMDE4IGF0 IDA0OjU5OjU3UE0gKzAyMDAsIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPiBJbnN0ZWFkIG9m IHJvbGxpbmcgb3V0IGN1c3RvbSBzdXNwZW5kL3Jlc3VtZSBpbXBsZW1lbnRhdGlvbnMgYmFzZWQg b24KPiA+IHN0YXRlIGluZm9ybWF0aW9uIHN0b3JlZCBpbiB0aGUgZHJpdmVyJ3MgZGF0YSBzdHJ1 Y3R1cmVzLCB1c2UgdGhlIGF0b21pYwo+ID4gc3VzcGVuZC9yZXN1bWUgaGVscGVycyB0aGF0IHJl bHkgb24gYSBEUk0gYXRvbWljIHN0YXRlIG9iamVjdC4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTog TGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgo+ID4g LS0tCj4gCj4gRG9jdW1lbnRhdGlvbi9ncHUvdG9kby5yc3Qgc2F5cywgdGhhdCB0aGlzIHNob3Vs ZCBiZSBjb252ZXJ0ZWQgdG8KPiBkcm1fbW9kZV9jb25maWdfaGVscGVyX3N1c3BlbmQsIGJ1dCBh dCBsZWFzdCBpdCdzIG5vIGxvbmdlciBvcGVuCj4gY29kZWQgYWZ0ZXIgeW91ciBjaGFuZ2UuCgpH b29kIHBvaW50LiBJJ2xsIGZpeCB0aGlzIGluIHRoZSBuZXh0IHZlcnNpb24uIFRoYW5rIHlvdSBm b3IgcG9pbnRpbmcgaXQgb3V0LgoKPiBSZXZpZXdlZC1ieTogU2ViYXN0aWFuIFJlaWNoZWwgPHNl YmFzdGlhbi5yZWljaGVsQGNvbGxhYm9yYS5jb20+Cj4gCj4gPiAgZHJpdmVycy9ncHUvZHJtL29t YXBkcm0vZHNzL29tYXBkc3MuaCB8ICAzIC0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL29tYXBkcm0v b21hcF9kcnYuYyAgICB8IDUyICsrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gIGRyaXZl cnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfZHJ2LmggICAgfCAgMiArKwo+ID4gIDMgZmlsZXMgY2hh bmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgNDYgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9kc3Mvb21hcGRzcy5oCj4gPiBiL2RyaXZlcnMv Z3B1L2RybS9vbWFwZHJtL2Rzcy9vbWFwZHNzLmggaW5kZXggZDNiNTc2ZTZlZGY1Li4xNDlhMGYw OWFkYmMKPiA+IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vZHNzL29t YXBkc3MuaAo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vZHNzL29tYXBkc3MuaAo+ ID4gQEAgLTQzMiw5ICs0MzIsNiBAQCBzdHJ1Y3Qgb21hcF9kc3NfZGV2aWNlIHsKPiA+IAo+ID4g IAl1bnNpZ25lZCBsb25nIG9wc19mbGFnczsKPiA+ICAJdW5zaWduZWQgbG9uZyBidXNfZmxhZ3M7 Cj4gPiAKPiA+IC0JLyogaGVscGVyIHZhcmlhYmxlIGZvciBkcml2ZXIgc3VzcGVuZC9yZXN1bWUg Ki8KPiA+IC0JYm9vbCBhY3RpdmF0ZV9hZnRlcl9yZXN1bWU7Cj4gPiAtCj4gPiAKPiA+ICAJZW51 bSBvbWFwX2Rpc3BsYXlfY2FwcyBjYXBzOwo+ID4gIAkKPiA+ICAJZW51bSBvbWFwX2Rzc19kaXNw bGF5X3N0YXRlIHN0YXRlOwo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL29t YXBkcm0vb21hcF9kcnYuYwo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2Rydi5j IGluZGV4IDVlNjdkNThjYmMyOC4uNjZjNGNlZGI1NTM5Cj4gPiAxMDA2NDQKPiA+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfZHJ2LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9vbWFwZHJtL29tYXBfZHJ2LmMKPiA+IEBAIC02ODUsNTIgKzY4NSwyMSBAQCBzdGF0aWMgaW50 IHBkZXZfcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gPiAKPiA+ICB9Cj4g PiAgCj4gPiAgI2lmZGVmIENPTkZJR19QTV9TTEVFUAo+ID4gCj4gPiAtc3RhdGljIGludCBvbWFw X2RybV9zdXNwZW5kX2FsbF9kaXNwbGF5cyhzdHJ1Y3QgZHJtX2RldmljZSAqZGRldikKPiA+IC17 Cj4gPiAtCXN0cnVjdCBvbWFwX2RybV9wcml2YXRlICpwcml2ID0gZGRldi0+ZGV2X3ByaXZhdGU7 Cj4gPiAtCWludCBpOwo+ID4gLQo+ID4gLQlmb3IgKGkgPSAwOyBpIDwgcHJpdi0+bnVtX3BpcGVz OyBpKyspIHsKPiA+IC0JCXN0cnVjdCBvbWFwX2Rzc19kZXZpY2UgKmRpc3BsYXkgPSBwcml2LT5w aXBlc1tpXS5kaXNwbGF5Owo+ID4gLQo+ID4gLQkJaWYgKGRpc3BsYXktPnN0YXRlID09IE9NQVBf RFNTX0RJU1BMQVlfQUNUSVZFKSB7Cj4gPiAtCQkJZGlzcGxheS0+b3BzLT5kaXNhYmxlKGRpc3Bs YXkpOwo+ID4gLQkJCWRpc3BsYXktPmFjdGl2YXRlX2FmdGVyX3Jlc3VtZSA9IHRydWU7Cj4gPiAt CQl9IGVsc2Ugewo+ID4gLQkJCWRpc3BsYXktPmFjdGl2YXRlX2FmdGVyX3Jlc3VtZSA9IGZhbHNl Owo+ID4gLQkJfQo+ID4gLQl9Cj4gPiAtCj4gPiAtCXJldHVybiAwOwo+ID4gLX0KPiA+IC0KPiA+ IC1zdGF0aWMgaW50IG9tYXBfZHJtX3Jlc3VtZV9hbGxfZGlzcGxheXMoc3RydWN0IGRybV9kZXZp Y2UgKmRkZXYpCj4gPiAtewo+ID4gLQlzdHJ1Y3Qgb21hcF9kcm1fcHJpdmF0ZSAqcHJpdiA9IGRk ZXYtPmRldl9wcml2YXRlOwo+ID4gLQlpbnQgaTsKPiA+IC0KPiA+IC0JZm9yIChpID0gMDsgaSA8 IHByaXYtPm51bV9waXBlczsgaSsrKSB7Cj4gPiAtCQlzdHJ1Y3Qgb21hcF9kc3NfZGV2aWNlICpk aXNwbGF5ID0gcHJpdi0+cGlwZXNbaV0uZGlzcGxheTsKPiA+IC0KPiA+IC0JCWlmIChkaXNwbGF5 LT5hY3RpdmF0ZV9hZnRlcl9yZXN1bWUpIHsKPiA+IC0JCQlkaXNwbGF5LT5vcHMtPmVuYWJsZShk aXNwbGF5KTsKPiA+IC0JCQlkaXNwbGF5LT5hY3RpdmF0ZV9hZnRlcl9yZXN1bWUgPSBmYWxzZTsK PiA+IC0JCX0KPiA+IC0JfQo+ID4gLQo+ID4gLQlyZXR1cm4gMDsKPiA+IC19Cj4gPiAtCj4gPiAK PiA+ICBzdGF0aWMgaW50IG9tYXBfZHJtX3N1c3BlbmQoc3RydWN0IGRldmljZSAqZGV2KQo+ID4g IHsKPiA+ICAKPiA+ICAJc3RydWN0IG9tYXBfZHJtX3ByaXZhdGUgKnByaXYgPSBkZXZfZ2V0X2Ry dmRhdGEoZGV2KTsKPiA+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRybV9kZXYgPSBwcml2LT5kZGV2 Owo+ID4gCj4gPiArCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZTsKPiA+IAo+ID4gIAlk cm1fa21zX2hlbHBlcl9wb2xsX2Rpc2FibGUoZHJtX2Rldik7Cj4gPiAKPiA+IC0JZHJtX21vZGVz ZXRfbG9ja19hbGwoZHJtX2Rldik7Cj4gPiAtCW9tYXBfZHJtX3N1c3BlbmRfYWxsX2Rpc3BsYXlz KGRybV9kZXYpOwo+ID4gLQlkcm1fbW9kZXNldF91bmxvY2tfYWxsKGRybV9kZXYpOwo+ID4gKwlz dGF0ZSA9IGRybV9hdG9taWNfaGVscGVyX3N1c3BlbmQoZHJtX2Rldik7Cj4gPiArCWlmIChJU19F UlIoc3RhdGUpKSB7Cj4gPiArCQlkcm1fa21zX2hlbHBlcl9wb2xsX2VuYWJsZShkcm1fZGV2KTsK PiA+ICsJCXJldHVybiBQVFJfRVJSKHN0YXRlKTsKPiA+ICsJfQo+ID4gKwo+ID4gKwlwcml2LT5z dXNwZW5kX3N0YXRlID0gc3RhdGU7Cj4gPiAKPiA+ICAJcmV0dXJuIDA7Cj4gPiAgCj4gPiAgfQo+ ID4gCj4gPiBAQCAtNzQwLDEwICs3MDksNyBAQCBzdGF0aWMgaW50IG9tYXBfZHJtX3Jlc3VtZShz dHJ1Y3QgZGV2aWNlICpkZXYpCj4gPiAKPiA+ICAJc3RydWN0IG9tYXBfZHJtX3ByaXZhdGUgKnBy aXYgPSBkZXZfZ2V0X2RydmRhdGEoZGV2KTsKPiA+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRybV9k ZXYgPSBwcml2LT5kZGV2Owo+ID4gCj4gPiAtCWRybV9tb2Rlc2V0X2xvY2tfYWxsKGRybV9kZXYp Owo+ID4gLQlvbWFwX2RybV9yZXN1bWVfYWxsX2Rpc3BsYXlzKGRybV9kZXYpOwo+ID4gLQlkcm1f bW9kZXNldF91bmxvY2tfYWxsKGRybV9kZXYpOwo+ID4gLQo+ID4gKwlkcm1fYXRvbWljX2hlbHBl cl9yZXN1bWUoZHJtX2RldiwgcHJpdi0+c3VzcGVuZF9zdGF0ZSk7Cj4gPiAKPiA+ICAJZHJtX2tt c19oZWxwZXJfcG9sbF9lbmFibGUoZHJtX2Rldik7Cj4gPiAgCQo+ID4gIAlyZXR1cm4gb21hcF9n ZW1fcmVzdW1lKGRybV9kZXYpOwo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L29tYXBkcm0vb21hcF9kcnYuaAo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2Ry di5oIGluZGV4IGJkN2YyYzIyN2EyNS4uNzg4YWE5ZjdlNmRmCj4gPiAxMDA2NDQKPiA+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfZHJ2LmgKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9vbWFwZHJtL29tYXBfZHJ2LmgKPiA+IEBAIC03Myw2ICs3Myw4IEBAIHN0cnVjdCBvbWFw X2RybV9wcml2YXRlIHsKPiA+IAo+ID4gIAlzdHJ1Y3Qgd29ya3F1ZXVlX3N0cnVjdCAqd3E7Cj4g PiAKPiA+ICsJc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN1c3BlbmRfc3RhdGU7Cj4gPiArCj4g PiAKPiA+ICAJLyogbG9jayBmb3Igb2JqX2xpc3QgYmVsb3cgKi8KPiA+ICAJc3RydWN0IG11dGV4 IGxpc3RfbG9jazsKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK