From: Thomas Monjalon <thomas@monjalon.net>
To: Sarosh Arif <sarosh.arif@emumba.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/l2fwd: add promiscuous mode selection through command line option
Date: Mon, 25 Oct 2021 21:48:51 +0200 [thread overview]
Message-ID: <3152738.G4va1dxgnP@thomas> (raw)
In-Reply-To: <YWaYuCP1FdsvXh1h@bricha3-MOBL.ger.corp.intel.com>
13/10/2021 10:28, Bruce Richardson:
> On Wed, Oct 13, 2021 at 12:23:03PM +0500, Sarosh Arif wrote:
> > The default behaviour of l2fwd is to exit if we are unable to turn
> > promiscuous mode on. On some aws instances turning promiscuous mode
> > on is not permitted. In such cases there should be a way to run the
> > application without promiscuous mode.
> >
> > This patch allows user to turn promiscuous mode on via command line
> > parameter. l3fwd has a similar option available.
> >
> > Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
> > ---
>
> This is a behaviour change, but since this is sample application, I think
> it's acceptable, and agree that the change is needed.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied (with small reformat of the doc), thanks.
prev parent reply other threads:[~2021-10-25 19:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 7:23 [dpdk-dev] [PATCH] examples/l2fwd: add promiscuous mode selection through command line option Sarosh Arif
2021-10-13 8:28 ` Bruce Richardson
2021-10-25 19:48 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3152738.G4va1dxgnP@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=sarosh.arif@emumba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.