From: David Howells <dhowells@redhat.com>
To: Rene Herman <rene.herman@keyaccess.nl>
Cc: dhowells@redhat.com, bjorn.helgaas@hp.com, rene.herman@gmail.com,
len.brown@intel.com, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] Fix pnpacpi_parse_irq_option()'s test against PNP_IRQ_NR
Date: Fri, 27 Jun 2008 14:16:28 +0100 [thread overview]
Message-ID: <31574.1214572588@redhat.com> (raw)
In-Reply-To: <4864E2B1.3040308@keyaccess.nl>
Rene Herman <rene.herman@keyaccess.nl> wrote:
> Pedantically, a simple unadorned int would be better it seems. The #define is
> an int, __set_bit(_) takes an int and an int is printed.
Yes, but the test doesn't check for -ve values. If it's unsigned, it doesn't
need to.
> Hyper-pedantically, this adds one space too many :-)
Bah.
David
next prev parent reply other threads:[~2008-06-27 13:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 12:33 [PATCH] Fix pnpacpi_parse_irq_option()'s test against PNP_IRQ_NR David Howells
2008-06-27 12:53 ` Rene Herman
2008-06-27 13:16 ` David Howells [this message]
2008-06-27 13:38 ` Rene Herman
2008-06-27 14:54 ` David Howells
2008-06-27 15:14 ` Bjorn Helgaas
2008-06-27 15:26 ` Rene Herman
2008-06-27 15:38 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31574.1214572588@redhat.com \
--to=dhowells@redhat.com \
--cc=bjorn.helgaas@hp.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rene.herman@gmail.com \
--cc=rene.herman@keyaccess.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.