From: Thomas Monjalon <thomas@monjalon.net>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH] devtools: fix checkpatches subject retrieval from stdin
Date: Wed, 23 Nov 2022 17:33:21 +0100 [thread overview]
Message-ID: <3162672.aV6nBDHxoP@thomas> (raw)
In-Reply-To: <20220929120403.352-1-olivier.matz@6wind.com>
29/09/2022 14:04, Olivier Matz:
> When passing the patch to checkpatches.sh through stdin, the subject is
> retrieved by reading the input until a "Subject:" entry is found. The
> rest of the input is piped to checkpatch.pl.
>
> Since the "From:" line is before the "Subject:" line, it won't be sent to
> checkpatch.pl, which won't be able to get the author of the commit.
> The following error will appear:
>
> > ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author ''
>
> Do the subject lookup on the temporary file instead of stdin, and
> send the whole lines to checkpatch.pl.
>
> The problem is visible since the introduction of this check in linux
> checkpatch.pl in version 4.19 (see link below).
>
> Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cd2614967d8b
> Fixes: 8005feef421d ("scripts: add standard input to checkpatch")
> CC: stable@dpdk.org
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
Applied, thanks.
prev parent reply other threads:[~2022-11-23 16:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 12:04 [PATCH] devtools: fix checkpatches subject retrieval from stdin Olivier Matz
2022-11-23 16:33 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3162672.aV6nBDHxoP@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.