From: Joe Malicki <jmalicki@metacarta.com>
To: Bo Yang <Bo.Yang@lsi.com>
Cc: linux-scsi@vger.kernel.org
Subject: megaraid_sas dbg_lvl permissions
Date: Thu, 14 Aug 2008 17:14:48 -0400 (EDT) [thread overview]
Message-ID: <31647799.1118451218748488466.JavaMail.root@ouachita> (raw)
In-Reply-To: <25702243.1118401218748366053.JavaMail.root@ouachita>
/sys/bus/pci/drivers/megaraid_sas/dbg_lvl defaults to being world-writable, which
seems bad (letting any user affect kernel driver behavior and logging level).
This turns off group and user write permissions, so that on typical production systems
only root can write to it.
Signed-off-by: Joseph Malicki <jmalicki@metacarta.com>
--
--- drivers/scsi/megaraid/megaraid_sas.c.orig 2008-01-31 10:49:57.000000000 -0500
+++ drivers/scsi/megaraid/megaraid_sas.c 2008-01-31 10:52:10.000000000 -0500
@@ -3044,7 +3044,7 @@
return retval;
}
-static DRIVER_ATTR(dbg_lvl, S_IRUGO|S_IWUGO, megasas_sysfs_show_dbg_lvl,
+static DRIVER_ATTR(dbg_lvl, S_IRUGO|S_IWUSR, megasas_sysfs_show_dbg_lvl,
megasas_sysfs_set_dbg_lvl);
/**
--
next parent reply other threads:[~2008-08-14 21:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <25702243.1118401218748366053.JavaMail.root@ouachita>
2008-08-14 21:14 ` Joe Malicki [this message]
2008-08-15 14:44 ` megaraid_sas dbg_lvl permissions Yang, Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31647799.1118451218748488466.JavaMail.root@ouachita \
--to=jmalicki@metacarta.com \
--cc=Bo.Yang@lsi.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.