All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Matěj Laitl" <matej@laitl.cz>
To: Daniel Mack <zonque@gmail.com>
Cc: Sarah Sharp <sarah.a.sharp@linux.intel.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Florian Mickler <florian@mickler.org>,
	Oliver Neukum <oliver@neukum.org>,
	linux-usb@vger.kernel.org, alsa-devel@alsa-project.org,
	Takashi Iwai <tiwai@suse.de>,
	Clemens Ladisch <clemens@ladisch.de>,
	pedrib@gmail.com, William Light <wrl@illest.net>,
	Greg KH <greg@kroah.com>,
	linux-kernel@vger.kernel.org,
	Robert Hancock <hancockrwd@gmail.com>
Subject: Re: Allocating buffers for USB transfers (again)
Date: Fri, 12 Aug 2011 01:29:53 +0200	[thread overview]
Message-ID: <3166003.Y8gKYdUrh9@edgy> (raw)
In-Reply-To: <CACTFLAMcOMv4D8k-P24TAkPwLRgYps4hoO-vC1NH+cibcsrUFQ@mail.gmail.com>

On 11. 8. 2011 Daniel Mack wrote:
> On Thu, Aug 11, 2011 at 8:05 PM, Sarah Sharp
> > Because according to Matej, he applied that patch, plus my patch to
> > reject zero-length buffers[1], and he saw debugging that indicated he
> > *did* see zero-length buffers.  Is there any chance your driver might
> > submit a zero-length buffer in the middle of the isochronous URB
> > transfer array?
> 
> Hmm, judging from the code, this can only ever happen if we receive an
> inbound iso frame which has a valid status and an actual_length of
> zero. Also, it was not neccessary to catch this case for EHCI.
> 
> Maetj, does this patch make any difference?

This patch actually makes the sound playback _worse_. Now I get strange 
squawks where previously at least first seconds of a song sounded normally.

However, I no longer get "zero length buffer submitted" or that "... Weird." 
debug messages, only several megabytes of: (should I post these somewhere?)

xhci_hcd 0000:05:00.0: Giveback URB ffff880114cec000, len = 880, expected = 
1000, status = -115
xhci_hcd 0000:05:00.0: Giveback URB ffff880114740000, len = 352, expected = 
1000, status = -115
xhci_hcd 0000:05:00.0: underrun event on endpoint

Regards,
                 Matej

  reply	other threads:[~2011-08-11 23:29 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-07 11:53 Allocating buffers for USB transfers (again) Daniel Mack
2011-07-07 11:53 ` Daniel Mack
     [not found] ` <CACTFLANCYMXH=z+NxEF0aqpMGZp21Q16_uB=J3rndM3pW74qeA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-07-07 12:14   ` Clemens Ladisch
2011-07-07 12:14     ` Clemens Ladisch
     [not found]     ` <4E15A308.7080502-P6GI/4k7KOmELgA04lAiVw@public.gmane.org>
2011-07-07 12:29       ` Daniel Mack
2011-07-07 12:29         ` Daniel Mack
2011-07-07 12:33 ` Oliver Neukum
2011-07-07 12:38   ` Daniel Mack
2011-07-07 13:08     ` Oliver Neukum
     [not found]       ` <201107071508.43988.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2011-07-08 15:13         ` Daniel Mack
2011-07-08 15:13           ` Daniel Mack
2011-07-07 15:06     ` Alan Stern
2011-07-07 15:06       ` Alan Stern
     [not found]     ` <CACTFLAN=GOw8KLtvVBM6omvYzW3RBHggv-Kc2_2QVD--M-Jxkg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-07-07 15:16       ` Florian Mickler
2011-07-07 15:16         ` Florian Mickler
2011-08-10  7:51         ` Daniel Mack
2011-08-10  7:51           ` Daniel Mack
2011-08-10 14:32           ` Alan Stern
2011-08-10 14:32             ` Alan Stern
2011-08-10 15:33             ` Daniel Mack
2011-08-10 15:33               ` Daniel Mack
2011-08-10 18:06               ` Takashi Iwai
2011-08-10 18:06                 ` Takashi Iwai
2011-08-10 23:15               ` Sarah Sharp
2011-08-11  0:57                 ` Daniel Mack
2011-08-11  0:57                   ` Daniel Mack
     [not found]                   ` <CACTFLAP9eRG6TVtFsNGO+oDu0U0gOUth-_TzLeW2yGb6Jxn2tA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-11 16:45                     ` Sarah Sharp
2011-08-11 16:45                       ` Sarah Sharp
2011-08-11 17:27                       ` Daniel Mack
2011-08-11 17:27                         ` Daniel Mack
     [not found]                         ` <CACTFLAOi5u-YL+FKGotPSBv5BgEhKO5FLwZeJKdgyis3nZLbcw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-11 18:05                           ` Sarah Sharp
2011-08-11 18:05                             ` Sarah Sharp
2011-08-11 21:39                             ` Daniel Mack
2011-08-11 23:29                               ` Matěj Laitl [this message]
2011-08-11 23:40                                 ` Daniel Mack
2011-08-11 23:40                                   ` Daniel Mack
2011-08-11 23:50                                   ` Matěj Laitl
2011-08-12  1:28                                     ` Daniel Mack
2011-08-12  1:28                                       ` Daniel Mack
     [not found]                                       ` <CACTFLANyL95Gy6c2YznV-h0tYdZ7nvRhObsq8dvp9n4_9=D_Mw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-12  4:46                                         ` Sarah Sharp
2011-08-12  4:46                                           ` Sarah Sharp
2011-08-12  9:55                                           ` Daniel Mack
2011-08-12  9:55                                             ` Daniel Mack
2011-08-11  3:22                 ` Andiry Xu
2011-08-11  3:22                   ` Andiry Xu
2011-08-11 14:36                   ` Alan Stern
2011-08-11 14:36                     ` Alan Stern
2011-07-07 13:53 ` Johannes Stezenbach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3166003.Y8gKYdUrh9@edgy \
    --to=matej@laitl.cz \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=florian@mickler.org \
    --cc=greg@kroah.com \
    --cc=hancockrwd@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oliver@neukum.org \
    --cc=pedrib@gmail.com \
    --cc=sarah.a.sharp@linux.intel.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tiwai@suse.de \
    --cc=wrl@illest.net \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.