From: Chris Mason <mason@suse.com>
To: Linus Torvalds <torvalds@transmeta.com>,
"David S. Miller" <davem@redhat.com>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>, linux-kernel@vger.kernel.org
Subject: Re: set_page_dirty/page_launder deadlock
Date: Wed, 17 Jan 2001 14:57:26 -0500 [thread overview]
Message-ID: <31670000.979761446@tiny> (raw)
In-Reply-To: <Pine.LNX.4.10.10101141054530.4086-100000@penguin.transmeta.com>
On Sunday, January 14, 2001 10:56:10 AM -0800 Linus Torvalds
<torvalds@transmeta.com> wrote:
>> Marcelo Tosatti writes:
>> >
>> > While taking a look at page_launder()...
>>
>> ...
>>
>> > set_page_dirty() may lock the pagecache_lock which means potential
>> > deadlock since we have the pagemap_lru_lock locked.
>>
>
> Well, as the new shm code doesn't return 1 any more, the whole locked page
> handling should just be deleted. ramfs always just re-marked the page
> dirty in its own "writepage()" function, so it was only shmfs that ever
> returned this special case, and because of other issues it already got
> excised by Christoph..
>
Then I'm confused by the code in 2.4.1pre8:
-chris
/*
* Move the page from the page cache to the swap cache
*/
static int shmem_writepage(struct page * page)
{
int error;
struct shmem_inode_info *info;
swp_entry_t *entry, swap;
info = &page->mapping->host->u.shmem_i;
if (info->locked)
return 1;
swap = __get_swap_page(2);
if (!swap.val)
return 1;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-01-17 19:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-14 3:21 set_page_dirty/page_launder deadlock Marcelo Tosatti
2001-01-14 13:27 ` David S. Miller
2001-01-14 18:56 ` Linus Torvalds
2001-01-17 19:57 ` Chris Mason [this message]
2001-01-19 17:44 ` Christoph Rohland
2001-01-23 18:28 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31670000.979761446@tiny \
--to=mason@suse.com \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.