From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXPPh-0004W5-7d for qemu-devel@nongnu.org; Wed, 10 Aug 2016 05:03:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bXPPb-0007ka-MG for qemu-devel@nongnu.org; Wed, 10 Aug 2016 05:03:00 -0400 Received: from mx4-phx2.redhat.com ([209.132.183.25]:49780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXPPb-0007kP-Db for qemu-devel@nongnu.org; Wed, 10 Aug 2016 05:02:55 -0400 Date: Wed, 10 Aug 2016 05:02:53 -0400 (EDT) From: Paolo Bonzini Message-ID: <317165270.783006.1470819773170.JavaMail.zimbra@redhat.com> In-Reply-To: <20160810105730.6bba1a6f.cornelia.huck@de.ibm.com> References: <1470817370-145190-1-git-send-email-pbonzini@redhat.com> <1470817370-145190-2-git-send-email-pbonzini@redhat.com> <20160810105730.6bba1a6f.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/5] checkpatch: tweak the files in which TABs are checked List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: qemu-devel@nongnu.org, thuth@redhat.com, armbru@redhat.com, famz@redhat.com ----- Original Message ----- > From: "Cornelia Huck" > To: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, thuth@redhat.com, armbru@redhat.com, famz@redhat.com > Sent: Wednesday, August 10, 2016 10:57:30 AM > Subject: Re: [PATCH 1/5] checkpatch: tweak the files in which TABs are checked > > On Wed, 10 Aug 2016 10:22:46 +0200 > Paolo Bonzini wrote: > > > Include Python and shell scripts, and make an exception for Perl > > scripts we imported from Linux or elsewhere. > > > > Signed-off-by: Paolo Bonzini > > --- > > scripts/checkpatch.pl | 9 +++++---- > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > > index 8d1813e..082c4ce 100755 > > --- a/scripts/checkpatch.pl > > +++ b/scripts/checkpatch.pl > > @@ -1334,7 +1334,7 @@ sub process { > > } > > > > # check we are in a valid source file if not then ignore this hunk > > - next if ($realfile !~ /\.(h|c|cpp|s|S|pl|sh)$/); > > + next if ($realfile !~ /\.(h|c|cpp|s|S|pl|py|sh)$/); > > Do all of our checks work for python as well? Only these: ERROR("line over 90 characters\n" . $herecurr); WARN("line over 80 characters\n" . $herecurr); ERROR("unnecessary whitespace before a quoted newline\n" . $herecurr); ERROR("adding a line without newline at end of file\n" . $herecurr); ERROR("CVS style keyword markers, these will _not_ be updated\n". $herecurr); ERROR("code indent should never use tabs\n" . $herevet); After which there is a # check we are in a valid C source file if not then ignore this hunk next if ($realfile !~ /\.(h|c|cpp)$/); > Looks reasonable. Do you plan to include the "skip header updates" > patch as well? Yes. Paolo