From: John Garry <john.garry@linux.dev>
To: Yang Xiuwei <yangxiuwei@kylinos.cn>, john.g.garry@oracle.com
Cc: James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, dlemoal@kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 1/3] scsi: sd: fix error handling in sd_probe() after large pool creation failure
Date: Wed, 8 Jul 2026 08:57:52 +0100 [thread overview]
Message-ID: <31718d0f-b170-41a4-8a3f-9d15582e98c8@linux.dev> (raw)
In-Reply-To: <20260708072249.264705-1-yangxiuwei@kylinos.cn>
On 7/8/26 08:22, Yang Xiuwei wrote:
> On Wed, 08 Jul 2026, John Garry wrote:
>> However, would it be simpler to always create this pool for LBS enabled
>> (and not just when we probe some disk which has sector size > PAGE_SIZE)?
> Yeah — same idea as sd_page_pool at init. sd_probe already has quite a
> few error paths; I had a go at consolidating them in v1 but dropped it.
> Moving the pool to init seems like a cleaner approach.
Sure, but - as I said - it may waste memory if we (likely) have no disks
with sector size > page size. Maybe it's better as is (to alloc in probe
path).
next prev parent reply other threads:[~2026-07-08 7:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 3:03 [PATCH v2 0/3] scsi: sd: fix probe error cleanup, special_vec leak and sd_done() sense gate Yang Xiuwei
2026-07-07 3:03 ` [PATCH v2 1/3] scsi: sd: fix error handling in sd_probe() after large pool creation failure Yang Xiuwei
2026-07-07 3:30 ` sashiko-bot
2026-07-08 6:29 ` John Garry
2026-07-08 7:22 ` Yang Xiuwei
2026-07-08 7:57 ` John Garry [this message]
2026-07-07 3:03 ` [PATCH v2 2/3] scsi: sd: fix special_vec mempool leak when scsi_alloc_sgtables() fails Yang Xiuwei
2026-07-07 3:26 ` sashiko-bot
2026-07-08 6:32 ` John Garry
2026-07-07 3:03 ` [PATCH v2 3/3] scsi: sd: fix sd_done() sense handling condition Yang Xiuwei
2026-07-08 16:07 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31718d0f-b170-41a4-8a3f-9d15582e98c8@linux.dev \
--to=john.garry@linux.dev \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dlemoal@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yangxiuwei@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.